From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#30609: 26.0.91; underline should be drawn behind text Date: Mon, 26 Feb 2018 13:10:06 -0800 Message-ID: References: <83vaej21qa.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1519679355 12897 195.159.176.226 (26 Feb 2018 21:09:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Feb 2018 21:09:15 +0000 (UTC) Cc: 30609@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 26 22:09:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqQ1H-0002sD-0x for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Feb 2018 22:09:11 +0100 Original-Received: from localhost ([::1]:33269 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqQ3I-00009F-T8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Feb 2018 16:11:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqQ39-00008Q-5w for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 16:11:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqQ34-0004Jj-Og for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 16:11:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54342) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqQ34-0004JL-KM for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 16:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eqQ34-0004wJ-CR for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 16:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Feb 2018 21:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30609 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30609-submit@debbugs.gnu.org id=B30609.151967941518928 (code B ref 30609); Mon, 26 Feb 2018 21:11:02 +0000 Original-Received: (at 30609) by debbugs.gnu.org; 26 Feb 2018 21:10:15 +0000 Original-Received: from localhost ([127.0.0.1]:34006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqQ2I-0004vE-Qb for submit@debbugs.gnu.org; Mon, 26 Feb 2018 16:10:15 -0500 Original-Received: from mail-qt0-f176.google.com ([209.85.216.176]:42747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqQ2G-0004v2-Ok for 30609@debbugs.gnu.org; Mon, 26 Feb 2018 16:10:12 -0500 Original-Received: by mail-qt0-f176.google.com with SMTP id t6so11072852qtn.9 for <30609@debbugs.gnu.org>; Mon, 26 Feb 2018 13:10:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uV4R+LWVk8Fl7WW+SZDHQqkii//IlPuDllI1PyO5htM=; b=G8ErxjI+w3+vtzhLX+GYZeXRgzYwBvprtKCiUWT4NPh0HN+Hs1M29DDTD8DEMzeEHm 7F1AH3Qi2Svge4wthsi0vbb3cvVSn6FzBRpVvQ6N8wlqd2lKTthQD74DC2ekybrUFY4F lV6BT4d2i43nUSMfStrMcJsXwqKVZsMgVPxXgeyKjuVcB/pIZ6PhaMKphjUS7RAdQ5oj G1aJxYQRlPZlHo54bw4/000D/zXAJW1GbNorIaWsO2rP8eZb4rrsYH30pXNG6NZc4iyh sgtaoSVawNHhKEW/05N1D7LH4PDnpXGl2maS9dtPwMylFwyZFmYIFmKUpIMD3zYTs8EE GBvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uV4R+LWVk8Fl7WW+SZDHQqkii//IlPuDllI1PyO5htM=; b=jSAZbXWDajB+vuZQFCJ6hinDt7+aCHiS8LGvOq98tXqjQq81TK8DxCTaJCjOzSWoiZ ibICKsPKhryUauZ3laVi5KkbK6YXniLiyAA/wXgZiKCvUT8TbX04m98RBYk3CCvXfrTg Rr6sZ/3RcJlky5b5g2F4nmHvS5GJDJGUU1fmHFJBmQVKkSZvABGydbFz9YXI4eLapaoR KZF5wjBPfZfBxQKoKNxLSPk4ILxXQ4+R9JapFoYHlze2Q+GXg5bulYoGOYB0mj+hDOI0 4kQi3n9Zznqr+gDWn5HHL6V31MYMFFtKOZ2JDn9OUR5tOPxmO+/0eXf4A9+bciqueIq8 Uaag== X-Gm-Message-State: APf1xPCEsflC7D9n+KHc/U8RAwfzGXfjAXnDIPIYezvzzZfL1Eh7S/B/ YzH0kPbPgeJZalkDwXqMLgS+hnJ4Rr2dIwIunV8= X-Google-Smtp-Source: AG47ELuS+ztUI3B8hgXSoE9q7DbCPKLo2+ICP1EmkoM2slhXJAl3dmn08pM+WIFeAlZ4U3HL/18JaH/ZhsdVAfAHRs8= X-Received: by 10.237.35.76 with SMTP id i12mr19182766qtc.134.1519679407486; Mon, 26 Feb 2018 13:10:07 -0800 (PST) Original-Received: by 10.237.54.65 with HTTP; Mon, 26 Feb 2018 13:10:06 -0800 (PST) In-Reply-To: <83vaej21qa.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143681 Archived-At: On Mon, Feb 26, 2018 at 7:46 AM, Eli Zaretskii wrote: > Yes, this is what I feared, and that's why I think simply switching > the order will not give good results. I may be able to move the text decoration code to the font drawing, but text decoration is done for more than fonts, so that could result in some duplication or nsterm referencing nsfont which would then reference nsterm. If that's ok, I can look into that. The other option would be to move the background drawing code out of the font rendering. I don't know all of the places that it is done, so that may be cumbersome. One other, completely different idea that may not work or may be really slow would be to do a color replacement--only replacing pixels that match the background color with the underline color. I have no idea if reading from the canvas in this way is slow. This would end up giving a similar effect to text-decoration-skip.