From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode Date: Tue, 5 Feb 2019 08:43:52 -0800 Message-ID: References: <87lg36m2rp.fsf@gmx.de> <8736p3bnjh.fsf@gmx.de> <877eeewg8c.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="185650"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34196@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 05 17:51:49 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gr3wr-000mDL-ID for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Feb 2019 17:51:49 +0100 Original-Received: from localhost ([127.0.0.1]:34810 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gr3wq-0000Sd-9h for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Feb 2019 11:51:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gr3qJ-00046B-62 for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2019 11:45:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gr3qI-000114-Cs for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2019 11:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34413) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gr3qI-00010v-9b for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2019 11:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gr3qI-0002MP-3I for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2019 11:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Feb 2019 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34196 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 34196-submit@debbugs.gnu.org id=B34196.15493850509003 (code B ref 34196); Tue, 05 Feb 2019 16:45:02 +0000 Original-Received: (at 34196) by debbugs.gnu.org; 5 Feb 2019 16:44:10 +0000 Original-Received: from localhost ([127.0.0.1]:33694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gr3pS-0002L9-90 for submit@debbugs.gnu.org; Tue, 05 Feb 2019 11:44:10 -0500 Original-Received: from mail-yw1-f49.google.com ([209.85.161.49]:44334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gr3pR-0002Kw-4A for 34196@debbugs.gnu.org; Tue, 05 Feb 2019 11:44:09 -0500 Original-Received: by mail-yw1-f49.google.com with SMTP id x21so629416ywx.11 for <34196@debbugs.gnu.org>; Tue, 05 Feb 2019 08:44:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=os71CJTRTrDzvPZZ+2mTvb8FMGqixnIL9XJlaMTyqTI=; b=p5i7XZUwTKkOuAO4+kWAhCeLIwbDSb8yaFSk3PGKg5AClK4IpTB+thgsXRzYYcH2LR ZWO7IdHS6K//NMQwnERysksVTYNe7fB755szG6KlqNgZf/u5leeIYHEShe6aSeF8/NJO kI0X0mQBQhiDJ8eB6RvKog1c3SWRGoHHhshv4Cgd38XfN6Vhd2o5iQwuxj4WpxAHQriX cTxhnaRPLC02BNpCzBg4qFI+mqzBZRwyjg1YFErW1t/C46vLmmd4mNPSmEF0AoZ/Is2k /COM8MCpMEiyjetOG90SJsru1A4qpeYMx7uiwjo2Tc0ghBp6ULxlPGkll//rSJ4dLGns bCVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=os71CJTRTrDzvPZZ+2mTvb8FMGqixnIL9XJlaMTyqTI=; b=GZSQIekI6I+JIxkObuVpqF0o/E9vM8Zp8EscXC5HEdBNpSUhuhlls3Zp2yQRlOXuxG lqAyZ1RQAnyzxaOYRkEviV9HU1wslNnU75UbEEjUBa6wCB8ouCorLVaXzfXnZFhIraoP BsOToTEl7FvRb5YSxtAS35oylVosG12eyij8YeUgX6cJQY0dopPhOcqXSsCQ1wAe6OHS 8J6uKzOXF4UldYPeBvSw9kwgtyEXykn/IsGAFhZDgOWylSbTtFlo3B6Oc8qyAjk71AQ2 p77eKQOq2IAWZWu1peP64UzCbKB9CBeAQ2XhBcJAKOKkR1a4/fZzuLycgQ2myCFHLjUq 3TbA== X-Gm-Message-State: AHQUAuaRCJtz+SUOKNQ1j86SnJ2D5Jb7/UWh8N3dAF8Ve1Qpjv/K6LzD wN8k4BXnBd7rz2HDtsUEqWMbSEHNd1+huMetcZc= X-Google-Smtp-Source: AHgI3Ia4bM91Kx5JwLDzRAoyT6iWL+Pj+AL/w0uynMcfJ7kNC/SBxvMgRDblJlQe78suIhAWxcsn2QZASMHCdSU3t/Q= X-Received: by 2002:a81:650b:: with SMTP id z11mr4502087ywb.441.1549385043424; Tue, 05 Feb 2019 08:44:03 -0800 (PST) In-Reply-To: <877eeewg8c.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155139 Archived-At: On Tue, Feb 5, 2019 at 4:51 AM Michael Albinus wrote: > > [Pls keep the Cc, for the archives] Sorry, clicked the wrong button, thank you for the reminder. > > I think that not-yet-connected tramp buffers need to be excluded from > > garm entirely, if that is possible. > > Good idea. I've appended a patch, which reverts the last change from > tramp.el, and implements your proposal in autorevert.el. This is also > better, because Tramp as library shouldn't care about auto-revert. > > Could you, pls, check whether this works for you? It works brilliantly as far as I can tell in both emacs -Q and my config. Is there any cost to an extra loop over all buffers and doing with-current-buffer? I wonder if a change to auto-revert-active-p would be better than looping through all of the buffers and with-current-buffering them again. I don't know if that's semantically wrong for that function. Another option is putting a check in auto-revert-notify-add-watch, since that already has checks to ensure the file is okay to be watched: (or auto-revert-notify-watch-descriptor (and (file-remote-p default-directory) (not (file-remote-p default-directory nil t))) (string-match auto-revert-notify-exclude-dir-regexp (expand-file-name default-directory)) (file-symlink-p (or buffer-file-name default-directory))) With that in place, even if I enable auto-revert-remote-files I don't experience the hang. Thanks, Aaron