bug#30364: 26.0.91; thread crash on macos

[Aaron Jensen <aaronjensen@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

On Mon, Feb 19, 2018 at 10:33 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> Thanks.  I guess we should go with 4MB for 32-bit builds and 8MB for
> 64-bit.

Updated patch attached, hopefully that's the right way of detecting x64/x86.

Aaron

[-- Attachment #2: 0001-Require-a-larger-stack-size-for-threads-bug-30364.patch --]
[-- Type: application/octet-stream, Size: 1333 bytes --]

From f1f091e3a9d364bdd0b9d935dbeede8f5708b744 Mon Sep 17 00:00:00 2001
From: Aaron Jensen <aaronjensen@gmail.com>
Date: Sun, 18 Feb 2018 11:43:47 -0800
Subject: [PATCH] Require a larger stack size for threads (bug#30364)

* src/systhread.c (sys_thread_create): Require at least 8MB stack size
  for x64 and 4MB for x86.
---
 src/systhread.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/src/systhread.c b/src/systhread.c
index 4ffb7db143..b2fa45fae9 100644
--- a/src/systhread.c
+++ b/src/systhread.c
@@ -94,6 +94,12 @@ sys_thread_yield (void)
 #include <sys/prctl.h>
 #endif
 
+#ifdef __x86_64__
+#define REQUIRED_STACK_SIZE 8*1024*1024
+#else
+#define REQUIRED_STACK_SIZE 4*1024*1024
+#endif
+
 void
 sys_mutex_init (sys_mutex_t *mutex)
 {
@@ -161,10 +167,19 @@ sys_thread_create (sys_thread_t *thread_ptr, const char *name,
 {
   pthread_attr_t attr;
   int result = 0;
+  size_t stackSize = 0;
 
   if (pthread_attr_init (&attr))
     return 0;
 
+  if (pthread_attr_getstacksize (&attr, &stackSize))
+    return 0;
+
+  if (stackSize < REQUIRED_STACK_SIZE) {
+    if (pthread_attr_setstacksize (&attr, REQUIRED_STACK_SIZE))
+      return 0;
+  }
+
   if (!pthread_attr_setdetachstate (&attr, PTHREAD_CREATE_DETACHED))
     {
       result = pthread_create (thread_ptr, &attr, func, arg) == 0;
-- 
2.15.1