From: Aaron Jensen <aaronjensen@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: Eli Zaretskii <eliz@gnu.org>, 56102@debbugs.gnu.org
Subject: bug#56102: 29.0.50; fit-frame-to-buffer's window-text-pixel-size calculation can be incorrect when only is set to vertically
Date: Thu, 23 Jun 2022 22:28:56 -0400 [thread overview]
Message-ID: <CAHyO48wccMewa6Am42mpJ+0q=wBkoGC_hSG+JOnk33n+qG3keA@mail.gmail.com> (raw)
In-Reply-To: <0807c810-af05-f92c-17ce-991056906629@gmx.at>
On Thu, Jun 23, 2022 at 3:30 AM martin rudalics <rudalics@gmx.at> wrote:
>
> >>> The problem appears to be the lines:
> >>>
> >>> (size
> >>> (window-text-pixel-size window from to max-width max-height))
> >>>
> >>> As the max-width will be larger than the current frame (meaning the
> >>> height calculation will not take wrapping into account).
>
> I think MAX-WIDTH should be nil here.
Ah, I had no idea X-LIMIT could be nil, that's great.
> Please try the attached diff.
That seems to work for me. I do wonder though if the the check for
`only' should be first (i.e. if only is vertically, max-width is nil).
Is there a reason that we should not ignore a specified max-width when
only is set to vertically? I ask because in the package that I had
this issue with I employed a work-around where I set the max-width to
(frame-parameter frame 'width), which seems to work well enough, but
probably not as good as your fix. We may not be able to remove that
workaround for some time, so ignoring max-width if set would probably
work better in our specific case.
Thanks,
Aaron
next prev parent reply other threads:[~2022-06-24 2:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 3:03 bug#56102: 29.0.50; fit-frame-to-buffer's window-text-pixel-size calculation can be incorrect when only is set to vertically Aaron Jensen
2022-06-22 13:58 ` Eli Zaretskii
2022-06-22 14:15 ` Aaron Jensen
2022-06-23 7:30 ` martin rudalics
2022-06-24 2:28 ` Aaron Jensen [this message]
2022-06-24 9:20 ` martin rudalics
2022-06-24 14:28 ` Aaron Jensen
2022-06-26 10:09 ` martin rudalics
2022-06-26 13:12 ` Aaron Jensen
2022-06-27 8:24 ` martin rudalics
2022-06-27 13:24 ` Aaron Jensen
2022-06-28 9:29 ` martin rudalics
2022-06-28 14:52 ` Aaron Jensen
2022-07-05 13:07 ` Aaron Jensen
2022-07-06 7:37 ` martin rudalics
2022-07-06 13:17 ` Aaron Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHyO48wccMewa6Am42mpJ+0q=wBkoGC_hSG+JOnk33n+qG3keA@mail.gmail.com' \
--to=aaronjensen@gmail.com \
--cc=56102@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.