From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.devel Subject: Remove icomplete workaround Date: Sun, 31 Oct 2021 20:49:23 -0400 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000f3742905cfaf8c5b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5642"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@daniel-mendler.de, joaotavora@gmail.com, kevin.legouguec@gmail.com To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 01 01:50:18 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhLWk-0001GX-R7 for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Nov 2021 01:50:18 +0100 Original-Received: from localhost ([::1]:44214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhLWj-0004dG-1I for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Oct 2021 20:50:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhLW6-0003xp-G3 for emacs-devel@gnu.org; Sun, 31 Oct 2021 20:49:38 -0400 Original-Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:38884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhLW4-0005lq-FW for emacs-devel@gnu.org; Sun, 31 Oct 2021 20:49:38 -0400 Original-Received: by mail-pg1-x533.google.com with SMTP id e65so15734520pgc.5 for ; Sun, 31 Oct 2021 17:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to:cc; bh=ntdS0WzIhWanv9244oXFusu3F+8Jvcy49SQ2uzaRdVM=; b=kh0KEB/G/ZGJfhk5kf6aaZ7B1o6G90DpCcF3PjkuVKQC6HjZ2OBq/35lFbCZAfY0+1 e3NySmM0HOINefMY/YNXGRCAUyk+8CcGWYEA75KUQ+nzBOkaDZCNrLCwZic3ZPn+TEmI fIPQ1pxuXPzDb3t0Kj6pWCdOz9LgzhW9nrNNeR3gO8InDHzS3Q68ZO+P1cRbJZ1edl3Z zBprdSAr/P4cPOcHwGaI9tlie6EovFjOP7pe3UoRrgvoqejPNXeQ2YNso1YhF/rlAmZ2 bYA6Vjr1EbmozdYTen7+iAwsJxsIjOllYhoa3ZKRhXu2SiM9/YT25DM8IPyr+3xY40xq bPNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=ntdS0WzIhWanv9244oXFusu3F+8Jvcy49SQ2uzaRdVM=; b=o4TDpg2OTZB8/MJr6a3vtVDSWV44L4SVXAjS6E+tznrWxFy1lemXlW7F1LoTKMHFC1 8KfNFfGVDx+KCTo3A7XTngFZlT+IhSvpjEt2PhopRu2XgE6pk3qJVdvxXRhaI/Gy3AFm KqUUMWZe2nQ6RSxnuSnrR4LVi8KnpgoIhfb1DnHx4rFTMRMbP+puvzhgBIycduXpQyol nhBCNJRRkWDXwtNttWOnuC1HJiLJ9+1b4/Czf2eJ+8pV2gl45Y7jtbUMYHVBlPFiFdLy zFFEUPju+DcBAbVleME8vgg8DewBcZi2+b3M6Lt9CTnjNCVfVDbzRFKQ4FGe4XgAWGsZ ZVwQ== X-Gm-Message-State: AOAM531YWWr/ewSPO8Em4F5k2vLYYXKrmzvUUvwZl74Y0olkGw/xrX4E mUCYjGdpAZP11eSJNnvUBjZE2un82dwOwCUtiXCnDIKtF01rDQ== X-Google-Smtp-Source: ABdhPJxUokrejOjx48Dl2hSmJjrI+wuhWEnDHedyNfxKYU1PPNFLDn0G6D3vvvCQ1qL2B1ZiKfoJ6du70GHfdibZiyo= X-Received: by 2002:a63:f644:: with SMTP id u4mr9491005pgj.300.1635727774538; Sun, 31 Oct 2021 17:49:34 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=aaronjensen@gmail.com; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:278351 Archived-At: --000000000000f3742905cfaf8c5b Content-Type: text/plain; charset="UTF-8" Originally added because of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38024 The reason this fixed things was not captured and I can not reproduce the bug with the fix disabled on master. This workaround has been copied to other libraries without clear understanding of why it existed in the first place and it caused a problem: https://github.com/minad/vertico/issues/115#issuecomment-947330581 Would it be possible to remove it? I'm ccing the original reporter and fixer in case they are able to shed more light on this or test without the fix to see if they can reproduce it. I've attached a patch if we are good to remove it. Thanks, Aaron --000000000000f3742905cfaf8c5b Content-Type: application/octet-stream; name="0001-lisp-icomplete.el-icomplete-exhibit-Remove-workaroun.patch" Content-Disposition: attachment; filename="0001-lisp-icomplete.el-icomplete-exhibit-Remove-workaroun.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kvfxtgc40 RnJvbSA5NzdlNDA1NTZlOWI0MTZlODdkOWRhOTBiOGI1YTQ0MDY4ZGVhMzc4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYXJvbiBKZW5zZW4gPGFhcm9uamVuc2VuQGdtYWlsLmNvbT4K RGF0ZTogU3VuLCAzMSBPY3QgMjAyMSAyMDo0MDo0MyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdICog bGlzcC9pY29tcGxldGUuZWwgKGljb21wbGV0ZS1leGhpYml0KTogUmVtb3ZlIHdvcmthcm91bmQK Ci0tLQogbGlzcC9pY29tcGxldGUuZWwgfCA1IC0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNSBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2ljb21wbGV0ZS5lbCBiL2xpc3AvaWNvbXBsZXRl LmVsCmluZGV4IDAxMDMzNDc0ZDMuLmE2MWM5ZDYzNTQgMTAwNjQ0Ci0tLSBhL2xpc3AvaWNvbXBs ZXRlLmVsCisrKyBiL2xpc3AvaWNvbXBsZXRlLmVsCkBAIC03MTYsMTEgKzcxNiw2IEBAIGljb21w bGV0ZS1leGhpYml0CiAgICAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAob3ZlcmxheS1zdGFydCBy Zm4tZXNoYWRvdy1vdmVybGF5KQogICAgICAgICAgICAgICAgICAgICAgICAgICAgKG92ZXJsYXkt ZW5kIHJmbi1lc2hhZG93LW92ZXJsYXkpKSkKICAgICAgICAgICAobGV0KiAoKGZpZWxkLXN0cmlu ZyAoaWNvbXBsZXRlLS1maWVsZC1zdHJpbmcpKQotICAgICAgICAgICAgICAgICA7OyBOb3Qgc3Vy ZSB3aHksIGJ1dCBzdWNoIHJlcXVlc3RzIHNlZW0gdG8gY29tZQotICAgICAgICAgICAgICAgICA7 OyBldmVyeSBvbmNlIGluIGEgd2hpbGUuICBJdCdzIG5vdCBmdWxseQotICAgICAgICAgICAgICAg ICA7OyBkZXRlcm1pbmlzdGljIGJ1dCBgQy14IEMtZiBNLURFTCBNLURFTCAuLi4nCi0gICAgICAg ICAgICAgICAgIDs7IHNlZW1zIHRvIHRyaWdnZXIgaXQgZmFpcmx5IG9mdGVuIQotICAgICAgICAg ICAgICAgICAod2hpbGUtbm8taW5wdXQtaWdub3JlLWV2ZW50cyAnKHNlbGVjdGlvbi1yZXF1ZXN0 KSkKICAgICAgICAgICAgICAgICAgKHRleHQgKHdoaWxlLW5vLWlucHV0CiAgICAgICAgICAgICAg ICAgICAgICAgICAgKGljb21wbGV0ZS1jb21wbGV0aW9ucwogICAgICAgICAgICAgICAgICAgICAg ICAgICBmaWVsZC1zdHJpbmcKLS0gCjIuMzMuMQoK --000000000000f3742905cfaf8c5b--