From: Aaron Jensen <aaronjensen@gmail.com>
To: emacs-devel@gnu.org
Cc: mail@daniel-mendler.de, joaotavora@gmail.com, kevin.legouguec@gmail.com
Subject: Remove icomplete workaround
Date: Sun, 31 Oct 2021 20:49:23 -0400 [thread overview]
Message-ID: <CAHyO48wYzmHL0FEc9e3peZXzHdxOSwoF4da3Qvjd2XyWvPqoMg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
Originally added because of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38024
The reason this fixed things was not captured and I can not reproduce
the bug with the fix disabled on master.
This workaround has been copied to other libraries without clear
understanding of why it existed in the first place and it caused a
problem: https://github.com/minad/vertico/issues/115#issuecomment-947330581
Would it be possible to remove it? I'm ccing the original reporter and
fixer in case they are able to shed more light on this or test without
the fix to see if they can reproduce it.
I've attached a patch if we are good to remove it.
Thanks,
Aaron
[-- Attachment #2: 0001-lisp-icomplete.el-icomplete-exhibit-Remove-workaroun.patch --]
[-- Type: application/octet-stream, Size: 1113 bytes --]
From 977e40556e9b416e87d9da90b8b5a44068dea378 Mon Sep 17 00:00:00 2001
From: Aaron Jensen <aaronjensen@gmail.com>
Date: Sun, 31 Oct 2021 20:40:43 -0400
Subject: [PATCH] * lisp/icomplete.el (icomplete-exhibit): Remove workaround
---
lisp/icomplete.el | 5 -----
1 file changed, 5 deletions(-)
diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index 01033474d3..a61c9d6354 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -716,11 +716,6 @@ icomplete-exhibit
(delete-region (overlay-start rfn-eshadow-overlay)
(overlay-end rfn-eshadow-overlay)))
(let* ((field-string (icomplete--field-string))
- ;; Not sure why, but such requests seem to come
- ;; every once in a while. It's not fully
- ;; deterministic but `C-x C-f M-DEL M-DEL ...'
- ;; seems to trigger it fairly often!
- (while-no-input-ignore-events '(selection-request))
(text (while-no-input
(icomplete-completions
field-string
--
2.33.1
next reply other threads:[~2021-11-01 0:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 0:49 Aaron Jensen [this message]
2021-11-01 1:40 ` Remove icomplete workaround Stefan Kangas
2021-11-01 2:38 ` bug#38024: " Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-01 3:55 ` Aaron Jensen
2021-11-01 9:28 ` Kévin Le Gouguec
2021-11-01 15:33 ` Aaron Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHyO48wYzmHL0FEc9e3peZXzHdxOSwoF4da3Qvjd2XyWvPqoMg@mail.gmail.com \
--to=aaronjensen@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=kevin.legouguec@gmail.com \
--cc=mail@daniel-mendler.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.