From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#28483: [PATCH] Fix copy-directory creating missing directory Date: Sun, 17 Sep 2017 13:19:55 -0700 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1505679677 12664 195.159.176.226 (17 Sep 2017 20:21:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 17 Sep 2017 20:21:17 +0000 (UTC) To: 28483@debbugs.gnu.org, Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 17 22:21:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtg3v-0002wK-VY for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Sep 2017 22:21:08 +0200 Original-Received: from localhost ([::1]:33582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtg43-0008DS-CV for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Sep 2017 16:21:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtg3u-0008D6-N7 for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 16:21:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtg3q-0007JF-U9 for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 16:21:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36646) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dtg3q-0007J7-Pa for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 16:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dtg3q-0000QE-H4 for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 16:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Sep 2017 20:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28483 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28483-submit@debbugs.gnu.org id=B28483.15056796091541 (code B ref 28483); Sun, 17 Sep 2017 20:21:02 +0000 Original-Received: (at 28483) by debbugs.gnu.org; 17 Sep 2017 20:20:09 +0000 Original-Received: from localhost ([127.0.0.1]:45327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtg2x-0000Ol-Ft for submit@debbugs.gnu.org; Sun, 17 Sep 2017 16:20:08 -0400 Original-Received: from mail-qk0-f178.google.com ([209.85.220.178]:45266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtg2s-0000OA-MB for 28483@debbugs.gnu.org; Sun, 17 Sep 2017 16:20:06 -0400 Original-Received: by mail-qk0-f178.google.com with SMTP id r141so5741454qke.2 for <28483@debbugs.gnu.org>; Sun, 17 Sep 2017 13:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=IKSQtFs+HdJoLugtTGxLih5SinWTxmi9ouUzgTNpbcE=; b=vW5BIJZrkNPXilrHj0TaIdvD+/Un8/gGQUrCWidG7nWebSENDQwW0TRcXciEsgMdSY t4Gwp/2cVrSounoUBo0G2Fd9YitvVIDxFORS4sKmdeXgryPpR9x0b8OM85ISnXPaSPaj itTfu5AdllHHElF1iXdNQaPC0/l1UNsdC2ToLEnRcF5YJqyC8mADmB9SuQLOAYtkClVv +jsdObUTnOyb59mVBA4cqxb3ieHWwFv1TTlGZSF8g6q9qxv9zYezwrq6WLmV9QuwGQ29 JggFSSJCJ+uygyPQ+LkWZhx79PQ8iujasqv7Qo2XAPWSeIP69ap23iytdSPCntMXKZrA lwKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=IKSQtFs+HdJoLugtTGxLih5SinWTxmi9ouUzgTNpbcE=; b=H4/FksCNI3aChXOJLx8KcEnaDzioiEwZd3vYoeYn7Ib6lzAIre7NBzclb5UpvUzM0J 0zb2yU48EM4a94IGTswB4NPoo5q1/Q33RRLdnqQ7I9Ssg/TK7lamLUrjW2+FthPNr1SW SMWW4E8xwRrEwLt02qXBzCAIQkv4+E+54H4O9tKaKhPBymFo8R/P4L2fmFDmNDzrfdAI rm0X71558hVcVHD7DqaNDw6h/8kKuuIJVG5tPHsLkSRVoyiyetswuMunM781rIxv2hRt Bw1sTiqNHVa9o8vjgAJTfibS/AAhv/0vSnh8o5bEiaS68MYVo8wPz+FGUUiA3VkS0SPb rwfw== X-Gm-Message-State: AHPjjUg3lGChv9D/qhss66BB59xmOpL3AiTJieVlpT2dnDzHz95F2Rjw /jR04TlMYRj2KLOVDYvNuUd26XGdDIUwDXx2jbnUJQ== X-Google-Smtp-Source: AOwi7QDF/pYbSrCdj/TlJCBswLQ1lQ+FfAypIT9W7grs1BpOMJmS1edTXt7MNkNXwEko+lUxYJgKbYBvu310nq1et7w= X-Received: by 10.55.21.210 with SMTP id 79mr2067297qkv.56.1505679596918; Sun, 17 Sep 2017 13:19:56 -0700 (PDT) Original-Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Sun, 17 Sep 2017 13:19:55 -0700 In-Reply-To: X-Mailer: Airmail (442) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137037 Archived-At: On September 17, 2017 at 12:48:54 PM, Philipp Stephani (p.stephani2@gmail.com(mailto:p.stephani2@gmail.com)) wrote: > This would reintroduce the security hole that e22794867d878d53675fcc91d2e= f1ad2494a2ff2 fixed. Indeed, sorry about that. I=E2=80=99m attempting to patch the downstream library that led me to this issue: https://github.com/syl20bnr/spacemacs/pull/9600 > Paul, maybe you want to add some comments to the places where you introdu= ced `directory-name-p' so that people don't attempt to revert these changes= ? I=E2=80=99m not sure what Emac=E2=80=99s principles are on it, but perhaps = an error pointing to this change when attempting to copy to a non-existing directory would help people in the future as well since this is a change in behavior to an existing function w/o a deprecation. Thanks, Aaron