From: Aaron Jensen <aaronjensen@gmail.com>
To: Alan Third <alan@idiocy.org>,
Andrii Kolomoiets <andreyk.mad@gmail.com>,
46155@debbugs.gnu.org, Aaron Jensen <aaronjensen@gmail.com>
Subject: bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when
Date: Tue, 9 Feb 2021 19:11:58 -0600 [thread overview]
Message-ID: <CAHyO48wSPYGAYX7LWR=AG_1ajh=h2YS368UtbS2MaYmXy1VJdw@mail.gmail.com> (raw)
In-Reply-To: <YCLroohe9Bqv5Bxj@breton.holly.idiocy.org>
On Tue, Feb 9, 2021 at 2:08 PM Alan Third <alan@idiocy.org> wrote:
>
> On Tue, Feb 09, 2021 at 06:29:22PM +0200, Andrii Kolomoiets wrote:
> > Alan Third <alan@idiocy.org> writes:
> >
> > > On Tue, Feb 09, 2021 at 11:05:08AM +0000, Alan Third wrote:
> > >>
> > >> The patch Aaron and Andrii are using calls redisplay() just before the
> > >> frame is drawn, but only if it is garbaged.
> > >
> > > I see from a subsequent email that Andrii isn't using the NS port, so
> > > that bit of my message is wrong.
> >
> > Sorry for kind of misleading you. I indeed use NS port. The receipt for
> > minibuffer-only frame flickering was made on nearly recent master
> > version with your patch applied. (I must say resizing and fullscreen
> > transition looks awesome now, thanks!)
> >
> > I used GTK port under X in the VirtualBox to test the issue with the
> > minibuffer-only frame resized more than once even if the text is not
> > changed.
>
> Ah, OK. I guess it probably is exclusive to NS then.
>
> The obvious solution IMO is to retain a copy of the old frame contents
> and draw them in after resizing, before we try calling redisplay().
>
> On the other hand, it would be nice to know why redisplay() isn't
> drawing anything...
inhibit-redisplay appears to be t when miniframes are asked to resize.
Could that be related? I tried letting it to nil and that didn't help.
It also happens that setting the resize to happen via run-with-timer
fixes the flicker:
https://github.com/muffinmad/emacs-mini-frame/pull/32/files#diff-8289c4c5300044ca6d7f9f6f60067a1b5e0d61b6ad0b58720a7c694662ea13abR207
Unfortunately, that prevents resizing when displaying a prompt like
`yes-or-no-p`.
The other different thing about the minibuffer resizing is it all
happens within `read-from-minibuffer`
next prev parent reply other threads:[~2021-02-10 1:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 15:48 bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when Aaron Jensen
2021-01-28 16:39 ` Alan Third
2021-01-31 20:28 ` Alan Third
2021-01-31 22:05 ` Aaron Jensen
2021-02-08 15:25 ` Aaron Jensen
2021-02-08 21:45 ` Aaron Jensen
2021-02-09 7:58 ` martin rudalics
2021-02-09 9:55 ` Andrii Kolomoiets
2021-02-09 10:49 ` martin rudalics
2021-02-09 11:04 ` martin rudalics
2021-02-09 11:30 ` Andrii Kolomoiets
2021-02-09 17:31 ` martin rudalics
2021-02-09 11:05 ` Alan Third
2021-02-09 14:44 ` Alan Third
2021-02-09 16:29 ` Andrii Kolomoiets
2021-02-09 20:08 ` Alan Third
2021-02-10 1:11 ` Aaron Jensen [this message]
2021-02-11 22:16 ` bug#46155: [PATCH v2] Fix flicker when resizing NS frame programmatically (bug#46155) Alan Third
2021-02-12 4:06 ` Aaron Jensen
2021-02-13 22:44 ` Alan Third
2021-02-13 22:45 ` Aaron Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHyO48wSPYGAYX7LWR=AG_1ajh=h2YS368UtbS2MaYmXy1VJdw@mail.gmail.com' \
--to=aaronjensen@gmail.com \
--cc=46155@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=andreyk.mad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.