From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.devel Subject: Re: input-pending-p after make-frame-visible Date: Wed, 20 Oct 2021 13:47:57 -0400 Message-ID: References: <6c69780538e1957d1002@heytings.org> <322f50be-0de1-c818-819d-6ecb400de928@gmx.at> <03ab7a19-6616-445c-cdcf-588fb30a514a@gmx.at> <3205a073-a6ca-b9a5-3834-929025b70b7b@gmx.at> <83wnm7absp.fsf@gnu.org> <83r1cfa92p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23337"; mail-complaints-to="usenet@ciao.gmane.io" Cc: martin rudalics , Alan Third , Gregory Heytings , YAMAMOTO Mitsuharu , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 20 20:03:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdFwQ-0005ka-Iu for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 20:03:59 +0200 Original-Received: from localhost ([::1]:56738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdFwP-0006Hs-JB for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 14:03:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdFhI-0004cM-H6 for emacs-devel@gnu.org; Wed, 20 Oct 2021 13:48:16 -0400 Original-Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:46812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdFhD-0001Yv-Bc; Wed, 20 Oct 2021 13:48:15 -0400 Original-Received: by mail-pf1-x42e.google.com with SMTP id x66so220105pfx.13; Wed, 20 Oct 2021 10:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e8IjsdiesJFCVBqbgWChGIW79NwdRihyJvCMUbtCGws=; b=CGMqs8A7FnBYqzQuHxlU3EfliqMv5Y86B950FZf+9sD7GSyjAws0dmRPrWVkVaFd0w YRZJlmz/e1E7UenvKcL4o0ZwWnT008m2OK/0vVu1/tzV+PZLId/yN5rKVknk3fniAkPa HrOmVlazJhPORXLNHWlJSMBSFoySX4SH72u+azMXvlum5dausGyZyygYWvE/t23NFX/d bxGCZSthih+b0mMPOL7I7zbKhs48fh5nbHmzosCIr1NxVcEpxm/L1blOPHuABp5cFRIA qMdrF5e3YYODl1uqp31mSTH1dCCZJHT3Y/7BedLvdO8kvRWfupc/+wk5Phzj4QWc6pz2 0/TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e8IjsdiesJFCVBqbgWChGIW79NwdRihyJvCMUbtCGws=; b=RThes5ZrP715kskgu2ugizRXd7ZnhV+rRmUkA/x5bQiBktZ4I5EyhJjpnK4caN71uC hnMzo8NS5bgaRVUO89s2zTBNRtsN8l8ceK0vrLU7uIn6bEVu6a6nNFsxv4C+qnZXEpYv 0mKWNurh2TFb/G/FNA/E8e1T1diHt93lZGh6RkF9UIGsjxKq5AIsDYo3c8P8uEaKswHr PY7B8KA+/2NlyYHQtCI8ETfDZylbKsL5QoeW/8s9VnzxnYAGkv1ZVWHaFzVYtlgykS7m XWOXWrrVR3NNNt3uyJcaotJOhpnObqIs0S/MjZfzC4aMJG7k1xYjZxq9i9oqGi7lV0Hj JdXg== X-Gm-Message-State: AOAM533nJHrZZSq24uOKMFjFhKBNjTwec5SmDt8tQ+o7CUCOxDc9uKNK 61uodnd1tBSmhaJ8wA9WPf7sjpp8Ug/el3ioh5KuTDTaaas= X-Google-Smtp-Source: ABdhPJydyHhAwl2xaK7s6yH2znsFNxIP7LVIHfCZVv5AFP/JdPMtpBElb3enU1BMaS8lovi+/kB2e5uIsVCayP53hr8= X-Received: by 2002:aa7:8246:0:b0:44b:4870:1b09 with SMTP id e6-20020aa78246000000b0044b48701b09mr209870pfn.82.1634752089094; Wed, 20 Oct 2021 10:48:09 -0700 (PDT) In-Reply-To: <83r1cfa92p.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=aaronjensen@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277460 Archived-At: On Wed, Oct 20, 2021 at 1:40 PM Eli Zaretskii wrote: > > > From: Aaron Jensen > > Date: Wed, 20 Oct 2021 13:15:21 -0400 > > Cc: martin rudalics , Alan Third , > > Gregory Heytings , emacs-devel@gnu.org, > > YAMAMOTO Mitsuharu > > > > On Wed, Oct 20, 2021 at 12:41 PM Eli Zaretskii wrote: > > > > > > > Any concerns with installing the attached? > > > > > > Yes: I don't think we understand what it will do, apart of fixing this > > > particular problem for you. > > > > The primary thing that it does is make input-pending-p respect > > while-no-input-ignore-events, which is necessary to make > > while-no-input fully respect while-no-input-ignore-events because it > > uses input-pending-p. > > Yes. But the change you propose is in readable_events, a function > that has many more callers than just input-pending-p. In particular, > one of its callers is kbd_buffer_get_event, which is the API through > which Emacs reads all of its input. And now, under some > circumstances, that API will ignore some events. That's scary, at > least for me. AFAICT kbd_buffer_get_event calls `readable_events (0)' only, which will disregard any of the code I changed or added. The READABLE_EVENTS_FILTER_EVENTS must be set for it to come into play. Only input-pending-p sets that flag AFAICT. > > > I _might_ be okay with installing this on master, conditioned on some > > > new variable, so that if some problem reveals itself, it would be easy > > > to see if it's due to this change. > > > > Okay, let's see if we get any more clarity first and then I can > > introduce a variable. What would you like to call it? And are you > > referring to a new ifdef check? > > No, that must be a variable exposed to Lisp, so users could fiddle > with it without rebuilding. Ah, I believe that variable exists already and can affect everything I changed other than the reliance on USE_TOOLKIT_SCROLL_BARS: while-no-input-ignore-events Aaron