From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#31546: 27.0.50; macOS child frames with no mode-line mouse click problem Date: Sun, 27 May 2018 14:53:28 -0700 Message-ID: References: <20180526163844.GA16324@breton.holly.idiocy.org> <20180526182215.GA18042@breton.holly.idiocy.org> <5B0A4EC3.6080403@gmx.at> <83h8mt851r.fsf@gnu.org> <8336yd80cy.fsf@gnu.org> <20180527212429.GA19272@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1527457927 14814 195.159.176.226 (27 May 2018 21:52:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 27 May 2018 21:52:07 +0000 (UTC) Cc: 31546@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 27 23:52:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fN3a7-0003ir-2h for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 May 2018 23:52:03 +0200 Original-Received: from localhost ([::1]:53374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fN3cC-0002ke-I6 for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 May 2018 17:54:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fN3c5-0002kN-KX for bug-gnu-emacs@gnu.org; Sun, 27 May 2018 17:54:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fN3c2-00024v-JM for bug-gnu-emacs@gnu.org; Sun, 27 May 2018 17:54:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43427) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fN3c2-00024O-Ej for bug-gnu-emacs@gnu.org; Sun, 27 May 2018 17:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fN3c1-0006g4-Ul for bug-gnu-emacs@gnu.org; Sun, 27 May 2018 17:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 May 2018 21:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31546 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31546-submit@debbugs.gnu.org id=B31546.152745802625646 (code B ref 31546); Sun, 27 May 2018 21:54:01 +0000 Original-Received: (at 31546) by debbugs.gnu.org; 27 May 2018 21:53:46 +0000 Original-Received: from localhost ([127.0.0.1]:51324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fN3bm-0006fa-4S for submit@debbugs.gnu.org; Sun, 27 May 2018 17:53:46 -0400 Original-Received: from mail-qk0-f194.google.com ([209.85.220.194]:33432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fN3bl-0006fM-BP for 31546@debbugs.gnu.org; Sun, 27 May 2018 17:53:45 -0400 Original-Received: by mail-qk0-f194.google.com with SMTP id h7-v6so767364qkm.0 for <31546@debbugs.gnu.org>; Sun, 27 May 2018 14:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k7onIoqiw2u++jBlmF1X8T6diMuQZ5/+ai+efo6eIxw=; b=q+7C1OhE8gcfGcep76H7RpiagCLG+19DxjhuN4gllGZvghjz2nWWw4mKTOSrzHsuM+ RjDzAOb9mT8WQQhLmfVeXJZdVGGoEKf1v5Deh/WFCmoVCne298ItkNeOTbrblsx/euHy zoLCVBIENuh0A656x1Re4/ciImJx/h62KyoSkz+ShqgaJfsHJqYdmW/eEYZPLe1DFn0x miv8C+Jbtq57O7z6JFilQg7ZkKtneWtBFiQhp/tFXVt3m/DkIbctBn8dlIZcak0rgKcK U+KIEuAbUPnAvwYYoSHud6z6hpjKSB4sMTxB/nhIMstZ09iBsOu0a5wr1NnZTwysCEpB dR8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k7onIoqiw2u++jBlmF1X8T6diMuQZ5/+ai+efo6eIxw=; b=ApWNavbdffWZbuEeR6314jvXXqDMai3CKEuKrrfib1SkWf3q4Cbshi5pkrD7aeuEh9 XBXiI/N2MOc9JjGfcEjwkdyL6JbtzqTbGqjajK3DOiQFPIccaBLCf4IydYZY87JgMTzn tWTHULLgXADYzH3guUa18Dg6acfzbX0I0nT9eb5V1b9yW4Wo6LCK1HCBDne4FrYvdypY Xsr1I4MGh3SBeleYx1um4vQ+ZzQfg59C8f+hVrxEGX+oqojHHQV+G6KjZuT0Vxm73ZwI W9EhTfd7Q8Sm23jMA+97J187isoSY5l9PFKvFZSSfsorksprzea3WEUsesjMkvSHoxt0 7PFQ== X-Gm-Message-State: ALKqPwcsntFu/Ggl5HJwvQN0IQJx2oqXhTKrjHcfJ85eM4KoVPRoblya jLQYnyk9Io0N9dRWxQrkGAQjas2KF2ldjgY6ANA= X-Google-Smtp-Source: ADUXVKL/j4VkEqp2FiYfMNt6IIhatu9OjWh47V/Dsri2ZFctorSy4+qDLnxXKbE29rnSWNPteeE4Oq1JtM7OYFaa3C8= X-Received: by 2002:a37:8542:: with SMTP id h63-v6mr9169180qkd.342.1527458019817; Sun, 27 May 2018 14:53:39 -0700 (PDT) In-Reply-To: <20180527212429.GA19272@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146616 Archived-At: On Sun, May 27, 2018 at 2:24 PM Alan Third wrote: > *sigh* try this: > modified src/nsterm.m > @@ -2547,7 +2547,7 @@ so some key presses (TAB) are swallowed by the system. */ > if (f && FRAME_NS_P (f)) > { > - view = FRAME_NS_VIEW (*fp); > + view = FRAME_NS_VIEW (f); > position = [[view window] mouseLocationOutsideOfEventStream]; > position = [view convertPoint: position fromView: nil]; AFAICT, that fixes it even w/o my patch. Thanks! There's still some weirdness w/ company-childframe, but I believe it's fixable in that package. That said, I think my patch is still necessary to prevent a related, but not very critical issue. Using my original repro but with no-accept-focus nil: (progn (let ((buffer (get-buffer " *foo*"))) (when (buffer-live-p buffer) (kill-buffer buffer))) (let ((buffer (get-buffer-create " *foo*")) (after-make-frame-functions nil)) (with-current-buffer buffer (goto-char (point-min)) (insert "1 This is a test\n2 This is a test\n3 This is a test") (delete-region (point) (point-max)) (setq-local resize-mini-windows nil) (setq-local mode-line-format nil) (setq-local repro-frame (make-frame `( (minibuffer . nil) ) )) (let ((win (frame-root-window repro-frame))) (set-window-parameter win 'mode-line-format nil) (set-window-buffer win buffer))))) Click in the middle of the window and slowly move the mouse towards the bottom of the window. As soon as you leave the bottom of the window, it will scroll two lines, I believe because it has miscalculated the bottom. If you apply my patch, it will only scroll one line at a time, which seems to be the normal behavior when the mode-line is present. I would guess this is reproducible in X as well.