bug#59790: 30.0.50; ns-use-native-fullscreen is not respected for first use of initial-frame-alist

[Aaron Jensen <aaronjensen@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 763 bytes --]

​The bugged behavior is that `ns-use-native-fullscreen' set to nil is not read
when launching emacs.


The attached patch should fix this. The problem is that when the frame is
made, the current value of ns-use-native-fullscreen is copied to a variable
and that's only reset when the frame goes from fullscreen to windowed. I
believe the original intent was to ensure that the mode could not change
while the window was fullscreen already.

This resets the value of fs_is_native if the frame is not already
fullscreen, which allows it to respect the value at the time of the first
fullscreen.

Without this, the only way to get the behavior that Sean is expecting is to
set ns-use-native-fullscreen in early-init, which should not be necessary.

[-- Attachment #1.2: Type: text/html, Size: 1501 bytes --]

[-- Attachment #2: 0001-src-nsterm.m-EmacsView-toggleFullScreen-Reset-fs_is_.patch --]
[-- Type: application/octet-stream, Size: 818 bytes --]

From 8e6138ea26f996895d2e60dad7ec112e916736a9 Mon Sep 17 00:00:00 2001
From: Aaron Jensen <aaronjensen@gmail.com>
Date: Sat, 16 Nov 2024 20:54:59 -0800
Subject: [PATCH] * src/nsterm.m ([EmacsView toggleFullScreen:]): Reset
 fs_is_native

---
 src/nsterm.m | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/nsterm.m b/src/nsterm.m
index dabc36ce018..d2650843548 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -8524,6 +8524,11 @@ - (void)toggleFullScreen: (id)sender
 
   NSTRACE ("[EmacsView toggleFullScreen:]");
 
+  /* Reset fs_is_native to value of ns-use-native-full-screen if not
+     fullscreen already */
+  if (fs_state != FULLSCREEN_BOTH)
+    fs_is_native = ns_use_native_fullscreen;
+
   if (fs_is_native)
     {
 #if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 1070
-- 
2.47.0