From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression Date: Mon, 19 Apr 2021 09:02:24 -0500 Message-ID: References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26563"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47860@debbugs.gnu.org, Gregory Heytings To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 19 16:04:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYUVq-0006lZ-7K for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Apr 2021 16:04:30 +0200 Original-Received: from localhost ([::1]:43640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYUVp-0000Hr-9m for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Apr 2021 10:04:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYUVP-0000HK-U0 for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 10:04:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYUVO-0000zC-Ny for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 10:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYUVO-0007Kv-KS for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 10:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Apr 2021 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47860 X-GNU-PR-Package: emacs Original-Received: via spool by 47860-submit@debbugs.gnu.org id=B47860.161884098828106 (code B ref 47860); Mon, 19 Apr 2021 14:04:02 +0000 Original-Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 14:03:08 +0000 Original-Received: from localhost ([127.0.0.1]:51437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYUUV-0007JG-SD for submit@debbugs.gnu.org; Mon, 19 Apr 2021 10:03:08 -0400 Original-Received: from mail-pj1-f46.google.com ([209.85.216.46]:52108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYUUT-0007Ih-JP for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 10:03:06 -0400 Original-Received: by mail-pj1-f46.google.com with SMTP id lt13so9150614pjb.1 for <47860@debbugs.gnu.org>; Mon, 19 Apr 2021 07:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RRuXrDM4oi3ekjquqD5qk/XxYU9IX6Mx8UeQ9CMh02Q=; b=NoPLacjZz5/qrLSgnFBC7mVfbgtAF+/cF8nDd9j9MSzsMJUPOAOWTvI3CTfc4wf9IL 97Yq1nwD0rpZZCa8B5/CmWwPEJMHuZYvZa0beSSUtF93ubymVo070KckPQcJ58SuZGNp rX16fKvhS4uT1rKkCEIw0q1mtEpLMZVisXyoRUlduQyXnrxl1fkItXXAOmQb/G/ony0u esvWzxWQN2sG6lCpvP3FsU2FZqinnx4voZPh5waJOxDKBYJ2gACfuKInYOiCNvJHfRZz 3d8kf1jWwYkd06flyjah0vjN8a0ql0vc+MhRJQFD4fOtO79feDUKefBd828xHwiC2w8X ARRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RRuXrDM4oi3ekjquqD5qk/XxYU9IX6Mx8UeQ9CMh02Q=; b=DqGVOvVvxwT5H0uQ58GqrC243ePBygjU0EwN2G0dvczvj8+HwhxWdN/gxLoVDACST6 9N7L/edQvhcLhsDcR51qiVgwC4aY65ymPeQQGNVOpRTDpcDm7WsBzZkpHsN1gmLftyyh bsz6a57ffJ3wb7cty8uqpXSkLaVbiGg/ebAbFvHPwUey8dbgiPke/vR8j5wOK6lO/DnL 1EyXsGAQD6o49OeN9wZRkiHNbOcBH4LTROg1lSouZ7IAf/mWREP26Qw+imF1P8UoatN9 G7vJrv3QDRecEs6T/qnKDpayrWolE0r7VMY9Tl+ZB3yL48gepN4za/vnIhWKfhZUMe1o TaBw== X-Gm-Message-State: AOAM532bzZdM8xGWXSvpO+TcmmWrmJYYEC8v6f/c09oerbspXctqHTJE IpqezbtTR+moB0BeFAEGwUaUgVKytj7HdN5YzLEn8Hb7l9crZw== X-Google-Smtp-Source: ABdhPJxWBCU9fyu5vc4GTgR8i93WEntyXiAzu79gNAlXBM1EIZ+Wlz+jiBG3/4lDhYfmo8f39/xpX0ObSVxr/ju0NOw= X-Received: by 2002:a17:902:e886:b029:e7:386b:1b30 with SMTP id w6-20020a170902e886b02900e7386b1b30mr23372141plg.42.1618840979503; Mon, 19 Apr 2021 07:02:59 -0700 (PDT) In-Reply-To: <83wnsys9ml.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204456 Archived-At: On Mon, Apr 19, 2021 at 8:10 AM Eli Zaretskii wrote: > > > Date: Mon, 19 Apr 2021 12:40:12 +0000 > > From: Gregory Heytings > > cc: Eli Zaretskii , 47860@debbugs.gnu.org > > > > Thanks. But what do you expect this code to do? I tested it, and for > > Emacs 24 to 27 you see only "a" in the minibuffer. After commit > > 56c42bd28d, you see two lines, "a" and "bbb...". > > Exactly the questions to which I would like to know the answers, > thanks. > > IOW, given that the current code does "somewhat" better than > everything we had before, what exactly is the problem you (Aaron) see > with the offending commit that you call it "regression"? I have not tested with Emacs 27. I have, however, tested with Emacs 28 with and without the commit I mentioned. With the commit reverted, I see this: https://cln.sh/sNpBcb Without it reverted, I see this: https://cln.sh/RtPEie What I expect is for the minibuffer to be sized as the first example and not the second. I have not tested my repro on Emacs 27, so it's interesting to hear that only the first line is displayed. However, This is what it looks like when using selectrum in Emacs 27: https://user-images.githubusercontent.com/8199224/114367956-3f4a8e00-9b7d-11eb-8307-5372fb48de63.png and Emacs 28: https://user-images.githubusercontent.com/8588/114411541-e1fd0f80-9b71-11eb-8ba3-5bf1437a7806.png In Emacs 28, the minibuffer is not resized to be large enough to see all candidates. It also never scrolls, so it's difficult to pick any candidate that is not visible. I do know that Selectrum does some vertical resizing after adding text to the minibuffer, so that may be what causes Emacs 27 to look right. It may also be that that vertical resizing now fails in Emacs 28 for some reason. I did not need the resizing code to reproduce what appears to be *an* issue, but it could very well not be the exact issue I'm seeing in Selectrum if it is indeed the resizing code that's not working properly. I'll spend a little time adding the resize code in and testing in Emacs 27 to see if that helps narrow down to the exact issue I'm seeing on selectrum. Thanks, Aaron