From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#30553: 26.0.91; underline appears beneath line-spacing rather than beneath text Date: Sun, 25 Feb 2018 14:09:46 -0800 Message-ID: References: <83r2pf78x5.fsf@gnu.org> <83fu5v6kdi.fsf@gnu.org> <83371u6xc2.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a1149a22ccadecb056610a618" X-Trace: blaine.gmane.org 1519596504 21619 195.159.176.226 (25 Feb 2018 22:08:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Feb 2018 22:08:24 +0000 (UTC) Cc: Alp Aker , 30553@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 25 23:08:20 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eq4Sx-00053y-LM for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Feb 2018 23:08:19 +0100 Original-Received: from localhost ([::1]:56015 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eq4Ux-0002YO-Q4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Feb 2018 17:10:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eq4Uh-0002U2-Vm for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2018 17:10:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eq4Uc-0002Fc-Od for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2018 17:10:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52804) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eq4Uc-0002FW-Jo for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2018 17:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eq4Uc-00033O-Dy for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2018 17:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Feb 2018 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30553 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30553-submit@debbugs.gnu.org id=B30553.151959659411717 (code B ref 30553); Sun, 25 Feb 2018 22:10:02 +0000 Original-Received: (at 30553) by debbugs.gnu.org; 25 Feb 2018 22:09:54 +0000 Original-Received: from localhost ([127.0.0.1]:60701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eq4UU-00032u-Dr for submit@debbugs.gnu.org; Sun, 25 Feb 2018 17:09:54 -0500 Original-Received: from mail-qk0-f171.google.com ([209.85.220.171]:35468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eq4US-00032i-Qi for 30553@debbugs.gnu.org; Sun, 25 Feb 2018 17:09:53 -0500 Original-Received: by mail-qk0-f171.google.com with SMTP id s188so16964115qkb.2 for <30553@debbugs.gnu.org>; Sun, 25 Feb 2018 14:09:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UDPQl6vDr3B2rl+9n0GW4mG6PyJXKr2e6+3e/A3QzhM=; b=l+r9NqFojDl9g6ko8V0cj1/iahFVPVKbZmU/vf/RZKDhJq6RafixkZdi2jq3yrF76W L2fakeS69OYPisWMdZuRXxDn6mur5B4XINRrmeKsMJomSvBV2wOAzu6N6eoxS9PJWhn3 wUw8ThFP0P44WllxvPaCs8PklQRer/Kx+/TMs04AlXZgPWxUxG4fEDqi/uCFHtxJ8qrq 8hCkNozvFosL6vwKPwGdSHgRbXoIJcGmXZ/zSIv9u5ZqNcAOkOHu/O/T/tcyt1LlFCbI pwo8OVic2V0gvBevJauCrqlIsUtNx0s7HFhzTumjEyFhgyYidiLbZpqxQmGKPY/idjDf IeMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UDPQl6vDr3B2rl+9n0GW4mG6PyJXKr2e6+3e/A3QzhM=; b=PUTBqlKybpWLJAFqJ3QDWTzVAbEsEJ94YDpnAd1Z1Zn5026dOnp97Dzd32PXf5gy6O y64cQps0kdAvICNFgI4g3aRO4nDsnHXiUxjUHir2bGXZ/RL9oRQ1Ua8TNzv2AVezPyfS 46t+LtgigvdqrnqdmFCdmw34o9u7qcER5MV0JIsHL5Bq76hAjfqUwOsB73P5Ws1ndPpb haaozg+m2+l5QtBvnQBmcmeC5DBdMjAnft8vKiO8PXAAnZWiVmPWB4p44a1BkGtc+Qv2 Z+aIAuPqKh5LrgMeYv2VjwrnzjPulIseD5xsafO+4kJvg18owLGtH/GeMwD3iivv2nci yLZw== X-Gm-Message-State: APf1xPDJukkZ+og6NthCQ/8rfX79LoqyL8w962pCG2GCD4HZL9FrHuqi ehsxJRzrWkKFHs+gwRaJbwAHWJ7CFNSYn3dY0pQ= X-Google-Smtp-Source: AG47ELudXZmvPq87WLOG4OlY3QH/xZNmxtQQD4TNklRSXHGwwO5wPxEqqF1aukpUJixNUkL1L1+T8l5yi+gcwbjKRFM= X-Received: by 10.55.215.205 with SMTP id t74mr13572654qkt.259.1519596587366; Sun, 25 Feb 2018 14:09:47 -0800 (PST) Original-Received: by 10.237.54.65 with HTTP; Sun, 25 Feb 2018 14:09:46 -0800 (PST) In-Reply-To: <83371u6xc2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143661 Archived-At: --001a1149a22ccadecb056610a618 Content-Type: text/plain; charset="UTF-8" On Wed, Feb 21, 2018 at 9:56 AM, Eli Zaretskii wrote: > Feel free to submit patches to introduce this as yet another optional > behavior. We cannot just throw out the current behavior, because it > was with us since Emacs 21. > > Note that this feature has 3 implementations, one each in every GUI > back-end we support. I changed my mind on this after discovering that these variables do not work as buffer local variables. Whatever the current buffer has it set to causes all other visible buffers to draw in that way, which causes underlines to jump around if they're set differently in different buffers. Please see attached patch. I don't have a windows or linux machine to test on, so if someone could do that it would be appreciated. There are some subtle differences in the original code which I tried to respect. I'm open to any advice on the naming/doc strings or implementation. Thanks! Aaron --001a1149a22ccadecb056610a618 Content-Type: application/octet-stream; name="0001-Add-x-underline-below-font-descent.patch" Content-Disposition: attachment; filename="0001-Add-x-underline-below-font-descent.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_je3ck67o0 RnJvbSA5Mzg5MjY2MGZmYjNkMGVlODBkYmYxZmMxOTc2YTQyOWUxZjNmMTA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYXJvbiBKZW5zZW4gPGFhcm9uamVuc2VuQGdtYWlsLmNvbT4K RGF0ZTogU3VuLCAyNSBGZWIgMjAxOCAxNDowNjo0OSAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFk ZCB4LXVuZGVybGluZS1iZWxvdy1mb250LWRlc2NlbnQKCi0tLQogc3JjL25zdGVybS5tICB8ICA3 ICsrKysrKysKIHNyYy93MzJ0ZXJtLmMgfCAgOSArKysrKysrKy0KIHNyYy94dGVybS5jICAgfCAx NSArKysrKysrKysrKysrLS0KIDMgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvbnN0ZXJtLm0gYi9zcmMvbnN0ZXJtLm0KaW5k ZXggMTkxOWM2ZGVmYS4uYmQyZDg4N2JhMSAxMDA2NDQKLS0tIGEvc3JjL25zdGVybS5tCisrKyBi L3NyYy9uc3Rlcm0ubQpAQCAtMzQ5NSw2ICszNDk1LDggQEAgTm90ZSB0aGF0IENVUlNPUl9XSURU SCBpcyBtZWFuaW5nZnVsIG9ubHkgZm9yIChoKWJhciBjdXJzb3JzLgogICAgICAgICAgICAgICAv KiBEZXRlcm1pbmUgdGhlIG9mZnNldCBvZiB1bmRlcmxpbmluZyBmcm9tIHRoZSBiYXNlbGluZS4g Ki8KICAgICAgICAgICAgICAgaWYgKHhfdW5kZXJsaW5lX2F0X2Rlc2NlbnRfbGluZSkKICAgICAg ICAgICAgICAgICBwb3NpdGlvbiA9IGRlc2NlbnQgLSB0aGlja25lc3M7CisgICAgICAgICAgICAg IGVsc2UgaWYgKHhfdW5kZXJsaW5lX2JlbG93X2ZvbnRfZGVzY2VudCAmJiBmb250KQorICAgICAg ICAgICAgICAgIHBvc2l0aW9uID0gcy0+eSAtIHMtPnliYXNlICsgZm9udC0+aGVpZ2h0OwogICAg ICAgICAgICAgICBlbHNlIGlmICh4X3VzZV91bmRlcmxpbmVfcG9zaXRpb25fcHJvcGVydGllcwog ICAgICAgICAgICAgICAgICAgICAgICAmJiBmb250ICYmIGZvbnQtPnVuZGVybGluZV9wb3NpdGlv biA+PSAwKQogICAgICAgICAgICAgICAgIHBvc2l0aW9uID0gZm9udC0+dW5kZXJsaW5lX3Bvc2l0 aW9uOwpAQCAtOTQ3MSw2ICs5NDczLDExIEBAIE5pbCBtZWFucyB1c2UgZnVsbHNjcmVlbiB0aGUg b2xkICg8IDEwLjcpIHdheS4gIFRoZSBvbGQgd2F5IHdvcmtzIGJldHRlciB3aXRoCiAgICAgIGRv YzogLyogU0tJUDogcmVhbCBkb2MgaW4geHRlcm0uYy4gICovKTsKICAgeF91bmRlcmxpbmVfYXRf ZGVzY2VudF9saW5lID0gMDsKIAorICBERUZWQVJfQk9PTCAoIngtdW5kZXJsaW5lLWJlbG93LWZv bnQtZGVzY2VudCIsCisJICAgICAgIHhfdW5kZXJsaW5lX2JlbG93X2ZvbnRfZGVzY2VudCwKKyAg ICAgICAgICAgICAgIGRvYzogLyogU0tJUDogcmVhbCBkb2MgaW4geHRlcm0uYy4gICovKTsKKyAg eF91bmRlcmxpbmVfYmVsb3dfZm9udF9kZXNjZW50ID0gMDsKKwogICAvKiBUZWxsIEVtYWNzIGFi b3V0IHRoaXMgd2luZG93IHN5c3RlbS4gICovCiAgIEZwcm92aWRlIChRbnMsIFFuaWwpOwogCmRp ZmYgLS1naXQgYS9zcmMvdzMydGVybS5jIGIvc3JjL3czMnRlcm0uYwppbmRleCA5N2FmYjY3OGMx Li5kZWMzODJhMmYyIDEwMDY0NAotLS0gYS9zcmMvdzMydGVybS5jCisrKyBiL3NyYy93MzJ0ZXJt LmMKQEAgLTI0OTMsNyArMjQ5Myw5IEBAIHhfZHJhd19nbHlwaF9zdHJpbmcgKHN0cnVjdCBnbHlw aF9zdHJpbmcgKnMpCiAgICAgICAgICAgICAgICAgICAgICAgICAgUk9VTkQgKChtYXhpbXVtX2Rl c2NlbnQpIC8gMiksIHdpdGgKICAgICAgICAgICAgICAgICAgICAgICAgICBST1VORCAoeCkgPSBm bG9vciAoeCArIDAuNSkgICovCiAKLSAgICAgICAgICAgICAgICAgICAgICBpZiAoeF91c2VfdW5k ZXJsaW5lX3Bvc2l0aW9uX3Byb3BlcnRpZXMKKyAgICAgICAgICAgICAgICAgICAgICBpZiAoeF91 bmRlcmxpbmVfYmVsb3dfZm9udF9kZXNjZW50KQorICAgICAgICAgICAgICAgICAgICAgICAgcG9z aXRpb24gPSBzLT55IC0gcy0+eWJhc2UgKyBmb250LT5oZWlnaHQ7CisgICAgICAgICAgICAgICAg ICAgICAgZWxzZSBpZiAoeF91c2VfdW5kZXJsaW5lX3Bvc2l0aW9uX3Byb3BlcnRpZXMKICAgICAg ICAgICAgICAgICAgICAgICAgICAgJiYgZm9udC0+dW5kZXJsaW5lX3Bvc2l0aW9uID49IDApCiAg ICAgICAgICAgICAgICAgICAgICAgICBwb3NpdGlvbiA9IGZvbnQtPnVuZGVybGluZV9wb3NpdGlv bjsKICAgICAgICAgICAgICAgICAgICAgICBlbHNlCkBAIC03MzkxLDYgKzczOTMsMTEgQEAgdGhl IGN1cnNvciBoYXZlIG5vIGVmZmVjdC4gICovKTsKICAgICAgZG9jOiAvKiBTS0lQOiByZWFsIGRv YyBpbiB4dGVybS5jLiAgKi8pOwogICB4X3VuZGVybGluZV9hdF9kZXNjZW50X2xpbmUgPSAwOwog CisgIERFRlZBUl9CT09MICgieC11bmRlcmxpbmUtYmVsb3ctZm9udC1kZXNjZW50IiwKKwkgICAg ICAgeF91bmRlcmxpbmVfYmVsb3dfZm9udF9kZXNjZW50CisgICAgIGRvYzogLyogU0tJUDogcmVh bCBkb2MgaW4geHRlcm0uYy4gICovKTsKKyAgeF91bmRlcmxpbmVfYmVsb3dfZm9udF9kZXNjZW50 ID0gMDsKKwogICBERUZWQVJfTElTUCAoIngtdG9vbGtpdC1zY3JvbGwtYmFycyIsIFZ4X3Rvb2xr aXRfc2Nyb2xsX2JhcnMsCiAJICAgICAgIGRvYzogLyogU0tJUDogcmVhbCBkb2MgaW4geHRlcm0u Yy4gICovKTsKICAgVnhfdG9vbGtpdF9zY3JvbGxfYmFycyA9IFF0OwpkaWZmIC0tZ2l0IGEvc3Jj L3h0ZXJtLmMgYi9zcmMveHRlcm0uYwppbmRleCAwZDI1YzdmMWEyLi4xMTllOTk0M2MyIDEwMDY0 NAotLS0gYS9zcmMveHRlcm0uYworKysgYi9zcmMveHRlcm0uYwpAQCAtMzcyNSw3ICszNzI1LDkg QEAgeF9kcmF3X2dseXBoX3N0cmluZyAoc3RydWN0IGdseXBoX3N0cmluZyAqcykKICAgICAgICAg ICAgICAgICAgICAgICAgICBST1VORCAoKG1heGltdW0gZGVzY2VudCkgLyAyKSwgd2l0aAogICAg ICAgICAgICAgICAgICAgICAgICAgIFJPVU5EKHgpID0gZmxvb3IgKHggKyAwLjUpICAqLwogCi0g ICAgICAgICAgICAgICAgICAgICAgaWYgKHhfdXNlX3VuZGVybGluZV9wb3NpdGlvbl9wcm9wZXJ0 aWVzCisgICAgICAgICAgICAgICAgICAgICAgaWYgKHhfdW5kZXJsaW5lX2JlbG93X2ZvbnRfZGVz Y2VudCAmJiBmb250KQorICAgICAgICAgICAgICAgICAgICAgICAgcG9zaXRpb24gPSBzLT55IC0g cy0+eWJhc2UgKyBmb250LT5oZWlnaHQ7CisgICAgICAgICAgICAgICAgICAgICAgZWxzZSBpZiAo eF91c2VfdW5kZXJsaW5lX3Bvc2l0aW9uX3Byb3BlcnRpZXMKICAgICAgICAgICAgICAgICAgICAg ICAgICAgJiYgZm9udCAmJiBmb250LT51bmRlcmxpbmVfcG9zaXRpb24gPj0gMCkKICAgICAgICAg ICAgICAgICAgICAgICAgIHBvc2l0aW9uID0gZm9udC0+dW5kZXJsaW5lX3Bvc2l0aW9uOwogICAg ICAgICAgICAgICAgICAgICAgIGVsc2UgaWYgKGZvbnQpCkBAIC0xMzI1MSwxMiArMTMyNTMsMjEg QEAgc21hbGwgZm9udCBkaXNwbGF5IHNpemVzLiAgKi8pOwogCSAgICAgICB4X3VuZGVybGluZV9h dF9kZXNjZW50X2xpbmUsCiAgICAgIGRvYzogLyogTm9uLW5pbCBtZWFucyB0byBkcmF3IHRoZSB1 bmRlcmxpbmUgYXQgdGhlIHNhbWUgcGxhY2UgYXMgdGhlIGRlc2NlbnQgbGluZS4KIChJZiBgbGlu ZS1zcGFjaW5nJyBpcyBpbiBlZmZlY3QsIHRoYXQgbW92ZXMgdGhlIHVuZGVybGluZSBsb3dlciBi eQotdGhhdCBtYW55IHBpeGVscy4pCit0aGF0IG1hbnkgcGl4ZWxzLiBJZiB0aGlzIGlzIG5vdCB3 aGF0IHlvdSB3YW50LCBzZWUgYHgtdW5kZXJsaW5lLWJlbG93LWZvbnQtZGVzY2VudCcpCiBBIHZh bHVlIG9mIG5pbCBtZWFucyB0byBkcmF3IHRoZSB1bmRlcmxpbmUgYWNjb3JkaW5nIHRvIHRoZSB2 YWx1ZSBvZiB0aGUKIHZhcmlhYmxlIGB4LXVzZS11bmRlcmxpbmUtcG9zaXRpb24tcHJvcGVydGll cycsIHdoaWNoIGlzIHVzdWFsbHkgYXQgdGhlCiBiYXNlbGluZSBsZXZlbC4gIFRoZSBkZWZhdWx0 IHZhbHVlIGlzIG5pbC4gICovKTsKICAgeF91bmRlcmxpbmVfYXRfZGVzY2VudF9saW5lID0gZmFs c2U7CiAKKyAgREVGVkFSX0JPT0wgKCJ4LXVuZGVybGluZS1iZWxvdy1mb250LWRlc2NlbnQiLAor CSAgICAgICB4X3VuZGVybGluZV9iZWxvd19mb250X2Rlc2NlbnQsCisgICAgIGRvYzogLyogTm9u LW5pbCBtZWFucyB0byBkcmF3IHRoZSB1bmRlcmxpbmUgYmVsb3cgdGhlIGZvbnQncyBkZXNjZW5k ZXJzLgorKElnbm9yZWQgaWYgYHgtdW5kZXJsaW5lLWF0LWRlc2NlbnQtbGluZScgaXMgbm9uLW5p bCkKK0EgdmFsdWUgb2YgbmlsIG1lYW5zIHRvIGRyYXcgdGhlIHVuZGVybGluZSBhY2NvcmRpbmcg dG8gdGhlIHZhbHVlIG9mIHRoZQordmFyaWFibGUgYHgtdXNlLXVuZGVybGluZS1wb3NpdGlvbi1w cm9wZXJ0aWVzJywgd2hpY2ggaXMgdXN1YWxseSBhdCB0aGUKK2Jhc2VsaW5lIGxldmVsLiAgVGhl IGRlZmF1bHQgdmFsdWUgaXMgbmlsLiAgKi8pOworICB4X3VuZGVybGluZV9iZWxvd19mb250X2Rl c2NlbnQgPSBmYWxzZTsKKwogICBERUZWQVJfQk9PTCAoIngtbW91c2UtY2xpY2stZm9jdXMtaWdu b3JlLXBvc2l0aW9uIiwKIAkgICAgICAgeF9tb3VzZV9jbGlja19mb2N1c19pZ25vcmVfcG9zaXRp b24sCiAgICAgZG9jOiAvKiBOb24tbmlsIG1lYW5zIHRoYXQgYSBtb3VzZSBjbGljayB0byBmb2N1 cyBhIGZyYW1lIGRvZXMgbm90IG1vdmUgcG9pbnQuCi0tIAoyLjE1LjEKCg== --001a1149a22ccadecb056610a618--