From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Burks Newsgroups: gmane.emacs.bugs Subject: bug#70182: [PATCH] Fix + ert for segmentation fault in get-variable-watchers (1 of 9) Date: Sun, 7 Apr 2024 13:43:45 -0400 Message-ID: References: <86sezz3qco.fsf@gnu.org> <86bk6l1u5z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000b10f980615853f20" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="689"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70182@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 08 06:57:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rth4U-000AVI-Qv for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Apr 2024 06:57:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rth3x-0001wR-JM; Mon, 08 Apr 2024 00:56:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rth3w-0001w4-9u for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 00:56:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rth3w-0003TK-15 for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 00:56:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rth42-0004eG-P2 for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 00:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Burks Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Apr 2024 04:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70182 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70182-submit@debbugs.gnu.org id=B70182.171255219517789 (code B ref 70182); Mon, 08 Apr 2024 04:57:02 +0000 Original-Received: (at 70182) by debbugs.gnu.org; 8 Apr 2024 04:56:35 +0000 Original-Received: from localhost ([127.0.0.1]:45088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rth3a-0004ck-6s for submit@debbugs.gnu.org; Mon, 08 Apr 2024 00:56:35 -0400 Original-Received: from mail-oo1-xc30.google.com ([2607:f8b0:4864:20::c30]:57561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtWZw-0002ff-FY for 70182@debbugs.gnu.org; Sun, 07 Apr 2024 13:45:16 -0400 Original-Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-5aa2dcd4454so334539eaf.2 for <70182@debbugs.gnu.org>; Sun, 07 Apr 2024 10:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712511903; x=1713116703; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qbX6cxzEDbxIkQsSpb5+/yqhIjaoEftM0Z4y+wsEgKY=; b=GhXDKTcZrEtbpFFXoE56VQ/aYdBAaJGvI0iI8RuTVv0bZhEtk6Iut58N5IVXOA+USR 3eFkJKgAoBHp/uzcxvY7otmQrijXLnM5n361m0GC42DPhRwttmf7SXUNNUW3sisKh7wh IiD124TzpdOEMJU8yz4msSAmIITm1qpXfUbiPG3AOLXfjSjBh32xtkdYvyU0xI1XiaTr o2Zq4Ccug6upKYYdk3HR+HosHY3kVVE2ISzsaFJHShLMADyiSOAxXmxFBbtFHno63mSJ im6LUk/8kJ8Txc1VL8FZCz1jBwmV7wkKsUP3pEsTWT43kT3UMzx31tB+Jae5HrJ/v02q dS8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712511903; x=1713116703; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qbX6cxzEDbxIkQsSpb5+/yqhIjaoEftM0Z4y+wsEgKY=; b=bQsLVrBgUt9SbktWTjLT54YPH2+rtVH/1oJAkvPxhX7tH/7qxXfgStN80oyWrFTUPM 4ZhCyyuUG2Ql2RiuhZTAf1wwEWC0Hbv+OUW7RA9mdfg7bvbOdcEY1FPTFllOcduMn3mG OTXaLrXk3JP1muWwu1s+/Q+wck5gDw5iara7bmHNXUyJtNvsZfdSgSD6rDnyWp01FH12 ShboHqtO6pDucbMHqY4Rez6mNBq0d/933FfLGRBOeheaZi/LIv9zstFIIFaGhYHGz3fC A3TXEc+udWXrP1ktME+hn2TEi/jI84myhmTKySCk1qtAuc31k2dXv9CM9YbLX5mNOlQH /xrA== X-Gm-Message-State: AOJu0YyrrYqN9smI2j58zL+TAqq4yDNFa8M4daxkbCcLMft96vx+xukk OM5wdGPErsBeYQ7O1jtYtdYsJY9EJaabj3G4SZZJQHSYWXxk1rb3sebAJHQWdZZBK2nwlbljmhw TstOYPP8/gQRgB2/L/NDA3nm57g== X-Google-Smtp-Source: AGHT+IExgVN4lDnuZXhvUo15WFgiRvj8eS9hVs1vvbqNj9RMcaRKt2Rwah5nvOPbxTOSoxZbmJaKOiWQjXQMHHBeQqY= X-Received: by 2002:a9d:618f:0:b0:6ea:194c:d1c6 with SMTP id g15-20020a9d618f000000b006ea194cd1c6mr312746otk.25.1712511903663; Sun, 07 Apr 2024 10:45:03 -0700 (PDT) In-Reply-To: <86bk6l1u5z.fsf@gnu.org> X-Mailman-Approved-At: Mon, 08 Apr 2024 00:56:31 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282907 Archived-At: --000000000000b10f980615853f20 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Got it. On Sun, Apr 7, 2024 at 3:58=E2=80=AFAM Eli Zaretskii wrote: > [Please use Reply All to reply, to keep the bug tracker CC'ed.] > > > From: Robert Burks > > Date: Sun, 7 Apr 2024 02:30:54 -0400 > > > > I will make the changes. Sorry if my previous reply came across as > rash, wasn't the intent. > > Should I remove the bug number tag also? > > The bug number should be mentioned in the commit log message, not in > the sources. > > > Also, kicking myself, I know they should end with a period and two > spaces, every other > > comment I've written probably does. Somehow the only ones I didn't > check was the very > > first patch, lol. That first comment wasn't even supposed to go out, > that was my personal note > > for when I was going through looking for more of the same bug. > > > > There will probably be other comments to remove. > > Thanks. > --000000000000b10f980615853f20 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Got it.

On Sun, Apr 7, 2024 at 3:58=E2=80=AFAM Eli Zaretskii &= lt;eliz@gnu.org> wrote:
[Please use Reply All to rep= ly, to keep the bug tracker CC'ed.]

> From: Robert Burks <rburksdev@gmail.com>
> Date: Sun, 7 Apr 2024 02:30:54 -0400
>
> I will make the changes.=C2=A0 Sorry if my previous reply came across = as rash, wasn't the intent.
> Should I remove the bug number tag also?

The bug number should be mentioned in the commit log message, not in
the sources.

> Also, kicking myself, I know they should end with a period and two spa= ces, every other
> comment I've written probably does.=C2=A0 Somehow the only ones I = didn't check was the very
> first patch, lol.=C2=A0 That first comment wasn't even supposed to= go out, that was my personal note
> for when I was going through looking for more of the same bug.
>
> There will probably be other comments to remove.

Thanks.
--000000000000b10f980615853f20--