From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Pete Williamson Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl Date: Fri, 13 Mar 2015 16:46:46 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bd762b400b50f0511341d6d X-Trace: ger.gmane.org 1426290800 1371 80.91.229.3 (13 Mar 2015 23:53:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Mar 2015 23:53:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michal Nazarewicz Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 14 00:53:11 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YWZOB-0005OX-A0 for ged-emacs-devel@m.gmane.org; Sat, 14 Mar 2015 00:53:11 +0100 Original-Received: from localhost ([::1]:39055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWZOA-0001IR-Jj for ged-emacs-devel@m.gmane.org; Fri, 13 Mar 2015 19:53:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWZNo-0001Er-SJ for emacs-devel@gnu.org; Fri, 13 Mar 2015 19:52:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWZHz-0001XW-L0 for emacs-devel@gnu.org; Fri, 13 Mar 2015 19:46:49 -0400 Original-Received: from mail-pa0-x22b.google.com ([2607:f8b0:400e:c03::22b]:35329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWZHz-0001XL-AW for emacs-devel@gnu.org; Fri, 13 Mar 2015 19:46:47 -0400 Original-Received: by pabyw6 with SMTP id yw6so2788178pab.2 for ; Fri, 13 Mar 2015 16:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=qpdxT4TlciS2VgGcWR3rSRw1bt9zHJSYNe+cjv7Q2Bo=; b=Vqtdepy+L8X6yixiBG4VWLe8SfZYLFEL4CKgh2O5tXMlQ7lEZ+xvIVWDKU3308TE0c nBPGx0w70zZh76x5mRTJDHbgdbMkLHfF60K2ulxVqaQNKXk44NEmr+1TZMrpDSqaYHeC 3jvEWH8jg4hT/bd4xLui9Bg/8/nw1Y9PWyznECWDNoXkIEbgkBm2mDazYoGznr2iaAEO sXaQwzNu4LjmzkDpSOjkv8Q9P00ZRBX8wjf6nt408pdx9sB0iyGegSu9Qtt8OjKWmuCE e77cIMbOcG5AfQ3PbYoWC1W+N10nlq7zrcOPmmHfvU4Jaro4/ASPI8DyutiPvsBlz8nV tK0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=qpdxT4TlciS2VgGcWR3rSRw1bt9zHJSYNe+cjv7Q2Bo=; b=JFsKcFLssiXpwM4Vuz2TUbFhnF2LkseOM7Pm9LevP2P9JLoTvyicVDAtbavcn+2+xq 6hgtxQ7iKiyvKh3wuVNAVPh58qubisJp5x3ULAwrUoftKX3H1FOWlh9FW+vdXm+4/8VL 5w6baWW+DJhbn5zomnGyzjJW+aDILRYbncJw/X94DXrcTUgduFcvHZtgn9Ie6FTmUOQm +vy/iDfKUTtm2IjV/lkEG/ZdOvs2d7GVbwBYOErQOOmGnE8Ioc/2mR6IQAnMKicXrgst ++Ztjl+pw0BzXDJKV+uaEV0V3YIVVzsJOu0KXlhKwYpID5jaxzzxRRXdejh5ypPE/pXG J0Gw== X-Gm-Message-State: ALoCoQl2/ddTWyM8bVGtlohJrZcYbBNFFORl43IrgxrRh2eZgx2fUL24YzT1rl/5bZ4DXUpC9xXu X-Received: by 10.70.18.36 with SMTP id t4mr109030251pdd.66.1426290406097; Fri, 13 Mar 2015 16:46:46 -0700 (PDT) Original-Received: by 10.70.31.4 with HTTP; Fri, 13 Mar 2015 16:46:46 -0700 (PDT) Original-Received: by 10.70.31.4 with HTTP; Fri, 13 Mar 2015 16:46:46 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183863 Archived-At: --047d7bd762b400b50f0511341d6d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Yes, that's intentional, I wanted to vet the approach first. If others feel the same, I'm happy to move all the changes into my patch. On Mar 13, 2015 4:44 PM, "Michal Nazarewicz" wrote: > > On Fri, Mar 13 2015, Pete Williamson wrote: > > @@ -8206,6 +8210,7 @@ rm -f core conftest.err conftest.$ac_objext \ > > > > test "x$CANNOT_DUMP" =3D "x" && CANNOT_DUMP=3Dno > > case "$opsys" in > > + nacl) CANNOT_DUMP=3Dyes ;; > > your-opsys-here) CANNOT_DUMP=3Dyes ;; > > esac > > > > @@ -9828,6 +9833,7 @@ system_malloc=3Dno > > case "$opsys" in > > ## darwin ld insists on the use of malloc routines in the System framework. > > darwin|sol2-10) system_malloc=3Dyes ;; > > + nacl) system_malloc=3Dyes ;; > > esac > > > > if test "${system_malloc}" =3D "yes"; then > > @@ -15169,7 +15175,7 @@ esac > > emacs_broken_SIGIO=3Dno > > > > case $opsys in > > - hpux* | irix6-5 | openbsd | sol2* | unixware ) > > + hpux* | irix6-5 | openbsd | sol2* | unixware | nacl ) > > emacs_broken_SIGIO=3Dyes > > ;; > > > > @@ -15277,7 +15283,7 @@ case $opsys in > > > > ;; > > > > - gnu-linux | gnu-kfreebsd | freebsd | netbsd ) > > + nacl | gnu-linux | gnu-kfreebsd | freebsd | netbsd ) > > if test "x$ac_cv_func_grantpt" =3D xyes; then > > > > $as_echo "#define UNIX98_PTYS 1" >>confdefs.h > > @@ -15430,7 +15436,7 @@ if test $emacs_glibc =3D yes; then > > emacs_pending_output=3Dunknown > > > > case $opsys in > > - gnu | gnu-linux | gnu-kfreebsd ) > > + nacl | gnu | gnu-linux | gnu-kfreebsd ) > > { $as_echo "$as_me:${as_lineno-$LINENO}: checking for style of pending > > output formalism" >&5 > > $as_echo_n "checking for style of pending output formalism... " >&6; } > > cat confdefs.h - <<_ACEOF >conftest.$ac_ext > > @@ -24659,7 +24665,7 @@ LD_FIRSTFLAG=3D > > ORDINARY_LINK=3D > > case "$opsys" in > > ## gnu: GNU needs its own crt0. > > - aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware) ORDINARY_LINK=3Dyes > > ;; > > + nacl|aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware) > > ORDINARY_LINK=3Dyes ;; > > So your patch, the attached file, is missing the above changes in the > configure.ac file. Is that intentional? I imagine it would make sense > to bundle them all together into a single patch. > > -- > Best regards, _ _ > .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o > ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = (o o) > ooo +------ooO--(_)--Ooo-- --047d7bd762b400b50f0511341d6d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Yes, that's intentional, I wanted to vet the approach fi= rst.=C2=A0 If others feel the same, I'm happy to move all the changes i= nto my patch.
On Mar 13, 2015 4:44 PM, "Michal Nazarewicz" <mina86@mina86.com> wrote:
>
> On Fri, Mar 13 2015, Pete Williamson <petewil@google.com> wrote:
> > @@ -8206,6 +8210,7 @@ rm -f core conftest.err conftest.$ac_objext= \
> >
> > test "x$CANNOT_DUMP" =3D "x" && CANNO= T_DUMP=3Dno
> > case "$opsys" in
> > + nacl) CANNOT_DUMP=3Dyes ;;
> > your-opsys-here) CANNOT_DUMP=3Dyes ;;
> > esac
> >
> > @@ -9828,6 +9833,7 @@ system_malloc=3Dno
> > case "$opsys" in
> > ## darwin ld insists on the use of malloc routines in the System = framework.
> > darwin|sol2-10) system_malloc=3Dyes ;;
> > + nacl) system_malloc=3Dyes ;;
> > esac
> >
> > if test "${system_malloc}" =3D "yes"; then > > @@ -15169,7 +15175,7 @@ esac
> > emacs_broken_SIGIO=3Dno
> >
> > case $opsys in
> > - hpux* | irix6-5 | openbsd | sol2* | unixware )
> > + hpux* | irix6-5 | openbsd | sol2* | unixware | nacl )
> > emacs_broken_SIGIO=3Dyes
> > ;;
> >
> > @@ -15277,7 +15283,7 @@ case $opsys in
> >
> > ;;
> >
> > - gnu-linux | gnu-kfreebsd | freebsd | netbsd )
> > + nacl | gnu-linux | gnu-kfreebsd | freebsd | netbsd )
> > if test "x$ac_cv_func_grantpt" =3D xyes; then
> >
> > $as_echo "#define UNIX98_PTYS 1" >>confdefs.h
> > @@ -15430,7 +15436,7 @@ if test $emacs_glibc =3D yes; then
> > emacs_pending_output=3Dunknown
> >
> > case $opsys in
> > - gnu | gnu-linux | gnu-kfreebsd )
> > + nacl | gnu | gnu-linux | gnu-kfreebsd )
> > { $as_echo "$as_me:${as_lineno-$LINENO}: checking for style = of pending
> > output formalism" >&5
> > $as_echo_n "checking for style of pending output formalism..= . " >&6; }
> > cat confdefs.h - <<_ACEOF >conftest.$ac_ext
> > @@ -24659,7 +24665,7 @@ LD_FIRSTFLAG=3D
> > ORDINARY_LINK=3D
> > case "$opsys" in
> > ## gnu: GNU needs its own crt0.
> > - aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware) ORDINARY= _LINK=3Dyes
> > ;;
> > + nacl|aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware)
> > ORDINARY_LINK=3Dyes ;;
>
> So your patch, the attached file, is missing the above changes in the<= br> > configure.ac file.=C2=A0 Is that i= ntentional?=C2=A0 I imagine it would make sense
> to bundle them all together into a single patch.
>
> --
> Best regards,=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0_=C2=A0 =C2=A0 =C2=A0_
> .o. | Liege of Serenely Enlightened Majesty of=C2=A0 =C2=A0 =C2=A0 o&#= 39; \,=3D./ `o
> ..o | Computer Science,=C2=A0 Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Naz= arewicz=C2=A0 =C2=A0 (o o)
> ooo +--<mpn@google.com>--&= lt;xmpp:mina86@jabber.org&g= t;--ooO--(_)--Ooo--

--047d7bd762b400b50f0511341d6d--