From: Pete Williamson <petewil@google.com>
To: emacs-devel@gnu.org
Cc: Michal Nazarewicz <mina86@mina86.com>
Subject: [PATCH] - Introduce reference to a new Emacs build target - NaCl
Date: Fri, 13 Mar 2015 14:57:31 -0700 [thread overview]
Message-ID: <CAHsSLHC2m64tJtK7qMg_NjLoNA9JzCS2WxDx6qbu9kvtfb7u9A@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 2707 bytes --]
I would like to request feedback on this patch for the emacs configure.ac
file.
As I mentioned in previous patch requests, I'm adding support for a new
build target, the chromium browser's Native Client (NaCl) platform. We
have a patch for emacs working today (for some definitions of working ^_^)
in NaCl ports, and we would like to port the changes back to the emacs code
base.
Is this the right way to introduce a new build target? Once this is
checked in, I have more changes for the config.ac file, but I wanted to
vette the approach with the good folks on this email list before proceeding.
For a preview of the other changes I hope to port to the configure.ac file,
here is a list of changes in our port today, I hope to port most or all of
these to the regular emacs code base in future patches.
--- a/configure
+++ b/configure
@@ -4631,6 +4631,10 @@ case "${canonical}" in
esac
;;
+ *-nacl )
+ opsys=nacl
+ ;;
+
## Intel 386 machines where we don't care about the manufacturer.
i[3456]86-*-* )
case "${canonical}" in
@@ -8206,6 +8210,7 @@ rm -f core conftest.err conftest.$ac_objext \
test "x$CANNOT_DUMP" = "x" && CANNOT_DUMP=no
case "$opsys" in
+ nacl) CANNOT_DUMP=yes ;;
your-opsys-here) CANNOT_DUMP=yes ;;
esac
@@ -9828,6 +9833,7 @@ system_malloc=no
case "$opsys" in
## darwin ld insists on the use of malloc routines in the System framework.
darwin|sol2-10) system_malloc=yes ;;
+ nacl) system_malloc=yes ;;
esac
if test "${system_malloc}" = "yes"; then
@@ -15169,7 +15175,7 @@ esac
emacs_broken_SIGIO=no
case $opsys in
- hpux* | irix6-5 | openbsd | sol2* | unixware )
+ hpux* | irix6-5 | openbsd | sol2* | unixware | nacl )
emacs_broken_SIGIO=yes
;;
@@ -15277,7 +15283,7 @@ case $opsys in
;;
- gnu-linux | gnu-kfreebsd | freebsd | netbsd )
+ nacl | gnu-linux | gnu-kfreebsd | freebsd | netbsd )
if test "x$ac_cv_func_grantpt" = xyes; then
$as_echo "#define UNIX98_PTYS 1" >>confdefs.h
@@ -15430,7 +15436,7 @@ if test $emacs_glibc = yes; then
emacs_pending_output=unknown
case $opsys in
- gnu | gnu-linux | gnu-kfreebsd )
+ nacl | gnu | gnu-linux | gnu-kfreebsd )
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for style of pending
output formalism" >&5
$as_echo_n "checking for style of pending output formalism... " >&6; }
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
@@ -24659,7 +24665,7 @@ LD_FIRSTFLAG=
ORDINARY_LINK=
case "$opsys" in
## gnu: GNU needs its own crt0.
- aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware) ORDINARY_LINK=yes
;;
+ nacl|aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware)
ORDINARY_LINK=yes ;;
## On post 1.3 releases of NetBSD, gcc -nostdlib also clears the
## library search parth, i.e. it won't search /usr/lib for libc and Thanks!
[-- Attachment #1.2: Type: text/html, Size: 13969 bytes --]
[-- Attachment #2: 0001-Add-NaCl-to-list-of-supported-OSs.patch --]
[-- Type: text/x-patch, Size: 1301 bytes --]
From cd6ed4f967f17469effe552607b014e0c36fd0e1 Mon Sep 17 00:00:00 2001
From: Pete Williamson <petewil@chromium.org>
Date: Fri, 13 Mar 2015 11:56:36 -0700
Subject: [PATCH] Add NaCl to list of supported OSs
This is the first part of adding support for the NativeClient (NaCl)
build system to port emacs to NaCl. NaCl is a way to build native code
binaries to run as apps or in tabs in the chromium browser.
This is a part of an ongoing port to NaCl. See
https://code.google.com/p/naclports/source/browse/trunk/src/ports/emacs/nacl.patch?spec=svn1621&r=1621
---
ChangeLog | 4 ++++
configure.ac | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 4f6523e..d478283 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2015-03-13 Pete Williamson <petewil@chromium.org> (tiny change)
+
+ * configure.ac: Add a new supported OS type, NaCl
+
2015-03-02 Robert Pluim <rpluim@gmail.com> (tiny change)
* configure.ac: Error out if with-file-notification=w32 is
diff --git a/configure.ac b/configure.ac
index d65494a..7da1c06 100644
--- a/configure.ac
+++ b/configure.ac
@@ -718,6 +718,11 @@ case "${canonical}" in
esac
;;
+ ## NativeClient for Chromium
+ *-nacl )
+ opsys=nacl
+ ;;
+
* )
unported=yes
;;
--
2.2.0.rc0.207.ga3a616c
next reply other threads:[~2015-03-13 21:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 21:57 Pete Williamson [this message]
2015-03-13 23:44 ` [PATCH] - Introduce reference to a new Emacs build target - NaCl Michal Nazarewicz
2015-03-13 23:46 ` Pete Williamson
2015-03-14 0:28 ` Paul Eggert
2015-03-14 0:29 ` Pete Williamson
2015-03-18 16:04 ` Pete Williamson
2015-03-28 0:30 ` Pete Williamson
2015-03-29 21:50 ` Paul Eggert
2015-03-30 10:12 ` Richard Stallman
2015-03-30 21:41 ` Pete Williamson
2015-03-31 14:06 ` Richard Stallman
2015-03-31 18:29 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHsSLHC2m64tJtK7qMg_NjLoNA9JzCS2WxDx6qbu9kvtfb7u9A@mail.gmail.com \
--to=petewil@google.com \
--cc=emacs-devel@gnu.org \
--cc=mina86@mina86.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.