From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Pete Williamson Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl Date: Fri, 27 Mar 2015 17:30:34 -0700 Message-ID: References: <550380B6.7000308@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7bdc1b0c72fa3e05124e5b84 X-Trace: ger.gmane.org 1427502662 19267 80.91.229.3 (28 Mar 2015 00:31:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Mar 2015 00:31:02 +0000 (UTC) Cc: Michal Nazarewicz , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 28 01:30:51 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YbeeC-0007fy-JP for ged-emacs-devel@m.gmane.org; Sat, 28 Mar 2015 01:30:44 +0100 Original-Received: from localhost ([::1]:52377 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbeeB-0002fQ-Jp for ged-emacs-devel@m.gmane.org; Fri, 27 Mar 2015 20:30:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ybee6-0002fA-HQ for emacs-devel@gnu.org; Fri, 27 Mar 2015 20:30:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ybee4-00060O-Du for emacs-devel@gnu.org; Fri, 27 Mar 2015 20:30:38 -0400 Original-Received: from mail-pd0-x22f.google.com ([2607:f8b0:400e:c02::22f]:34828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ybee4-00060F-1a for emacs-devel@gnu.org; Fri, 27 Mar 2015 20:30:36 -0400 Original-Received: by pdbop1 with SMTP id op1so111485269pdb.2 for ; Fri, 27 Mar 2015 17:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=yv/FLPkBHlGDvuiGQZFUCEx4dSloD+AIDU5BRqhuT40=; b=f961WTaPfcvvwxEaXCbuOqhrFuM7NHX6rqOiwlbcIaKKEdh09FeOLX1iQpENHz5tP5 jBKl0HoQo16Zh/zGTzbTt9RqXTqe9aKel1MLFZdsKZqC/6zx1QTVoOL77Q9GdnWlXlfS L8yLQ0EZfrQ6nMMXkE60HgSX8VsKKq0BT1ddI7is4zCYARtkR9dBzaIp0hbqyq8S7EXh mm1W+ASN72XYTWsLQ0u/D3p9W7GTd8T1PCX4gunNfiTLXr/SzeznjS/VP3qluKwKH/3h Y/YdHWAW3UsJjb/B1O+A2ff/9hOeC6douWmdgX2gACb4URG2xS8DqZauRVXi8yN9XFPp xXdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=yv/FLPkBHlGDvuiGQZFUCEx4dSloD+AIDU5BRqhuT40=; b=iAlWQjRmx0bac4CVN8pw7oya7nfrr4kJmt1/4WSScFxzrijqqs/kwFZRCPqlHgr0Uy ecAmnz4RuYyUiK3iJag5sD27MKaXAlyKJyuTkBhKuIISooMB3PXzAHbqWo9KUez8jxxT JhZcY5rEC2OkU0qr6H/q3b8J5wUKmIMdGJlUj0W3LZl8NHEQV12kp7Jm5spZ2NfHUclN Xv/M9/qydtEQelcHqZpDzWA7FZJxcjlp35pQ11arhJtHULiKZj0UlG+AcJsmqbxhQDCT CPSVaE0hNBGN77y47whvyaauOr3vR1RL1Ck9HOBblwlXfcU/lL6AB4PNI2qtIeO/rls6 J2Qw== X-Gm-Message-State: ALoCoQmOrSLAsQqjkMXz6P2TvtNPKp83ptUh/YmSM4v3XOFgjQBavlquB8nbEozUsmLWPmlzJR46 X-Received: by 10.70.15.67 with SMTP id v3mr38981049pdc.166.1427502634460; Fri, 27 Mar 2015 17:30:34 -0700 (PDT) Original-Received: by 10.70.31.4 with HTTP; Fri, 27 Mar 2015 17:30:34 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c02::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184435 Archived-At: --047d7bdc1b0c72fa3e05124e5b84 Content-Type: multipart/alternative; boundary=047d7bdc1b0c72fa3805124e5b82 --047d7bdc1b0c72fa3805124e5b82 Content-Type: text/plain; charset=UTF-8 Here is a fresh patch, all comments welcome! As suggested, I've put all the changes we need into the configure.ac file instead of just the first one. Again, this patch is to add the NaCl operating system for chromium into the emacs configure.ac file. As I mentioned in previous patch requests, I'm adding support for a new build target, the chromium browser's Native Client (NaCl) platform. We have a patch for emacs working today (for some definitions of working ^_^) in NaCl ports, and we would like to port the changes back to the emacs code base. Our work in progress is visible in the "naclports" github project. On Wed, Mar 18, 2015 at 9:04 AM, Pete Williamson wrote: > Since there has been no other feedback on this topic, I'll take Michal's > suggestion (and clear up Paul's confusion), and make all the changes to the > config.ac file at once, stay tuned for an updated patch. > > On Fri, Mar 13, 2015 at 5:29 PM, Pete Williamson > wrote: > >> The actual patch is to configure.ac. The diff is showing things that I >> would move from my current "configure" file to "configure.ac" >> >> On Fri, Mar 13, 2015 at 5:28 PM, Paul Eggert wrote: >> >>> Pete Williamson wrote: >>> >>>> --- a/configure >>>> +++ b/configure >>>> >>> >>> 'configure' is generated automatically from 'configure.ac' and other >>> files, so patches to 'configure' are ineffective. You need to patch >>> configure.ac and the other files instead. >>> >>> If you need to patch config.guess and/or config.sub, they come from a >>> different project and those changes need to be sent upstream, as described >>> in those files. >>> >> >> > --047d7bdc1b0c72fa3805124e5b82 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Here is a fresh patch, all comments welcome!=C2=A0 As sugg= ested, I've put all the changes we need into the configure.ac file instead of just the first one.

Again, this patch is to= add the NaCl operating system for chromium into the emacs=C2=A0configure.ac=C2= =A0file.

As I mentioned in previous patch requ= ests, I'm adding support for a new build target, the chromium browser&#= 39;s Native Client (NaCl) platform.=C2=A0 We have a patch for emacs working= today (for some definitions of working ^_^) in NaCl ports, and we would li= ke to port the changes back to the emacs code base.

Our work in progress is visible in the "naclports" g= ithub project.

On Wed, Mar 18, 2015 at 9:04 AM, Pete Williamson <petewil@google= .com> wrote:
Since there has been no other feedback on this topic, I'll take Mich= al's suggestion (and clear up Paul's confusion), and make all the c= hanges to the config.ac = file at once, stay tuned for an updated patch.
<= div class=3D"h5">

= On Fri, Mar 13, 2015 at 5:29 PM, Pete Williamson <petewil@google.com&= gt; wrote:
The ac= tual patch is to configur= e.ac.=C2=A0 The diff is showing things that I would move from my curren= t "configure" file to "configure.ac"

On Fri, Mar 13, 2015 at 5:28 PM, Paul Egg= ert <eggert@cs.ucla.edu> wrote:
Pete Williamson wrote:
--- a/configure
+++ b/configure

'configure' is generated automatically from 'configure.ac' and other files, so p= atches to 'configure' are ineffective.=C2=A0 You need to patch configure.ac and the othe= r files instead.

If you need to patch config.guess and/or config.sub, they come from a diffe= rent project and those changes need to be sent upstream, as described in th= ose files.



--047d7bdc1b0c72fa3805124e5b82-- --047d7bdc1b0c72fa3e05124e5b84 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Add-NaCl-to-the-list-of-supported-OSs.patch" Content-Disposition: attachment; filename="0001-Add-NaCl-to-the-list-of-supported-OSs.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i7sa4i7b0 RnJvbSAyZjYxOWVlZDk0NjYzNTA3NGJlMTVkZGNhOTMxMWMxZTc4ZWJkOGM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlIFdpbGxpYW1zb24gPHBldGV3aWxAY2hyb21pdW0ub3Jn PgpEYXRlOiBGcmksIDI3IE1hciAyMDE1IDE3OjI0OjIzIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0g QWRkIE5hQ2wgdG8gdGhlIGxpc3Qgb2Ygc3VwcG9ydGVkIE9TcwoKVGhpcyBpcyB0aGUgZmlyc3Qg cGFydCBvZiBhZGRpbmcgc3VwcG9ydCBmb3IgdGhlIE5hdGl2ZUNsaWVudCAoTmFDbCkKYnVpbGQg c3lzdGVtIHRvIHBvcnQgZW1hY3MgdG8gTmFDbC4gIE5hQ2wgaXMgYSB3YXkgdG8gYnVpbGQgbmF0 aXZlIGNvZGUKYmluYXJpZXMgdG8gcnVuIGFzIGFwcHMgb3IgaW4gdGFicyBpbiB0aGUgY2hyb21p dW0gYnJvd3Nlci4KClRoaXMgaXMgYSBwYXJ0IG9mIGFuIG9uZ29pbmcgcG9ydCB0byBOYUNsLiAg U2VlCmh0dHBzOi8vY29kZS5nb29nbGUuY29tL3AvbmFjbHBvcnRzL3NvdXJjZS9icm93c2UvdHJ1 bmsvc3JjL3BvcnRzL2VtYWNzL25hY2wucGF0Y2g/c3BlYz1zdm4xNjIxJnI9MTYyMQotLS0KIENo YW5nZUxvZyAgICB8ICA1ICsrKysrCiBjb25maWd1cmUuYWMgfCAxNCArKysrKysrKysrLS0tLQog MiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhNDg5YWI5Li5kODM5YjY4IDEwMDY0 NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsOCBAQAorMjAxNS0w MzAyNyBQZXRlIFdpbGxpYW1zb24gPHBldGV3aWxAY2hyb21pdW0ub3JnPgorCisJKiBjb25maWd1 cmUuYWM6IEFkZCBhIG5ldyBzdXBwb3J0ZWQgdGFyZ2V0LCBDaHJvbWl1bSBOYXRpdmUgQ2xpZW50 CisJKE5hQ2wpLgorCiAyMDE1LTAzLTIzICBBbmRyZWFzIFNjaHdhYiAgPHNjaHdhYkBzdXNlLmRl PgogCiAJKiBjb25maWd1cmUuYWM6IEZpeCBqcGVnIHZlcnNpb24gY2hlY2sgdG8gd29yayB3aXRo IGdjYyA+PSA1LgpkaWZmIC0tZ2l0IGEvY29uZmlndXJlLmFjIGIvY29uZmlndXJlLmFjCmluZGV4 IGJlZDk0ZmIuLjQ2NzZmZGQgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1 cmUuYWMKQEAgLTY5MCw2ICs2OTAsMTEgQEAgY2FzZSAiJHtjYW5vbmljYWx9IiBpbgogICAgIGVz YWMKICAgOzsKIAorICAjIyBDaHJvbWl1bSBOYXRpdmUgQ2xpZW50CisgICotbmFjbCAgKQorICAg IG9wc3lzPW5hY2wKKyAgOzsKKwogICAjIyBJbnRlbCAzODYgbWFjaGluZXMgd2hlcmUgd2UgZG9u J3QgY2FyZSBhYm91dCB0aGUgbWFudWZhY3R1cmVyLgogICBpWzM0NTZdODYtKi0qICkKICAgICBj YXNlICIke2Nhbm9uaWNhbH0iIGluCkBAIC0xMjYzLDYgKzEyNjgsNyBAQCBkbmwgVGhlIGZ1bmN0 aW9uIGR1bXAtZW1hY3Mgd2lsbCBub3QgYmUgZGVmaW5lZCBhbmQgdGVtYWNzIHdpbGwgZG8KIGRu bCAobG9hZCAibG9hZHVwIikgYXV0b21hdGljYWxseSB1bmxlc3MgdG9sZCBvdGhlcndpc2UuCiB0 ZXN0ICJ4JENBTk5PVF9EVU1QIiA9ICJ4IiAmJiBDQU5OT1RfRFVNUD1ubwogY2FzZSAiJG9wc3lz IiBpbgorICBuYWNsKSBDQU5OT1RfRFVNUD15ZXMgOzsKICAgeW91ci1vcHN5cy1oZXJlKSBDQU5O T1RfRFVNUD15ZXMgOzsKIGVzYWMKIApAQCAtMjEwNCw3ICsyMTEwLDcgQEAgaHlicmlkX21hbGxv Yz0KIAogY2FzZSAiJG9wc3lzIiBpbgogICAjIyBkYXJ3aW4gbGQgaW5zaXN0cyBvbiB0aGUgdXNl IG9mIG1hbGxvYyByb3V0aW5lcyBpbiB0aGUgU3lzdGVtIGZyYW1ld29yay4KLSAgZGFyd2lufG1p bmd3MzJ8c29sMi0xMCkgc3lzdGVtX21hbGxvYz15ZXMgOzsKKyAgZGFyd2lufG1pbmd3MzJ8c29s Mi0xMHxuYWNsKSBzeXN0ZW1fbWFsbG9jPXllcyA7OwogICBjeWd3aW4pIGh5YnJpZF9tYWxsb2M9 eWVzOzsKIGVzYWMKIApAQCAtNDE4Niw3ICs0MTkyLDcgQEAgZW1hY3NfYnJva2VuX1NJR0lPPW5v CiBjYXNlICRvcHN5cyBpbgogICBkbmwgU0lHSU8gZXhpc3RzLCBidXQgdGhlIGZlYXR1cmUgZG9l c24ndCB3b3JrIGluIHRoZSB3YXkgRW1hY3MgbmVlZHMuCiAgIGRubCBTZWUgZWcgPGh0dHA6Ly9h cnRpY2xlLmdtYW5lLm9yZy9nbWFuZS5vcy5vcGVuYnNkLnBvcnRzLzQ2ODMxPi4KLSAgaHB1eCog fCBpcml4Ni01IHwgb3BlbmJzZCB8IHNvbDIqIHwgdW5peHdhcmUgKQorICBocHV4KiB8IGlyaXg2 LTUgfCBvcGVuYnNkIHwgc29sMiogfCB1bml4d2FyZSB8IG5hY2wgKQogICAgIGVtYWNzX2Jyb2tl bl9TSUdJTz15ZXMKICAgICA7OwogCkBAIC00MzQ4LDcgKzQzNTQsNyBAQCBjYXNlICRvcHN5cyBp bgogICAgIEFDX0RFRklORShGSVJTVF9QVFlfTEVUVEVSLCBbJ3AnXSkKICAgICA7OwogCi0gIGdu dS1saW51eCB8IGdudS1rZnJlZWJzZCB8IGRyYWdvbmZseSB8IGZyZWVic2QgfCBuZXRic2QgKQor ICBnbnUtbGludXggfCBnbnUta2ZyZWVic2QgfCBkcmFnb25mbHkgfCBmcmVlYnNkIHwgbmV0YnNk IHwgbmFjbCApCiAgICAgZG5sIGlmIEhBVkVfR1JBTlRQVAogICAgIGlmIHRlc3QgIngkYWNfY3Zf ZnVuY19ncmFudHB0IiA9IHh5ZXM7IHRoZW4KICAgICAgIEFDX0RFRklORShVTklYOThfUFRZUywg MSwgW0RlZmluZSBpZiB0aGUgc3lzdGVtIGhhcyBVbml4OTggUFRZcy5dKQpAQCAtNDY0Nyw3ICs0 NjUzLDcgQEAgZXNhYwogCiBBQ19DQUNIRV9DSEVDSyhbZm9yIHVzYWJsZSBGSU9OUkVBRF0sIFtl bWFjc19jdl91c2FibGVfRklPTlJFQURdLAogICBbY2FzZSAkb3BzeXMgaW4KLSAgICAgYWl4NC0y KQorICAgICBhaXg0LTIgfCBuYWNsKQogICAgICAgIGRubCBCVUlMRCA5MDA4IC0gRklPTlJFQUQg cHJvYmxlbSBzdGlsbCBleGlzdHMgaW4gWC1XaW5kb3dzLgogICAgICAgIGVtYWNzX2N2X3VzYWJs ZV9GSU9OUkVBRD1ubwogICAgICAgIDs7Ci0tIAoyLjIuMC5yYzAuMjA3LmdhM2E2MTZjCgo= --047d7bdc1b0c72fa3e05124e5b84--