From: Felipe Ochoa <felipe.nospam.ochoa@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 24896@debbugs.gnu.org,
Jackson Ray Hamilton <jackson@jacksonrayhamilton.com>
Subject: bug#24896: JSX prop indentation after fat arrow
Date: Fri, 6 Jan 2017 18:44:43 +0100 [thread overview]
Message-ID: <CAHp7JgiWfFyyzCS+93z+kOAqR+7q=VEeqhUQdscMooTeu23f=g@mail.gmail.com> (raw)
In-Reply-To: <447f307f-e226-e6a5-f62a-88bcdcda74df@yandex.ru>
[-- Attachment #1: Type: text/plain, Size: 1864 bytes --]
So I've thought about this some more, and realized that this won't fix
everything. There are still issues with greater-than and less-than as
binary operators. Maybe a better idea is to give '{' and '}' comment syntax
('<' and '>') so that SGML ignores all the bracketed JS stuff. I've been
trialing this with the following:
(defvar js-jsx-tag-syntax-table
(let ((table (make-syntax-table sgml-tag-syntax-table)))
(modify-syntax-entry ?\{ "<" table)
(modify-syntax-entry ?\} ">" table)
table))
(defun advice-js-jsx-indent-line (orig-fun)
(interactive)
(let ((sgml-tag-syntax-table js-jsx-tag-syntax-table))
(apply orig-fun nil)))
(advice-add 'js-jsx-indent-line :around 'advice-js-jsx-indent-line)
and have gotten good results so far. This works for js-mode and js2-mode.
If you're both happy with this approach, I'll convert the advice into a
patch for `js-jsx-indent-line' and will send along!
On Fri, Dec 9, 2016 at 1:18 AM, Dmitry Gutov <dgutov@yandex.ru> wrote:
> On 08.12.2016 13:12, Felipe Ochoa wrote:
>
> syntax-propertize-function is outside my limited knowledge of emacs
>> internals. But to the extent that one could say "Outside of comments and
>> strings, propertize `=>' as punctuation," I imagine that would fix it.
>>
>
> Yes, it can help with that.
>
> Also, this may be a dumb question, but are the tests in the "manual"
>> directory meant to be run manually? If not, how would I run the tests
>> there?
>>
>
> You can e.g. 'cd test/manual/indent' and run 'make js-jsx.js.test', to
> compare the indentation in js-jsx.js against what the current js.el does.
>
> And then finally, should I just email a patch with the proposed change &
>> tests for this?
>>
>
> An email with a diff attached could be enough.
>
> But if you wanted to include a "proper" commit message as well, see
> CONTRIBUTE in the top directory.
>
[-- Attachment #2: Type: text/html, Size: 2862 bytes --]
next prev parent reply other threads:[~2017-01-06 17:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 9:56 bug#24896: JSX prop indentation after fat arrow Felipe Ochoa
2016-11-19 22:47 ` Dmitry Gutov
2016-11-22 5:48 ` Jackson Ray Hamilton
[not found] ` <CAHp7JggpF+APETs=BaX-yJMrcX+u55NoXanj_krbfdD-78WRTw@mail.gmail.com>
2016-12-08 11:12 ` Felipe Ochoa
2016-12-09 0:18 ` Dmitry Gutov
2017-01-06 17:44 ` Felipe Ochoa [this message]
2017-01-15 2:04 ` Dmitry Gutov
2017-01-23 9:26 ` Felipe Ochoa
2017-01-23 17:07 ` Jackson Ray Hamilton
2017-01-25 1:59 ` Dmitry Gutov
2019-06-05 2:47 ` Jackson Ray Hamilton
2019-06-06 6:59 ` Jackson Ray Hamilton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp7JgiWfFyyzCS+93z+kOAqR+7q=VEeqhUQdscMooTeu23f=g@mail.gmail.com' \
--to=felipe.nospam.ochoa@gmail.com \
--cc=24896@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=jackson@jacksonrayhamilton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.