From: Felipe Ochoa <felipe.nospam.ochoa@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Disabling imenu default of thing-at-point
Date: Tue, 25 Jul 2017 11:05:24 +0200 [thread overview]
Message-ID: <CAHp7JghuhU8r+j_bjECQoZno81EeTjgY8ooimiKk_PdVL_zGsg@mail.gmail.com> (raw)
In-Reply-To: <CAHp7JgjpdXfqwhO+PcVqAFGMT8Sy271sRgDGQt6_eWTYnSiFaQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]
(Apologies, forgot to CC the list)
> Sounds like Ido (or Ido Ubiquitous) needs to be fixed. There
> should not be a problem with providing a default value, even
> when that default value might not always be helpful.
I think this could also be an option, but note that ido follows
completing-read-default in its handling of invalid defaults. E.g.,
evaluate the following and hit RET without selecting anything:
(completing-read-default
"Complete: " '("abc" "def" "ghi")
nil t nil nil "jkl")
The result will be "jkl".
One thing that cannot be fixed within ido (or completing-read)
is the prompt. Currently all users see "Index item (default %s): ",
even when the default is bogus, instead of "Index item: ".
> It breaks everyone's ability to pick up what was previously the
> default value as a default value.
>
> > - (setq name (or (imenu-find-default name prepared-index-alist)
name)))
> > + (setq name (imenu-find-default name prepared-index-alist)))
> > (cond (prompt)
> > ((and name (imenu--in-alist name prepared-index-alist))
> > (setq prompt (format "Index item (default %s): " name)))
>
> If you make that change then what is the sense of binding `name' to
> `(thing-at-point 'symbol)' in the first place? It's only purpose
> could then be to return a string so that `imenu-find-default' is
> used at all. This doesn't make any sense (to me).
The code does not do away with defaults. To me, the new approach
would mean in words:
1. Grab the symbol at point.
2. Check if it matches one of the items in the index.
3. If so, offer it as a default. Otherwise, ignore it.
[-- Attachment #2: Type: text/html, Size: 2356 bytes --]
next prev parent reply other threads:[~2017-07-25 9:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 17:10 Disabling imenu default of thing-at-point Felipe Ochoa
2017-07-24 17:39 ` Drew Adams
2017-07-24 17:43 ` Noam Postavsky
[not found] ` <CAHp7JggMsvE-A4GL2L1MdEceN4nnR9n3RGYjzpNgF2Zk1TRcjA@mail.gmail.com>
2017-07-25 9:01 ` Felipe Ochoa
[not found] ` <CAHp7JgjpdXfqwhO+PcVqAFGMT8Sy271sRgDGQt6_eWTYnSiFaQ@mail.gmail.com>
2017-07-25 9:05 ` Felipe Ochoa [this message]
2017-07-25 9:13 ` Felipe Ochoa
2017-07-25 9:21 ` Felipe Ochoa
2017-08-03 8:35 ` Felipe Ochoa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp7JghuhU8r+j_bjECQoZno81EeTjgY8ooimiKk_PdVL_zGsg@mail.gmail.com \
--to=felipe.nospam.ochoa@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.