From: Felipe Ochoa <felipe.nospam.ochoa@gmail.com>
To: 24896@debbugs.gnu.org
Subject: bug#24896: JSX prop indentation after fat arrow
Date: Mon, 7 Nov 2016 10:56:21 +0100 [thread overview]
Message-ID: <CAHp7JghTreecdWyBGsvj7o=O8m04r3b6iNQaxRcYY=Wk5TNFWw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]
(Preemptive apologies if this is the wrong list/format for this comment --
first time filer here!)
When indenting JSX code using js2- or js-mode, the indentation function
gets confused when there's a fat arrow function in a JSX prop. Compare the
way the following two code blocks are auto-indented:
const Component = props => ( // Incorrect indentation
<FatArrow a={e => c}
b={123}>
</FatArrow>
);
const Component = props => ( // Correct indentation
<NoFatArrow a={123}
b={123}>
</NoFatArrow>
);
I've tracked the problem down to `sgml-calculate-indent' using
`parse-partial-sexp' with `sgml-tag-syntax-table', where `>' is treated as
a close-parenthesis character (and thus the end-of-tag marker). I don't
think there's a way to patch the syntax table that would let `>' flip
between punctuation and close-parens based on context, but one possible fix
when using js2-mode (not sure about js-mode) is to apply a "."
'syntax-table text property to the `>' when parsing a fat arrow.
Unfortunately, `js-jsx-indent-line' calls `sgml-indent-line' using
`js--as-sgml', which sets `parse-sexp-lookup-properties' to nil.
Would there be any harm in setting `parse-sexp-lookup-properties' to t
instead? As far as I can tell, js-mode and js2-mode only use 'syntax-table
propeties for regex literals.
As a side-note, there may well be a different solution to this problem; I
still don't understand why the following block is indented correctly:
const Component = props => (
<WithRegex a={/>/}
b={123}>
</WithRegex>
);
[-- Attachment #2: Type: text/html, Size: 2475 bytes --]
next reply other threads:[~2016-11-07 9:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 9:56 Felipe Ochoa [this message]
2016-11-19 22:47 ` bug#24896: JSX prop indentation after fat arrow Dmitry Gutov
2016-11-22 5:48 ` Jackson Ray Hamilton
[not found] ` <CAHp7JggpF+APETs=BaX-yJMrcX+u55NoXanj_krbfdD-78WRTw@mail.gmail.com>
2016-12-08 11:12 ` Felipe Ochoa
2016-12-09 0:18 ` Dmitry Gutov
2017-01-06 17:44 ` Felipe Ochoa
2017-01-15 2:04 ` Dmitry Gutov
2017-01-23 9:26 ` Felipe Ochoa
2017-01-23 17:07 ` Jackson Ray Hamilton
2017-01-25 1:59 ` Dmitry Gutov
2019-06-05 2:47 ` Jackson Ray Hamilton
2019-06-06 6:59 ` Jackson Ray Hamilton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp7JghTreecdWyBGsvj7o=O8m04r3b6iNQaxRcYY=Wk5TNFWw@mail.gmail.com' \
--to=felipe.nospam.ochoa@gmail.com \
--cc=24896@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.