From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Matthias Newsgroups: gmane.emacs.bugs Subject: bug#74156: 29.4; Incorrect face with outline-minor-mode-highlight in lisp-mode Date: Sun, 3 Nov 2024 00:40:46 +0100 Message-ID: References: <865xp5o8x1.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15394"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74156@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 03 00:43:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7NmC-0003ro-7s for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Nov 2024 00:43:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7Nlp-0003A1-6x; Sat, 02 Nov 2024 19:43:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7Nln-00039o-7J for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2024 19:43:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t7Nlm-0002EY-OQ for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2024 19:43:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=IsJ10RI7VRW5nyrwV1tCbcy/tD57486N+JbX6zKAP8U=; b=mQ26eIBUgKbh7oxB0mczJBw7BTtgrrczmt6Vh6gg8UtXjWgXhhkAthc07sw4mYzj6WXp2YYgp181t+IDkDVCJisVPkhFvc9HL1ODL3Q4w9UOya3Fu/JNDoxd7NeqZyPCtFF/idB59+Ugyih7fYepa3AX8T04M3wd1c5wy8VFTAeKy9SSqe3yQuV0eLT/huEmGA1zjZjjey0KsrL8y/atUcv/9dzmDMpspclDy9M5Yqp7B6tsHumhzGMlw6O2DMdKchL66gIzVC19uqQLnqi6KfKnKA8QqqODnp6cera+2vLZVxQPF/D40W+VS+2UXXQW0aUkDv8C380ZK5uxOe6tjg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t7Nlm-0005ZM-J4 for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2024 19:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Matthias Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Nov 2024 23:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74156 X-GNU-PR-Package: emacs Original-Received: via spool by 74156-submit@debbugs.gnu.org id=B74156.173059092721378 (code B ref 74156); Sat, 02 Nov 2024 23:43:02 +0000 Original-Received: (at 74156) by debbugs.gnu.org; 2 Nov 2024 23:42:07 +0000 Original-Received: from localhost ([127.0.0.1]:56324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7Nks-0005Yk-UT for submit@debbugs.gnu.org; Sat, 02 Nov 2024 19:42:07 -0400 Original-Received: from mail-qt1-f181.google.com ([209.85.160.181]:56555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7Nkq-0005YI-QV for 74156@debbugs.gnu.org; Sat, 02 Nov 2024 19:42:06 -0400 Original-Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-460c316fc37so23199421cf.0 for <74156@debbugs.gnu.org>; Sat, 02 Nov 2024 16:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730590859; x=1731195659; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IsJ10RI7VRW5nyrwV1tCbcy/tD57486N+JbX6zKAP8U=; b=ABV5q/wxjgVXrBjQYPmWzRP0hce2of7urVh/Z2+g3S2fZtt0ILCGtva4Axkm2th4al 7Q4CFGApRqbnfiYmaIfRPvHejQUF6n13WYSFRmfaLXrqND9v6f1OBh4+FybF5f4TWgqN myvrpaA5lbfnL/jQzgQTUCBrzZ1Wb03OuqMY0gY6xiog7PLDGGegwRearPDJJ78iRBlT qSxmqLU6awetpC1tK1XzqVryyf/I35tNLTh7nq+pdNd72mw3To8quXTXWdtC8bWrWac6 T9dfZE4K5PYsksOAfQrBtLie7rJNhuiVrIu+7ZzcZsYRlYIzbMZtbr78Fl1rdPZiTrI4 xBug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730590859; x=1731195659; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IsJ10RI7VRW5nyrwV1tCbcy/tD57486N+JbX6zKAP8U=; b=Vmtq1i6kYdOPcxv/a2vE0kdnRDBIZ1sdLTiGR20HJ1QhwrET0FOAdn/ebF7Vj40se3 0ygM9O6K4ye04t+Fhi1pmDEM+6QW0x6wGV7s4yshd1Q5/k7mo1IPFSCWAbYvCezQ5Xqm 2vJnrXvx58Syr2H6p7liLjUN6exmiOzlX9gN6SFp6SFw/6NZiIWbSO2QTk8SgBNxEft9 1Au/tbKp/3AiBasnBWwF1SwrCBJsNbN5oshL97Fi+4CkAvoHxSFFbE51sRKWKLQTVBqi QEDZf4FE3Fp/ZWGkoP1K0g83t2Ha957Cs8km5zCuFrleL5IJcLolYYFR5vagYO9Bxr0/ Sx2Q== X-Gm-Message-State: AOJu0YxmagiSCF0z+AgKj6dhBVSmcNtoc/6q8uliFSPvbGkNhQx4kkVy EtWIQOwpLY0CrYPY12T72S/QJovdwVhMW1Q+5d9ZcAis1BAuzEz43A0K0d16GWRn7hdaVO9FaOX 2NwNUEpqw2ihv97Bj74m80QOMt+0= X-Google-Smtp-Source: AGHT+IFNWgVXoh8Fk9Km0JkAuCKB7FwNmFMkLFjKN0/tV6VQgjBQ0uR2pDbYKG4MnSOYGxJyhchcbdy2C47aKFh4/nM= X-Received: by 2002:ac8:7d13:0:b0:461:3834:b632 with SMTP id d75a77b69052e-4613bfc4d2amr400080891cf.1.1730590859216; Sat, 02 Nov 2024 16:40:59 -0700 (PDT) In-Reply-To: <865xp5o8x1.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294778 Archived-At: On Sat, Nov 2, 2024 at 6:16=E2=80=AFPM Juri Linkov wrote: > > > I guess this is due to the definition of outline-regexp in lisp-mode.el= : > > > > ";;;;* [^ \t\n]\\|(\\|\\(^;;;###\\(\\([-[:alnum:]]+?\\)-\\)?\\ > > (autoload\\)\\)" [...] > Isn't the face 'outline-8' because 'lisp-outline-level' returns > the level 1000 for the opening parenthesis in 'lisp-outline-level': > > (defun lisp-outline-level () > (let ((len (- (match-end 0) (match-beginning 0)))) > (cond ((or (looking-at-p "(") > (looking-at-p lisp-mode-autoload-regexp)) > 1000) AFAIU font-lock is using `outline-regexp` which triggers `outline-font-lock-face()` and eventually `lisp-outline-level()`. My naive approach was to modify `outline-regexp`, i.e. remove the opening parenthesis in the regexp. Then `outline-font-lock-face()` cannot be triggered by this regexp any more and thus won't override the faces of normal lisp code. The issue with this approach is: All commands that show, hide, or move to outline headings use `outline-regexp` as well. Thus these commands won't find headings starting with an opening parenthesis. I don't know how important this opening-parenthesis-rule is. Actually I don= 't need it. But I guess there were reasons to add it to the regexp. Andreas