From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Matthias Newsgroups: gmane.emacs.bugs Subject: bug#74156: 29.4; Incorrect face with outline-minor-mode-highlight in lisp-mode Date: Fri, 1 Nov 2024 14:11:54 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000007fc89f0625d9ae60" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5835"; mail-complaints-to="usenet@ciao.gmane.io" To: 74156@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 01 14:13:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t6rSo-0001NB-Vv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Nov 2024 14:13:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6rSb-0003pP-TB; Fri, 01 Nov 2024 09:13:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6rSZ-0003p1-DB for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2024 09:13:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6rSZ-00051e-4g for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2024 09:13:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:MIME-Version:To:Subject; bh=dN7JvTNvEM5mf6CWJbcOyKVjHhq+TBMTNZ1BURWy87M=; b=AsV/tCrYPBluagge3PNdj8YlcQqNVpZiv3iWjHBazYv3eGq/IcGXuANei0+Q6RAXi/B3Zjz8XiUEw+D0gFcnOoumQAzpBBIyMHc+2RWwifX+fpbC5eyiN8/slmMf+XPjN1qu/kuDfjl+xsXSibPf7KUldMwbN8iA2wHvWWqFwZbPaCwVAUupU27KA2KbIy4bwLscPgGCTNQWTUyl2r87l9drrFSmC/yB1OkrbjatEpyRCbI5Sl5w7MHNa2o0BMi+tnfwPZBHDymdCp9sm46FCjN4bjRSRO+f5LvVLRgl+coVJeIeXn+ICekBukoFvVgTe0VIUL8/mP/8UhJTkt/25A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6rSY-0000Qn-UD for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2024 09:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Matthias Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Nov 2024 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74156 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17304667331626 (code B ref -1); Fri, 01 Nov 2024 13:13:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Nov 2024 13:12:13 +0000 Original-Received: from localhost ([127.0.0.1]:49404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6rRk-0000QA-Ry for submit@debbugs.gnu.org; Fri, 01 Nov 2024 09:12:13 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:44568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6rRj-0000Q4-Ae for submit@debbugs.gnu.org; Fri, 01 Nov 2024 09:12:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6rRj-0003fZ-4O for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2024 09:12:11 -0400 Original-Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6rRg-0004x1-BW for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2024 09:12:10 -0400 Original-Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-460da5a39fdso11337391cf.1 for ; Fri, 01 Nov 2024 06:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730466726; x=1731071526; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=dN7JvTNvEM5mf6CWJbcOyKVjHhq+TBMTNZ1BURWy87M=; b=ewtZAG9ayN9uiaXqQaCSq2Coxa+VJiKOJssbPdYh4n8Ee8cT8ve4RTkTAHRF/cM063 ZHwM9AVvvRBOyTCvHUa5M4NxaVnILUhqQZYwPQ8rZaarCcOx2AvYKAy2XSdo73SfbcQY kP/Tp7hw2OfIibC2cjCo6ahNhBWqS6FLQmNNuAioBOOHmZk2se29kv1egxwLaaZz30LO MA1Q080hT71Deah/6zaFjRS1CpaeftUGDALdvP3CukytlRC17+mLq5BkIoJGKdEyTSNT CNCalSMJ2qlkxPeKTzI2m5GsbhT7u0fMDenTf9SIGZ+aBq3o3oHEpuFojHhGjk/GzFla ZQPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730466726; x=1731071526; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dN7JvTNvEM5mf6CWJbcOyKVjHhq+TBMTNZ1BURWy87M=; b=G39RLyQXpoE0tDa7PVUNM4mDA9YlLICQ/WHjOFg/+FzssrgWy7W/dVtFzlAoryIAfr f3Fydd4HXmEoUsupBC2rz42XNd1r7fgHmp/ldxsMxkv7gQZvMSaecSoawCk/nhziBWsC sB13QvMYjSEq3+MgMjAB2a1aM9tgioEImLRqGa4CXjTRlEj/T6ftv3iBZyEyNzFtGgA1 4JzF7iNf+tqy1P6zDFaizppuNXEuyJTx7it3chm1P7s+aacMz2fKkNAAcdTkNc+TLYW7 QdQnLHFNN+BAkJPWibXcI9dHDPqQxnoiv8hDrBa8DqkYYezXLFWaOIAAmzYsFP4EZuws S1kw== X-Gm-Message-State: AOJu0YyfP4JSjO2XYjYE20lW8caBbkrVcctDwSvFXLGDbwF+fSZgvFH3 6h5RsMgdP+JLBssBsbI9loCSZHINZ5KvEYPMb+pAVtazShSBsACclPNcQ08SteVcKkhGJc1f3NR JzdV7svaO7YS9LpVL4NXyjGxeZ5duQ6cz X-Google-Smtp-Source: AGHT+IF2D6GB+yHeCwYg5zq4Sj6dwVl7zD44nZmX+iCs8vCb9EaV8dp2lHEoLYJSIPQYzStlUhrVltibR1FRytRXIig= X-Received: by 2002:ac8:7d0f:0:b0:460:d105:c74b with SMTP id d75a77b69052e-4613bff9ce0mr356887091cf.14.1730466726002; Fri, 01 Nov 2024 06:12:06 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::835; envelope-from=andreas.matthias@gmail.com; helo=mail-qt1-x835.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294678 Archived-At: --0000000000007fc89f0625d9ae60 Content-Type: text/plain; charset="UTF-8" Take this example Elisp file: ;;; xxx -- OK: face is outline-1 ;;;; xxx -- OK: face is outline-2 (defun test ()) ; WRONG: face is outline-8 ;; Local Variables: ;; outline-minor-mode-highlight: override ;; eval: (outline-minor-mode 1) ;; End: After loading this file into Emacs you will see that the function definition is displayed incorrectly in face outline-8. I guess this is due to the definition of outline-regexp in lisp-mode.el: ";;;;* [^ \t\n]\\|(\\|\\(^;;;###\\(\\([-[:alnum:]]+?\\)-\\)?\\(autoload\\)\\)" Notice the opening parenthesis in the regular expression that causes the function definition to be recognized as an outline heading. I removed the opening parenthesis and now the face of the function definition is correct. This is fine for me. But note that you loose the ability to move to top-level expressions, like this function definition, with (outline-next-visible-heading) and (outline-previous-visible-heading). Andreas --0000000000007fc89f0625d9ae60 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Take this example Elisp file:


;;; xxx = -- OK: face is outline-1
;;;; xxx -- OK: face is outline-2
(defun tes= t ()) ; WRONG: face is outline-8

;; Local Variables:
;; outline-m= inor-mode-highlight: override
;; eval: (outline-minor-mode 1)
;; End:=


After loading this file into Emacs you will see that the functi= on definition
is displayed incorrectly in face outline-8.

I guess= this is due to the definition of outline-regexp in lisp-mode.el:

&q= uot;;;;;* [^ \t\n]\\|(\\|\\(^;;;###\\(\\([-[:alnum:]]+?\\)-\\)?\\(autoload\= \)\\)"

Notice the opening parenthesis in the regular expression= that causes
the function definition to be recognized as an outline head= ing.

I removed the opening parenthesis and now the face of the funct= ion definition
is correct. This is fine for me. But note that you loose = the ability to move
to top-level expressions, like this function definit= ion, with
(outline-next-visible-heading) and (outline-previous-visible-h= eading).


Andreas
--0000000000007fc89f0625d9ae60--