From: Christopher Cooper <christopher.c.cooper@gmail.com>
To: 22749@debbugs.gnu.org
Subject: bug#22749: 25.0.91; xwidget-webkit-scroll-down not working
Date: Thu, 10 Mar 2016 16:03:02 -0500 [thread overview]
Message-ID: <CAHorFciRsot-zMha8yGuV9ET1tV_hoWPJwuXmLdeSVsTBAFEsA@mail.gmail.com> (raw)
In-Reply-To: <874md3cyz1.fsf@acer.i-did-not-set--mail-host-address--so-tickle-me>
[-- Attachment #1.1: Type: text/plain, Size: 276 bytes --]
The problem was that 'xwidget-set-adjustment' in xwidget.c was checking
'value' using 'CHECK_NATNUM'. However, 'value' can be negative in the case
of relative scrolling. The solution is instead to use 'CHECK_NUMBER'. A
patch implementing this is attached.
Christopher Cooper
[-- Attachment #1.2: Type: text/html, Size: 348 bytes --]
[-- Attachment #2: 0001-Fix-Bug-22749.patch --]
[-- Type: text/x-patch, Size: 761 bytes --]
From a6268eb02f9a2ddd12cdac57f66a78419f2cf98c Mon Sep 17 00:00:00 2001
From: Christopher Cooper <christopher.c.cooper@gmail.com>
Date: Wed, 9 Mar 2016 17:40:25 -0500
Subject: [PATCH] Fix Bug#22749
* src/xwidget.c (xwidget-set-adjustment): Fix type check on value.
---
src/xwidget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/xwidget.c b/src/xwidget.c
index f436e95..bb15d1d 100644
--- a/src/xwidget.c
+++ b/src/xwidget.c
@@ -760,7 +760,7 @@ VALUE is the amount to scroll, either relatively or absolutely. */)
Lisp_Object value)
{
CHECK_XWIDGET (xwidget);
- CHECK_NATNUM (value);
+ CHECK_NUMBER (value);
struct xwidget *xw = XXWIDGET (xwidget);
GtkAdjustment *adjustment
= ((EQ (Qhorizontal, axis)
--
2.5.0
prev parent reply other threads:[~2016-03-10 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 13:06 bug#22749: 25.0.91; xwidget-webkit-scroll-down not working felix.dick
2016-03-09 22:52 ` bug#22749: Patch to fix Christopher Cooper
2016-03-10 21:03 ` Christopher Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHorFciRsot-zMha8yGuV9ET1tV_hoWPJwuXmLdeSVsTBAFEsA@mail.gmail.com \
--to=christopher.c.cooper@gmail.com \
--cc=22749@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.