From: "Rami Ylimäki" <rami.ylimaki@vincit.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH v2] Support 24-bit terminal colors.
Date: Mon, 13 Feb 2017 00:53:47 +0200 [thread overview]
Message-ID: <CAHmfpf9-2iEiw6nSKe17AwGsza7gvSGYY5WQEBesWvE-tvcy2w@mail.gmail.com> (raw)
In-Reply-To: <83tw7z16hv.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]
2017-02-12 22:47 GMT+02:00 Eli Zaretskii <eliz@gnu.org>:
>
> . Please prepare a NEWS entry for this feature.
> . It seems like you dropped the code to support the --color=
> command-line argument, which was part of your original submission?
> All the other color TTY modes support --color=NUM, so I think we
> should also support --color=16777216, and perhaps also --color-24bit.
>
I'll write the NEWS entry but I'm afraid that fixing the --color=NUM option
would require too much effort right now.
The manual is too optimistic when it states that "Emacs might be able to
turn on a color mode for 8, 16, 88, or 256 as the value of NUM". In
reality, only -1, 0 and 8 are supported. The 16, 88, and 256 color modes
can only be enabled based on current terminal capabilities and this is now
true for the 16M color mode as well.
The problems of handling --color=NUM can be seen when colors are
downgraded, because color and face pixel values aren't updated. For
example, "M-x list-faces-display" produces different results with
"TERM=xterm emacs -Q -nw --color=8" and "TERM=xterm-256color emacs -Q -nw
--color=8". This is why I'd like to treat the --color option as a separate
issue.
[-- Attachment #2: Type: text/html, Size: 1653 bytes --]
next prev parent reply other threads:[~2017-02-12 22:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 10:05 [PATCH v2] Support 24-bit terminal colors Rami Ylimäki
2017-02-12 10:05 ` [PATCH 1/3] Remove unused terminal color pair count Rami Ylimäki
2017-02-12 10:05 ` [PATCH 2/3] Support 24-bit terminal colors Rami Ylimäki
2017-02-12 10:05 ` [PATCH 3/3] Let user turn 24-bit terminal colors on Rami Ylimäki
2017-02-12 18:00 ` Filipe Silva
2017-02-12 19:27 ` Rami Ylimäki
2017-02-12 20:47 ` [PATCH v2] Support 24-bit terminal colors Eli Zaretskii
2017-02-12 22:53 ` Rami Ylimäki [this message]
2017-02-13 5:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmfpf9-2iEiw6nSKe17AwGsza7gvSGYY5WQEBesWvE-tvcy2w@mail.gmail.com \
--to=rami.ylimaki@vincit.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.