From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Guy Gastineau Newsgroups: gmane.emacs.erc.general,gmane.emacs.bugs Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer Date: Fri, 28 Jan 2022 22:13:41 -0500 Message-ID: References: <87ee4rutmo.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ea4e1c05d6aff051" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27428"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bug-gnu-emacs@gnu.org, emacs-erc@gnu.org To: "J.P." Original-X-From: emacs-erc-bounces+sf-erc-help=m.gmane-mx.org@gnu.org Sat Jan 29 04:14:11 2022 Return-path: Envelope-to: sf-erc-help@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDeBn-0006yK-Jd for sf-erc-help@m.gmane-mx.org; Sat, 29 Jan 2022 04:14:11 +0100 Original-Received: from localhost ([::1]:56654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDeBl-0001HQ-Q3 for sf-erc-help@m.gmane-mx.org; Fri, 28 Jan 2022 22:14:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDeBh-0001GL-BS; Fri, 28 Jan 2022 22:14:06 -0500 Original-Received: from [2a00:1450:4864:20::133] (port=40536 helo=mail-lf1-x133.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDeBc-0004Ri-9S; Fri, 28 Jan 2022 22:14:04 -0500 Original-Received: by mail-lf1-x133.google.com with SMTP id a28so15466822lfl.7; Fri, 28 Jan 2022 19:13:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9gBNRNOiM2HDTLukerGHktsRPmRbCcc0p8rSehnyM4A=; b=aX81znCx8I4mSw5DX7xZUZYLuYcgbGV9pQsbls4X5czwQa28qWnZN5bXxn4UlQZsGn QxSjrUgVADAHc36NL1RQXAPds/MPwb0Iw7Yh3KvvfPbVRdCS1CSzSPNMwALrf1g4gVU8 hpCcQQoXUgBZQ7tl5SY4oJ2blrdunKVYNLTGZIOr2sVBMgFhbP4rEdZ1vNNt1If32Q4T cB0c5e/5rxboO93szLe+p/uTM6SI/f4SYfkysn1HYXy6FpLzHlPagZmhJ097QyFQjSpM iPJFVA/ZPAlPgydv0ZCxGj9ZR35fW1o1rvLeE329uJG2KLVQbP0cM+wZ5678SDx8HT4g slkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9gBNRNOiM2HDTLukerGHktsRPmRbCcc0p8rSehnyM4A=; b=GmoSf2kyXH4g1FnHhf5fz1GoUWe5Nl79kvKnlOlnHwJh9c1vbk6/Hy8utVYStCyucz ZE0d9RKOMlYda11rieD7kgT5MSMWjz4sLI52O0BBABImvGE7wuzuXfMkWRWM2ujPQ8rz Up7GDUrcerWOWcSwFopN2FWvoDTK9Grug+8yqEhLMBnCLHvKR0K9iBV2eJFJRhw/OG7C cwWmeab0q8NL6wQJ1RrfIJgFLXY21WnmKXzebv/qo+gBaU16xRFoXfeE1mU9XU6vkh4w 33iRIb3uHvCE16ZCWbytwtbpQUwjbsPvd1mYjV+MYvfnhoO+P0QRT/oqKnSaeB5BBDSM zZCg== X-Gm-Message-State: AOAM532ESrDSFE6wi3CJHRJYqey7KMU78MQh2rFmPqjDvWIfHzEi25Xp 4VbJ+drpqcTBnpnNv2lEdlGCw17E4CAHtgqiVGnISB1G X-Google-Smtp-Source: ABdhPJxgiNfylLm1mk/scgfIHCWc66IVD1/X0JTAa6z8aYTzIFd7XdiuEZTLkSkLSb2j06ok/TqW0uUzuqQ3B64Ojvg= X-Received: by 2002:a05:6512:1599:: with SMTP id bp25mr8020524lfb.678.1643426033060; Fri, 28 Jan 2022 19:13:53 -0800 (PST) In-Reply-To: <87ee4rutmo.fsf@neverwas.me> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::133 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::133; envelope-from=strings.stringsandstrings@gmail.com; helo=mail-lf1-x133.google.com X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-erc@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: General discussion about ERC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-erc-bounces+sf-erc-help=m.gmane-mx.org@gnu.org Original-Sender: "emacs-erc" Xref: news.gmane.io gmane.emacs.erc.general:1707 gmane.emacs.bugs:225502 Archived-At: --000000000000ea4e1c05d6aff051 Content-Type: text/plain; charset="UTF-8" Sure. I will do it. The emacs bug report buffer provided access to a help page. It suggested I make a patch with `diff -u`. Is it preferable to provide a patch as made with git? On Fri, Jan 28, 2022, 10:07 PM J.P. wrote: > Hi Guy, > > Thanks for following through with the report. > > Guy Gastineau writes: > > > The entire sexp starting with `with-current-buffer ...` can be removed > > without changing the semantics of erc--switch-to-buffer. > > You're right, of course. In fact, the same commit that introduced > `erc--buffer-p' added the redundancy as well [1]. It looks like they saw > an opportunity to factor out that predicate and simply forgot to erase > the last of what they'd just obsoleted. > > Are you sure you're not into cloning the repo and saving out a patch? No > worries if not. This is great regardless. > > Thanks again, > J.P. > > > [1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f925fc93 > --000000000000ea4e1c05d6aff051 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sure. I will do it.=C2=A0 The emacs bug report buffer pro= vided access to a help page.=C2=A0 It suggested I make a patch with `diff -= u`.=C2=A0 Is it preferable to provide a patch as made with git?

On Fri, Jan = 28, 2022, 10:07 PM J.P. <jp@neverwas.m= e> wrote:
Hi Guy,

Thanks for following through with the report.

Guy Gastineau <strings.stringsandstrings@gmail.com&= gt; writes:

> The entire sexp starting with `with-current-buffer ...` can be removed=
> without changing the semantics of erc--switch-to-buffer.

You're right, of course. In fact, the same commit that introduced
`erc--buffer-p' added the redundancy as well [1]. It looks like they sa= w
an opportunity to factor out that predicate and simply forgot to erase
the last of what they'd just obsoleted.

Are you sure you're not into cloning the repo and saving out a patch? N= o
worries if not. This is great regardless.

Thanks again,
J.P.


[1] https://git.savannah= .gnu.org/cgit/emacs.git/commit/?id=3Df925fc93
--000000000000ea4e1c05d6aff051--