From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gilles Newsgroups: gmane.emacs.bugs Subject: bug#47439: 27.2; In daemon mode, if after-init-hook errors out, the server does not start Date: Sun, 28 Mar 2021 19:04:44 +0200 Message-ID: References: <87czvjs7pq.fsf@gnus.org> <83zgynml0n.fsf@gnu.org> <87sg4fqqxn.fsf@gnus.org> <83sg4fmios.fsf@gnu.org> <87k0prqqck.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18951"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47439@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 28 19:06:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQYro-0004qQ-1a for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 19:06:24 +0200 Original-Received: from localhost ([::1]:32942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQYrn-0006y2-3S for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 13:06:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQYrS-0006wl-LL for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 13:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQYrS-0008CS-B3 for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 13:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQYrS-0001qE-4D for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 13:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gilles Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Mar 2021 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47439 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 47439-submit@debbugs.gnu.org id=B47439.16169511297020 (code B ref 47439); Sun, 28 Mar 2021 17:06:02 +0000 Original-Received: (at 47439) by debbugs.gnu.org; 28 Mar 2021 17:05:29 +0000 Original-Received: from localhost ([127.0.0.1]:46925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQYqv-0001pA-2d for submit@debbugs.gnu.org; Sun, 28 Mar 2021 13:05:29 -0400 Original-Received: from mail-qk1-f172.google.com ([209.85.222.172]:41931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQYqs-0001ox-0V for 47439@debbugs.gnu.org; Sun, 28 Mar 2021 13:05:27 -0400 Original-Received: by mail-qk1-f172.google.com with SMTP id v70so10297645qkb.8 for <47439@debbugs.gnu.org>; Sun, 28 Mar 2021 10:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g/TVZtqp6Q1cqZzniT7UpePRpLOtCEnriGwJW5pd86s=; b=X4lG5z7My1uhKBSOtxl6wUuuMSUKSG2vmt4rFr1UtLHSh2yQo8FkGo+6PKgxhydL6f 7pgiFe27NwR78LeZ/sK1RykWIprsCIxEcepS22e8bCEU0S0dWyqXFfG4gx+82Da2vRRJ Z07Hc2x7Tt/D+POhePcrmZgauJxxq2+UNCgvzzMQop6YjpsCkmv/rdHwWpx76lyAsbr7 EXcxBh6mymie3Y09Aa0uU1a1yRjkUBnqy2Lbe/HEsgJaGWcGMhC2g1de0du1lH5AEd7/ Z3XqtdQjjZW9Pgdzw5IPXXfODbyT0vGlVtrjRFhSfJaYd0i40uTJ2snP8V0jhzIq11xV GEWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g/TVZtqp6Q1cqZzniT7UpePRpLOtCEnriGwJW5pd86s=; b=cbtnr8lbt/g6K8RaURh0X5mrPgHTAaeQvbm/r/e5QS3nPz6KFRkdYK5m9g46tMFzpW HkgF0R4P3jv5qjJumQ1NVAzqB3NUfZiJ30R4AXRA++TGo/ILuxBJJgGQQOPJzr+GBQpE J+v0jlo0jKicdoEr5MA8z8ScLl00/x4/YmkAOWrb1qha6f2BkoYkTsMDkHSO3dSEPJ3T eBcGmt4imjoqjWywJl1w3OyAQm5YfsUMpQc6aGU24/STnR8GKF2svRLJ3z2nPSdICm4O mTwbZ5ZuijK0mPUfqA1LY/ct/+57Ho1va35ReDOnUUficlo4GCBDjUQDqOgn6LxNGBLu D+rg== X-Gm-Message-State: AOAM5322nob2sWsQ1xPqXBVhgvsjIqmMlpQJc1FdZN7SeiiroelSoeZi CFAvucuZx4z25tbQxdkSvcU9sSuC+1+XDVyjQ2Y= X-Google-Smtp-Source: ABdhPJypVo2MrOZla2uG35c6i0V4WSkLJv10YunYJPrpa6toOhGpR2P2yBrbdi2zuSeIpsTWmAl7TE94pg9K9ZWTdB8= X-Received: by 2002:ae9:f80b:: with SMTP id x11mr21787010qkh.220.1616951120499; Sun, 28 Mar 2021 10:05:20 -0700 (PDT) In-Reply-To: <87k0prqqck.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203193 Archived-At: Looking at the code in startup.el, I think it would be ok to let errors go uncaught (it would avoid any complication to debug those errors), but the daemon should start anyway. How about putting most of command-line in an unwind-protect? Or moving the daemon start outside the unwind-protect in normal-top-level? -- Gilles On Sun, 28 Mar 2021 at 16:56, Lars Ingebrigtsen wrote: > > Eli Zaretskii writes: > > > You mean, catching the error if we are starting the daemon? that's one > > possibility, assuming that the error message will then be visible when > > the first client connects. > > > > In non-daemon mode I think we should keep not catching errors. > > Yup, and yup. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no