From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: brickviking Newsgroups: gmane.emacs.bugs Subject: bug#65277: 29.1.50; emacsclient Dired: frame is closed/killed when opening another dir Date: Mon, 28 Aug 2023 13:09:12 +1200 Message-ID: References: <87350mpkho.fsf@gmail.com> <83ttsy57g0.fsf@gnu.org> <831qg15w7b.fsf@gnu.org> <83cyzk4x0y.fsf@gnu.org> <83bkf44klh.fsf@gnu.org> <83edjz1o2f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000cece610603f159d3" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25455"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65277-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 28 03:11:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qaQmZ-0006S5-Uf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Aug 2023 03:11:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qaQmP-00032h-Je; Sun, 27 Aug 2023 21:10:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaQmO-00032H-D3 for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2023 21:10:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qaQmO-0003Mn-4S for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2023 21:10:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qaQmT-0005a3-Oa for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2023 21:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: brickviking Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Aug 2023 01:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65277 X-GNU-PR-Package: emacs Original-Received: via spool by 65277-done@debbugs.gnu.org id=D65277.169318500721383 (code D ref 65277); Mon, 28 Aug 2023 01:11:01 +0000 Original-Received: (at 65277-done) by debbugs.gnu.org; 28 Aug 2023 01:10:07 +0000 Original-Received: from localhost ([127.0.0.1]:46441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaQlb-0005Yo-1E for submit@debbugs.gnu.org; Sun, 27 Aug 2023 21:10:07 -0400 Original-Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:48615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaQlV-0005YC-Vm for 65277-done@debbugs.gnu.org; Sun, 27 Aug 2023 21:10:05 -0400 Original-Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4ffae5bdc9aso4235889e87.1 for <65277-done@debbugs.gnu.org>; Sun, 27 Aug 2023 18:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693184989; x=1693789789; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kV9FyMJyrQ+JIoPIOppUiI8RiECLG4kCBihqJyy6XxQ=; b=Z26BoXpUPz9IaiZ00NZSj2biw4mog0qe0jBhbj/np8HiZ4lIU3A1TksxQGVJwka/5w d4pwWd3rJbpnPSmAo2ll17jB4LkdLeBvBYsZ2XRXHrD6HjA0/7EL7SPWwcXrkYEd0B8r v13ZJ5dgSvS7j7C+UVRpXgVBdPS9SMVBSYAst1Wq8XFwAYU88wccLuSUnLCP4ha63U10 QRDwkIfpRKNHRkCmtHAN6zOh8KfEfR2RF+0OF4m4MMOkCE/pFOitp5N9UvDV2nxSObqY WA2YmgUbc5XXgP1hSN1uHWfXPAGrNdSjB5OtiwuykUsmOPkRY1j3yWzqsfXI1iNrOVAr wsXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693184989; x=1693789789; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kV9FyMJyrQ+JIoPIOppUiI8RiECLG4kCBihqJyy6XxQ=; b=cCorfkCHbJWrxPEnn8WXGWsNtMSMKcrqMyyP3l6JbIb88DAKA0EOnWVWLJUZ1O5yW7 FE+dbeQyyDHCBCRylcs+t5ah5eLaPaPi+lG2u0IFUl+vWSGj4aFTrEQU77iCN3xs87dU UD+CbgLRtuq8JDNt/kX8pLuWdPmuxYWWhzotCNVav5hCTMSaj/mUTjXd9wLfWSozQCIz nrXLBjjGB5c1E716zy+aRPnDoIZkLr0M/Rd52UCM122pdJPRa4AtIIh9MWrIdXIUdj4m 4uJa9aAm2GtgL+xPlyASVfhhsTBKUt1Z4MufdAzJEniKX37ZIxC1VPyAYc3YVah69hRn wakg== X-Gm-Message-State: AOJu0YxG48Bk1pH820eWFf1oloT4PzEQbbbJJBUcCeATTgSXb6SBHC5x x3+9Ix+diU+lToOCQsvUsPfoBQ2lJ0Z2HQ8kxhw= X-Google-Smtp-Source: AGHT+IFpLM1AZhIK5ikhH+GP3fbkfK8yr+kd+v6rWTSN+SkLA+be+Lm9buTuw04YPlvZpudC4iPnijJOD7gVEzRCD2I= X-Received: by 2002:a05:6512:32cf:b0:4fe:2d93:2b51 with SMTP id f15-20020a05651232cf00b004fe2d932b51mr18706682lfg.27.1693184988989; Sun, 27 Aug 2023 18:09:48 -0700 (PDT) In-Reply-To: <83edjz1o2f.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268599 Archived-At: --000000000000cece610603f159d3 Content-Type: text/plain; charset="UTF-8" One more thing, as it's now fixed in master, would it be a good idea to push this to the emacs-29 branch as well? I seem to have gathered a tiny patch file that I apply each time that includes this, and I'd like to trim down my patch file. Sorry it's taken so long (*) to get to it, I literally haven't thought about it until now. (*) regarding your conversation on another topic about release cadences. Regards, brickviking On Sat, 19 Aug 2023 at 19:35, Eli Zaretskii wrote: > > From: brickviking > > Date: Sat, 19 Aug 2023 12:51:13 +1200 > > Cc: 65277@debbugs.gnu.org > > > > Yes, sorry about that. I missed an error when retrieving the patch from > the email. This altered the > > patch so that one of the hunks didn't succeed (I missed an initial space > off the bottom comment line > > of the patch). > > > > I've corrected the patch on my end and done some more testing. > Configured, patched, compiled and > > installed. > > > > ---- text ---- > > shell1$ emacs -Q > > > > M-x server-mode > > Starts as per normal, window stays up. > > > > shell2$ emacsclient -t GNUmakefile > > > > This opens a text window with the contents of GNUmakefile. > > C-x C-v INSTALL > > INSTALL now opens in the buffer, and I can use it as normal. Trying to > > shut the client down with C-x # results in the message > > "No server buffers remain to edit" > > (not client buffers as you said will happen) so I just did C-x 5 0 to > terminate the client. > > > > ---- GUI ---- > > Starting up a GUI client with emacsclient -c GNUmakefile shows that file > in the window. > > C-x C-v INSTALL > > then shows the install file, and crucially, the terminal doesn't return > to the shell prompt. I still see > > "Waiting for Emacs..." in the terminal until I exit the client window. > > > > At least on my end, this appears to work as advertised. > > Thanks. So I've now installed the fix on the master branch, and I'm > closing this bug. > --000000000000cece610603f159d3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
One more thing, as it's now fixed in master, would it = be a good idea to push this to the emacs-29 branch as well? I seem to have = gathered a tiny patch file that I apply each time that includes this, and I= 'd like to trim down my patch file. Sorry it's taken so long (*) to= get to it, I literally haven't thought about it until now.

(*) regarding your conversation on another topic about release cade= nces.

Regards, brickviking


On = Sat, 19 Aug 2023 at 19:35, Eli Zaretskii <eliz@gnu.org> wrote:
> From: brickviking <brickviking@gmail.com>
> Date: Sat, 19 Aug 2023 12:51:13 +1200
> Cc: 65277@d= ebbugs.gnu.org
>
> Yes, sorry about that. I missed an error when retrieving the patch fro= m the email. This altered the
> patch so that one of the hunks didn't succeed (I missed an initial= space off the bottom comment line
> of the patch).
>
> I've corrected the patch on my end and done some more testing. Con= figured, patched, compiled and
> installed.
>
> ---- text ----
>=C2=A0 =C2=A0 =C2=A0shell1$ emacs -Q
>
>=C2=A0 =C2=A0 =C2=A0M-x server-mode
> Starts as per normal, window stays up.
>
>=C2=A0 =C2=A0 =C2=A0shell2$ emacsclient -t GNUmakefile
>
> This opens a text window with the contents of GNUmakefile.
>=C2=A0 =C2=A0 =C2=A0C-x C-v INSTALL
> INSTALL now opens in the buffer, and I can use it as normal. Trying to=
> shut the client down with C-x # results in the message
>=C2=A0 =C2=A0 =C2=A0"No server buffers remain to edit"
> (not client buffers as you said will happen) so I just did C-x 5 0 to = terminate the client.
>
> ---- GUI ----
> Starting up a GUI client with emacsclient -c GNUmakefile shows that fi= le in the window.
>=C2=A0 =C2=A0 =C2=A0C-x C-v INSTALL
> then shows the install file, and crucially, the terminal doesn't r= eturn to the shell prompt. I still see
> "Waiting for Emacs..." in the terminal until I exit the clie= nt window.
>
> At least on my end, this appears to work as advertised.

Thanks.=C2=A0 So I've now installed the fix on the master branch, and I= 'm
closing this bug.
--000000000000cece610603f159d3--