One more thing, as it's now fixed in master, would it be a good idea to
push this to the emacs-29 branch as well? I seem to have gathered a tiny
patch file that I apply each time that includes this, and I'd like to trim
down my patch file. Sorry it's taken so long (*) to get to it, I literally
haven't thought about it until now.

(*) regarding your conversation on another topic about release cadences.

Regards, brickviking


On Sat, 19 Aug 2023 at 19:35, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: brickviking <brickviking@gmail.com>
> > Date: Sat, 19 Aug 2023 12:51:13 +1200
> > Cc: 65277@debbugs.gnu.org
> >
> > Yes, sorry about that. I missed an error when retrieving the patch from
> the email. This altered the
> > patch so that one of the hunks didn't succeed (I missed an initial space
> off the bottom comment line
> > of the patch).
> >
> > I've corrected the patch on my end and done some more testing.
> Configured, patched, compiled and
> > installed.
> >
> > ---- text ----
> >     shell1$ emacs -Q
> >
> >     M-x server-mode
> > Starts as per normal, window stays up.
> >
> >     shell2$ emacsclient -t GNUmakefile
> >
> > This opens a text window with the contents of GNUmakefile.
> >     C-x C-v INSTALL
> > INSTALL now opens in the buffer, and I can use it as normal. Trying to
> > shut the client down with C-x # results in the message
> >     "No server buffers remain to edit"
> > (not client buffers as you said will happen) so I just did C-x 5 0 to
> terminate the client.
> >
> > ---- GUI ----
> > Starting up a GUI client with emacsclient -c GNUmakefile shows that file
> in the window.
> >     C-x C-v INSTALL
> > then shows the install file, and crucially, the terminal doesn't return
> to the shell prompt. I still see
> > "Waiting for Emacs..." in the terminal until I exit the client window.
> >
> > At least on my end, this appears to work as advertised.
>
> Thanks.  So I've now installed the fix on the master branch, and I'm
> closing this bug.
>