From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: brickviking Newsgroups: gmane.emacs.bugs Subject: bug#65277: 29.1.50; emacsclient Dired: frame is closed/killed when opening another dir Date: Sat, 19 Aug 2023 12:51:13 +1200 Message-ID: References: <87350mpkho.fsf@gmail.com> <83ttsy57g0.fsf@gnu.org> <831qg15w7b.fsf@gnu.org> <83cyzk4x0y.fsf@gnu.org> <83bkf44klh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000f7fee206033c0cb1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13720"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65277@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 19 02:52:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXACN-0003La-Nc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Aug 2023 02:52:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXACB-0007KL-Mp; Fri, 18 Aug 2023 20:52:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXACA-0007KC-BB for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 20:52:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXAC9-0004m6-EP for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 20:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXACA-0005Ge-3e for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 20:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: brickviking Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 00:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65277 X-GNU-PR-Package: emacs Original-Received: via spool by 65277-submit@debbugs.gnu.org id=B65277.169240632120241 (code B ref 65277); Sat, 19 Aug 2023 00:52:02 +0000 Original-Received: (at 65277) by debbugs.gnu.org; 19 Aug 2023 00:52:01 +0000 Original-Received: from localhost ([127.0.0.1]:49053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXAC8-0005GP-M9 for submit@debbugs.gnu.org; Fri, 18 Aug 2023 20:52:01 -0400 Original-Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:57492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXAC6-0005GB-6o for 65277@debbugs.gnu.org; Fri, 18 Aug 2023 20:51:58 -0400 Original-Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2bba6fc4339so22968841fa.2 for <65277@debbugs.gnu.org>; Fri, 18 Aug 2023 17:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692406311; x=1693011111; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=t7NtfbjgYao9yC2BoWLpfO2RrGF9Q5+x8zkDl7YxB/g=; b=AX2zBXzK7rZTxzOrGx17AraStGwwNP+oOB6PNC/HmiO4kIrbAuPza9pmBrM18E4tb/ meIqqlWC9hm8QlBGT4h2xNfY5kWqpPvkbpuHVVs2hBxO0gY4OZHozj9dHVD0gQVLuuSx NS4W8AIPrj7B246ZlS7CexNpyk/JEgYWvlTYYNRxwny1fMZG0CngQOSNG0WEmx4TJm/3 K14zhotv2pwLYWSdyT6YrKjuzaDU/q1QeMHEJkDH0bP7Xotphzuo5Pv6gvGU/YF21Iog aErAGC90cEZy6zgp574AEZSjrp6SJ8l/ykgbLi3qh8HtIrjAYxVIwC4vPvgoXX049VMH nbIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692406311; x=1693011111; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t7NtfbjgYao9yC2BoWLpfO2RrGF9Q5+x8zkDl7YxB/g=; b=WHirbyWSn0bdy3S2buhiZRvqk3cy5B85g/Q6iotQExZbVdEbODlQi3hpaFjR2ZXr3B pIBjLWwxwgDg1ORBJzP9ZTRUPihikqQ2YYD5MnEMl+1LzTrPpTA9HMJY2DxN+xm4zjsD UFQgH1I0fMwXF3ln3KDsCcI1fHpnknAB/GTEbYl/qvVaW1H3BdGVD84OGTS6pAGPFleY rSPud6NFhmTdnNiIXWfz9USyb1c3Q+d2HZKY9zV8cGaMkdJ3yx2L6Qfr9ILcifwW1ygj 0q89LtntNGoXKMLMtj+pCLC+EgKTC8M74rGDegK/GWZtklgFLmJbSahZJzP9mR1RaMJ5 vivQ== X-Gm-Message-State: AOJu0YwCGH4XvQL3DmjAwKpcc71BU1tox7QPP9w6yK8SwWF/BYoK8TKw bjVa5ey7nVs6aU+xf7yknK+IIEOjqJNHBiFIwSE= X-Google-Smtp-Source: AGHT+IE/6PAuXZaobkDH6gKX9WsWhukosmPh9fTuhF36IO/H3avaq4V5ewvZ4UKaI6uZzsK2afmmiiGcCJ67Ukcgsfw= X-Received: by 2002:a05:6512:340c:b0:4fd:d481:ff35 with SMTP id i12-20020a056512340c00b004fdd481ff35mr445213lfr.42.1692406310762; Fri, 18 Aug 2023 17:51:50 -0700 (PDT) In-Reply-To: <83bkf44klh.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267801 Archived-At: --000000000000f7fee206033c0cb1 Content-Type: text/plain; charset="UTF-8" Yes, sorry about that. I missed an error when retrieving the patch from the email. This altered the patch so that one of the hunks didn't succeed (I missed an initial space off the bottom comment line of the patch). I've corrected the patch on my end and done some more testing. Configured, patched, compiled and installed. ---- text ---- shell1$ emacs -Q M-x server-mode Starts as per normal, window stays up. shell2$ emacsclient -t GNUmakefile This opens a text window with the contents of GNUmakefile. C-x C-v INSTALL INSTALL now opens in the buffer, and I can use it as normal. Trying to shut the client down with C-x # results in the message "No server buffers remain to edit" (not client buffers as you said will happen) so I just did C-x 5 0 to terminate the client. ---- GUI ---- Starting up a GUI client with emacsclient -c GNUmakefile shows that file in the window. C-x C-v INSTALL then shows the install file, and crucially, the terminal doesn't return to the shell prompt. I still see "Waiting for Emacs..." in the terminal until I exit the client window. At least on my end, this appears to work as advertised. Regards, brickviking On Sat, 19 Aug 2023 at 00:10, Eli Zaretskii wrote: > > From: brickviking > > Date: Fri, 18 Aug 2023 20:22:24 +1200 > > > > Okay. Patch applied, compiled, installed, executed emacs from shell1. > > ----- text ----- > > shell1$ emacs -Q > > I started server: M-x server-start. Window stays up. > > > > shell2$ emacsclient -t GNUmakefile > > It then opens with contents of GNUmakefile. > > > > I then go C-x C-v INSTALL, hit enter, and get returned back to the > prompt. > > That's not what I see here. I see INSTALL, and I don't get back to > the prompt. If you indeed compiled the latest patch, this is strange. > > > The behaviour differs for the GUI client in that I open emacsclient -C > GNUmakefile after starting the > > server, and GNUmakefile shows in the window. > > When I go C-x C-v INSTALL the emacsclient window closes (and > returns me to a prompt), > > and the INSTALL appears in a buffer in the original server window. > > That's also not what I see. > > I suspect you used one of the previous patches, or maybe didn't > install the patch correctly. > > Thanks. > --000000000000f7fee206033c0cb1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, sorry about that. I missed an error when retrieving t= he patch from the email. This altered the patch so that one of the hunks di= dn't succeed (I missed an initial space off the bottom comment line of = the patch).

I've corrected the patch on my end and done some mor= e testing. Configured, patched, compiled and installed.

---- text --= --
=C2=A0 =C2=A0 shell1$ emacs -Q

=C2=A0 =C2=A0 M-x server-modeStarts as per normal, window stays up.

=C2=A0 =C2=A0 shell2$ emacs= client -t GNUmakefile

This opens a text window with the contents of = GNUmakefile.=C2=A0
=C2=A0 =C2=A0 C-x C-v INSTALL
INSTALL now opens i= n the buffer, and I can use it as normal. Trying to
shut the client down= with C-x # results in the message
=C2=A0 =C2=A0 "No server buffers= remain to edit"
(not client buffers as you said will happen= )=C2=A0so I just did C-x 5 0 to terminate the client.

---- GUI ----<= br>Starting up a GUI client with emacsclient -c GNUmakefile shows that file= in the window.=C2=A0
=C2=A0 =C2=A0 C-x C-v INSTALL
the= n shows the install file, and crucially, the terminal=C2=A0doesn't retu= rn to the shell prompt. I still see "Waiting for Emacs..." in the= terminal until I exit the client window.

At least on my end, this a= ppears to work as advertised.

Regards, brickviking


On S= at, 19 Aug 2023 at 00:10, Eli Zaretskii <eliz@gnu.org> wrote:
> From: brickviking <brickviking@gmail.com>
> Date: Fri, 18 Aug 2023 20:22:24 +1200
>
> Okay. Patch applied, compiled, installed, executed emacs from shell1.<= br> > ----- text -----
>=C2=A0 =C2=A0 =C2=A0shell1$ emacs -Q
> I started server: M-x server-start. Window stays up.
>
>=C2=A0 =C2=A0 =C2=A0shell2$ emacsclient -t GNUmakefile
> It then opens with contents of GNUmakefile.
>
> I then go C-x C-v INSTALL, hit enter, and get returned back to the pro= mpt.

That's not what I see here.=C2=A0 I see INSTALL, and I don't get ba= ck to
the prompt.=C2=A0 If you indeed compiled the latest patch, this is strange.=

> The behaviour differs for the GUI client in that I open emacsclient -C= GNUmakefile after starting the
> server, and GNUmakefile shows in the window.
> When I go C-x C-v INSTALL <RET> the emacsclient window closes (a= nd returns me to a prompt),
> and the INSTALL appears in a buffer in the original server window.

That's also not what I see.

I suspect you used one of the previous patches, or maybe didn't
install the patch correctly.

Thanks.
--000000000000f7fee206033c0cb1--