From: TOMAS FABRIZIO ORSI <torsi@fi.uba.ar>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: pbreton@cs.umb.edu, Eli Zaretskii <eliz@gnu.org>, 71438@debbugs.gnu.org
Subject: bug#71438: [PATCH] Allow ping to receive optional arguments
Date: Sun, 16 Jun 2024 23:03:23 -0300 [thread overview]
Message-ID: <CAHTSwYigyFoUYF_TBB4sY4g+Dt4L69hSdsujm04j9cPn9emDjA@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmmmCh6FUxaVM84=V5zLk3=Og8bCMDJydBC14p4_c46_Cw@mail.gmail.com>
Hello Stefan,
> Sorry for the late reply.
No worries Stefan! I'm glad you are taking the time to help me with the patch.
Thank you for all of the work you do!
> I think this patch (to be applied on top of yours) might provide a
> slighly better experience. I also made an attempt at improving the
> docstring. What do you think?
The docstring is greatly improved; without a doubt.
However, I've been thinking. Both my original patch and yours
ask the user for additional flags if *any* prefix argument is
passed.
Isn't that closing the door for further additions to this
function?
Maybe, it would be better if (for instance) "0" is passed
as a prefix argument.
In that way, if any other additions were to be made,
those could use a different prefix argument (1,2,3, and so on);
thus avoiding backwards incompatibility.
So, instead of using when/if; cond could be used.
What do you think?
Best regards,
- Fabrizio
next prev parent reply other threads:[~2024-06-17 2:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 15:28 bug#71438: [PATCH] Allow ping to receive optional arguments TOMAS FABRIZIO ORSI
2024-06-08 18:48 ` Peter Breton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 18:57 ` TOMAS FABRIZIO ORSI
2024-06-09 12:02 ` Stefan Kangas
2024-06-09 13:47 ` Eli Zaretskii
2024-06-09 15:03 ` TOMAS FABRIZIO ORSI
2024-06-09 15:21 ` Eli Zaretskii
2024-06-09 15:38 ` Stefan Kangas
2024-06-09 15:48 ` TOMAS FABRIZIO ORSI
2024-06-16 21:46 ` TOMAS FABRIZIO ORSI
2024-06-17 1:14 ` Stefan Kangas
2024-06-17 2:03 ` TOMAS FABRIZIO ORSI [this message]
2024-06-17 6:19 ` Stefan Kangas
2024-06-19 2:17 ` TOMAS FABRIZIO ORSI
2024-06-20 18:45 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHTSwYigyFoUYF_TBB4sY4g+Dt4L69hSdsujm04j9cPn9emDjA@mail.gmail.com \
--to=torsi@fi.uba.ar \
--cc=71438@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=pbreton@cs.umb.edu \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.