From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GPi9GDiwv2Tp/QAASxT56A (envelope-from ) for ; Tue, 25 Jul 2023 13:21:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AIGTGDiwv2SbhQAA9RJhRA (envelope-from ) for ; Tue, 25 Jul 2023 13:21:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1443551BE8 for ; Tue, 25 Jul 2023 13:21:28 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=FTCVzYch; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690284088; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VJHOz5MTuS11xWfUkqNurLdb49Z5aRq+ip/JxT3o88g=; b=LcBomGnztdHG06CsZdrh5YZj3F7zhaTC3MOlh8GQHdN46xfDATqHlthb89sOeMXUzWypRs kdsJuoJXUA/xzEdyReNYCkuu+MiS8sNSVBiU4p2EDTPlE76Y6mpRqvBKSEjOFv0Eavtp3f Z536agxpCtGjW010TzSMbvS8aoMqX+YRtTrgZiTipQehJCtrTYqM9GWFAcSS7gApoRUg1H Wrn6y+4cveIuSoEol6wEjVlmEVHQKwJna/tTKDVTz90LqcLJjNHw+IVs1btrtUrFH+hf0A yLXsFwpNoyU092/0k3w4aEOymzRuu1Ma2PFCEfT3hq5btFS+u8hshIo/iAFlpA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690284088; a=rsa-sha256; cv=none; b=koIx59ZYiSxRJGXxzMybePw1I195Tg8I4FUTbguJTih9rbn6gopRMjZQRFX+sil0XuC1/x IWRlyBOQioh2j6NT4nfpTOBOHst9ibkCJ+FVRi5C54kK6zanzLtSqM0Mx6eEbWTO9HvTgC ZKsLGzHKHOtGW1ZXYFnmwFPVSlkeDmdF1BkeAHCeoOTzoUBSTgjJWjyNkUXUflkQ8Pjn+c a0iy2BiqgTKQxLJ+bLd+ZrgOGPdDnofVMAWqzV+GruiiOYzQWnAhfbYgax1VSRfTJxI+te lXPZgk7d44vwywlaj575r0reVBbTOhaGW4Ym4Cz/34H1qkE/6GKMoLnotHOwug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=FTCVzYch; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOG5c-0005El-I9; Tue, 25 Jul 2023 07:20:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOG5a-0005DE-RK for emacs-orgmode@gnu.org; Tue, 25 Jul 2023 07:20:26 -0400 Received: from mail-yw1-x1134.google.com ([2607:f8b0:4864:20::1134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOG5Z-0003xI-0l for emacs-orgmode@gnu.org; Tue, 25 Jul 2023 07:20:26 -0400 Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-5768a7e3adbso94332817b3.0 for ; Tue, 25 Jul 2023 04:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690284023; x=1690888823; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VJHOz5MTuS11xWfUkqNurLdb49Z5aRq+ip/JxT3o88g=; b=FTCVzYchuoYH58DGsdBK3Z/WpoWWG2X6ejHGS3GYmX9+KC53bXQgs4mK/gXIQcatYa moBVGEnDp9RC6LPctSrSzCDLpVmu29iVXo/yyugTdvEKP9BS89tq+Jt4QJ58YZjhAGRS m2Gnfaf1tLecYUCT7A+gwxGi5QovSIWa4Vd/uUl41ohVEwgwIQK/QZ0c7PtiS2ycA56H g/zvL9+HPnpm5L/orHq244vWdPfITcXu8NpV7MjMzr8LOuxi6qmKyAoO9EplYtIiTJhu ZumQLSg99to+mhXWBfgRlk1an6vXbxONeyDZ3RBmJlQhRrUt9A5mNRYv2U/ABo6BFAFu QYvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690284023; x=1690888823; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VJHOz5MTuS11xWfUkqNurLdb49Z5aRq+ip/JxT3o88g=; b=c6v67HjpSMl0UZY6n9lDVmV2iban9d+8ACFsBEVLRa23bkBY//gZOQgFfEzO/tFp1C IB71l2QoqJEBrCFyYQRthTDpHQiM3TNi5k3HRcsVW+lVNZVlseViMGbjnfZfoiIp2pYt PTZc5MgLlRyA5U3cP9XhtNQCz3I2v8Rzsh+QBA8YwZHeyfIp1PPF99GH4hfOeMdoCeML 0PGPRItJHe2hbydIOp0EYY4RHF0rxVBGtdbSAbIMFdfTuz3CSNKa0vLTvif/k5HCMrcy s2u34dFSEffet3B0lcTVtS1j2MxHQsMwrrdbRdBfcchHM7q+GwgqdTk6Bb0Ggj85cwXj CA+Q== X-Gm-Message-State: ABy/qLb2CrUMDhpVxNGepSZnYY7rSjhjobkf934M/gu3SxJqLVMDTznA 2Xl6bc92mR8qm7NlOcXmWukTQ1nEZTv/VwDYgwCySO56wpk= X-Google-Smtp-Source: APBJJlHveuNmJBDnljJXgqgLQS7SRSMheJczZWwkECWkCcErMW9k/qB1xoEyx32xgBkQJCxEH1gWxcGCdr6B75SIBR4= X-Received: by 2002:a81:92d4:0:b0:56d:4d1e:74ab with SMTP id j203-20020a8192d4000000b0056d4d1e74abmr2004219ywg.23.1690284023118; Tue, 25 Jul 2023 04:20:23 -0700 (PDT) MIME-Version: 1.0 References: <87r0rxv3t5.fsf@localhost> <87lei577g4.fsf@gmail.com> <87lei5v1fg.fsf@localhost> <87fs8duyae.fsf@localhost> <8735451u20.fsf@gmail.com> <874jokbjsk.fsf@localhost> <87zg6ch2dm.fsf@gmail.com> <87sfc4a0ce.fsf@localhost> <87r0ro9mzc.fsf@gmail.com> <87zg69zq49.fsf@localhost> <87r0rg1lwe.fsf@gmail.com> <87leho3y0n.fsf@localhost> <87a5y3vzpe.fsf@gmail.com> <87jzx6ylrm.fsf@localhost> <87ttw8kd9u.fsf@gmail.com> <87fs5ppcx7.fsf@localhost> <875y6hwqqe.fsf@localhost> <87o7k48jcf.fsf@localhost> In-Reply-To: <87o7k48jcf.fsf@localhost> From: Mehmet Tekman Date: Tue, 25 Jul 2023 13:19:46 +0200 Message-ID: Subject: Re: [ANN] lisp/ob-tangle-sync.el To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::1134; envelope-from=mtekman89@gmail.com; helo=mail-yw1-x1134.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -9.46 X-Spam-Score: -9.46 X-Migadu-Queue-Id: 1443551BE8 X-TUID: kemogpXqJ9rq Ihor Radchenko writes: > Another meetup is on July 26. https://emacs-berlin.org/ > Or we can arrange a jitsi call. Sure, I can be there tomorrow! > To name them, you can use separate ert-deftest statements. Oh sure, but I don't want to clutter the library. > Also, see the attached modified version of your diff - I made it so > that `should' failures immediately provide some clue about expected > result value, that can help to identify which of the should clauses > fails. Ah nice, much appreciated thank you. I was hesitant to split out the main testing function (previously called by `funcall') into its own function out of the same fears as above, but I see now it's not the only one. > The tests are indeed not passing on vanilla Org. I assume that you > tested them with your other patch applied. I tested them on upstream/main... or so I thought, though I now realise that I needed to delete the =~/.emacs.d/straight/build/org= directory to trigger a rebuild of org-mode for the current branch I was on. (Live and learn...) Problem: My testing patch is indeed not working on vanilla Org, but it contains tests that will (presumably) work with the new merge-params patch. Question: What is the order of submission of patches? Do I submit a testing patch first which works strictly with vanilla Org first, and then a new merge-params function, and then yet another testing patch that is compliant with the new merge-params function? Or do I submit the new merge-params function, and then my testing patch on top? Best, Mehmet