From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Na=C3=AFm?= Favier Newsgroups: gmane.emacs.bugs Subject: bug#37344: rcirc: nil gets interpreted as a nickname Date: Sun, 8 Sep 2019 20:58:59 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="227774"; mail-complaints-to="usenet@blaine.gmane.org" To: 37344@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 08 21:06:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i72Vo-000x7J-Hq for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Sep 2019 21:06:12 +0200 Original-Received: from localhost ([::1]:50168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i72Vn-0001tY-B2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Sep 2019 15:06:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52188) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i72Vf-0001rD-7J for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 15:06:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i72Ve-0002BR-35 for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 15:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58542) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i72Ve-0002BJ-0Z for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 15:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i72Vd-0007U1-PR for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 15:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Na=C3=AFm?= Favier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Sep 2019 19:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37344 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.156796955328747 (code B ref -1); Sun, 08 Sep 2019 19:06:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Sep 2019 19:05:53 +0000 Original-Received: from localhost ([127.0.0.1]:39130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i72VV-0007Ta-Cs for submit@debbugs.gnu.org; Sun, 08 Sep 2019 15:05:53 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i72P4-0007F1-1q for submit@debbugs.gnu.org; Sun, 08 Sep 2019 14:59:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51125) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i72P3-0000wS-0o for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 14:59:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i72P2-0007Jd-34 for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 14:59:12 -0400 Original-Received: from mail-io1-f46.google.com ([209.85.166.46]:43699) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i72P1-0007JO-Uz for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 14:59:12 -0400 Original-Received: by mail-io1-f46.google.com with SMTP id u185so23808680iod.10 for ; Sun, 08 Sep 2019 11:59:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=F05w9t7g+4MBe2mRdjrqrA6qwaarQEyt+yYRzUCZR68=; b=giXN1m7xJhzSdh/EQ0YmR76toNqBLjB7VljXOTvEa0akOq6CSSSqR+vgHCCNOuyeQw 8fktHDfqFnyiVFolT/cciNp8Cal7PF24EOJX6+iwE+8sXjwJMmIFW1JmmhF5EMXYEqxY UqAr570saNOpzZbLYV7Vv3OsnwyiqszxKwQdzHHN42WhulC80MYRO96axXJUdKoZ5xhc zHXLjpv8Pz1QwhJ8bvglR9RrmHZQ/uVDHDAtwoGRhwxj80QAwPntXyItvIA7N0vQT+vQ BV/12CHW4o5nYOdGHiaZiWzeuPh3dfkObLzH9l1xWiHxmMLBysuWfT5qjULxw1CB1t4N BOrg== X-Gm-Message-State: APjAAAWXAMn1oYF93hXuWh2Tn18ggVZ6xNZ5sTFGegHa3AiW//tNUMVR sl9YYk3uZ1cfJMmFmu0bRV2zZpNeCEI= X-Google-Smtp-Source: APXvYqw9RoHJBGaPzhsI0XCrGsxhkbPXMqBWb2zeVrCWquIkKwkCZc/FpFnNiGBsHVqkLRBX3JPAvw== X-Received: by 2002:a6b:8d06:: with SMTP id p6mr9883508iod.219.1567969150846; Sun, 08 Sep 2019 11:59:10 -0700 (PDT) Original-Received: from mail-io1-f49.google.com (mail-io1-f49.google.com. [209.85.166.49]) by smtp.gmail.com with ESMTPSA id l186sm30052679ioa.54.2019.09.08.11.59.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Sep 2019 11:59:10 -0700 (PDT) Original-Received: by mail-io1-f49.google.com with SMTP id d17so1989232ios.13 for ; Sun, 08 Sep 2019 11:59:10 -0700 (PDT) X-Received: by 2002:a6b:e90d:: with SMTP id u13mr21019282iof.64.1567969150206; Sun, 08 Sep 2019 11:59:10 -0700 (PDT) X-Gmail-Original-Message-ID: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Mailman-Approved-At: Sun, 08 Sep 2019 15:05:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166306 Archived-At: Severity: normal Ever since I changed my nickname to "nil" on Freenode, I've been getting occasional private messages from unknown users consisting of a single empty CTCP ACTION. After a bit of investigating, it turned out they all used rcirc. The situation was clear at that point: somewhere in rcirc's source code, a nil value is being implicitly converted to a string and used as the target of a PRIVMSG command. The bug seems to be reproducible by issuing "/me" (without arguments) inside a server buffer: the "nil" user on that server gets sent an empty ACTION. Suggested fix: in rcirc-send-privmsg, fail if target is nil. It might be useful to check other places where the "%s" format is used, to discover similar bugs.