From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alex Kosorukoff Newsgroups: gmane.emacs.bugs Subject: bug#17467: 24.3; locate-library returning spurious path Date: Sun, 11 May 2014 14:00:48 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=e89a8f502d04429a1204f9262149 X-Trace: ger.gmane.org 1399842148 11412 80.91.229.3 (11 May 2014 21:02:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 11 May 2014 21:02:28 +0000 (UTC) Cc: 17467 <17467@debbugs.gnu.org> To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 11 23:02:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wjasz-0002VZ-Ca for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 May 2014 23:02:17 +0200 Original-Received: from localhost ([::1]:34335 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjasz-0002C3-3J for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 May 2014 17:02:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjasp-0002Bn-Ky for bug-gnu-emacs@gnu.org; Sun, 11 May 2014 17:02:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wjask-0004t6-KM for bug-gnu-emacs@gnu.org; Sun, 11 May 2014 17:02:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjask-0004t1-Fz for bug-gnu-emacs@gnu.org; Sun, 11 May 2014 17:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wjasj-0007Wo-Pg for bug-gnu-emacs@gnu.org; Sun, 11 May 2014 17:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Kosorukoff Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 May 2014 21:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17467 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17467-submit@debbugs.gnu.org id=B17467.139984207928870 (code B ref 17467); Sun, 11 May 2014 21:02:01 +0000 Original-Received: (at 17467) by debbugs.gnu.org; 11 May 2014 21:01:19 +0000 Original-Received: from localhost ([127.0.0.1]:59737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wjas1-0007VZ-Sx for submit@debbugs.gnu.org; Sun, 11 May 2014 17:01:18 -0400 Original-Received: from mail-ob0-f169.google.com ([209.85.214.169]:36969) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wjary-0007VK-O5 for 17467@debbugs.gnu.org; Sun, 11 May 2014 17:01:16 -0400 Original-Received: by mail-ob0-f169.google.com with SMTP id vb8so7329318obc.28 for <17467@debbugs.gnu.org>; Sun, 11 May 2014 14:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=JHGwByidM7+NOfXRa4/G9ajVaa6dp/4G7axjT+omHjc=; b=QB7eX5yXcLMiBXg6F41NKooxVZyEzvgdnbv8Wf9ptvJKM0Cy/zr39vGBb0fcVhG2F6 ohkRUFX0e75hCPHMYCh0hdvYiYoXKufFtRAZiIxR/OpUR1qZiDJ803EGRUH125J4H7b8 BMi6q4QWXo2qDjz5iDfBdfGy8LZBLqbJ6u+i6pwOrFLaZDFbJ+k6v1nuDo3BIJfKybkV yfE2NbqSUFTVCjI65qsu8Bp3C+cOpBQTEKkj67ptkyMrtlE5933CVSpy3QOe+shb77HS wzRxBYBhxVzZPP7A0tqbHytkZvCMf3jY1tjtw2nF1QsvmDTedYuXVKjFxA9eX2+2e9n9 Kdbw== X-Received: by 10.182.35.99 with SMTP id g3mr17980985obj.43.1399842068927; Sun, 11 May 2014 14:01:08 -0700 (PDT) Original-Received: by 10.182.240.131 with HTTP; Sun, 11 May 2014 14:00:48 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: MORjKJOzzDlhJdYJPJjrpPC99rk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88935 Archived-At: --e89a8f502d04429a1204f9262149 Content-Type: text/plain; charset=UTF-8 Stefan is right that the bug was there for a long time. I would like my patch be compatible with older versions of emacs that don't have string-suffix-p, so here is the revised version # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: alex@3form.com-20140511205538-1asyz50g7d3y4lgw # target_branch: :parent # testament_sha1: d9ca6f57d0d8486d42ed77a739877a208a34f22e # timestamp: 2014-05-11 13:55:53 -0700 # base_revision_id: monnier@iro.umontreal.ca-20140511034953-\ # 1mzcrftziwhrw9hl # # Begin patch === modified file 'lisp/subr.el' --- lisp/subr.el 2014-04-09 01:48:07 +0000 +++ lisp/subr.el 2014-05-11 20:55:38 +0000 @@ -1857,10 +1857,14 @@ load-path (get-load-suffixes))) nil nil t)) - (let ((file (locate-file library - (or path load-path) - (append (unless nosuffix (get-load-suffixes)) - load-file-rep-suffixes)))) + (let ((file + (locate-file library + (or path load-path) + (unless (or nosuffix + (string-match "\\.elc?\\.gz\\'" library)) + (if (string-match "\\.elc?\\'" library) + load-file-rep-suffixes + (get-load-suffixes)))))) (if interactive-call (if file (message "Library is file %s" (abbreviate-file-name file)) # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWfbc99AABHZ/gDIwFUFQ4//3 8wgABL////BgBs96932joSoL3t0q2rG2TpgbVEE2kE9J6jNTyaZNNTagHqAAaaeoOYBNMAmQwABM EwAAAShU02oAA0AAANAAAAG0qNQNT1MTCaepgmgwBDAI0000EUgRMgalP2mqaZpPVP0U9T0h6jah kGJo0EVE0aaRgITaJMJoaRieoNAAZMyxwwqXQuSoc5zx7XqLgxjChKpd+GuM3swscixOW2FuYpwb BJ76XVaN7ooEkNIl8j4H03G7ZaZmUngNpcGMaPziEkCQaXe13WIEZAjrzUVAplMmPv1v9TyDhZk/ TOCTEDcwOWPX5fOPrmzaublzrn8a9huAiuc8PAHYZNSwwjGhSFdSjC5SpYYbMwwpQrOXBEKJ3iZF xMl+oRaRFCFZtuLh4YuClOwDzJ2cWwwkZCevW+rQM0X3eaEPAlD5B1eGOUYxZmw4cVlwgMkDZ3GZ 9AtqjnMIiLHfetqjn0CpARpIshrEt/05xJEWdXxLOe+NJoQjuMKkKlnUWzmFb+kN1g6CdRNKmoiP XNismTs0wuRr35bDn4u+xGCEADgWqFbY5VAay3aHG6u7TB4iYIfEL7zJwFZoUJUM3c3+8duzI+Gw TRDux3mtEOw6Q5pQdWZPmJiOJlrCNKcdm2BaHY/HpUhRgK0QoJtiadSVUybnyQxg9d/ZQTHS+Btw 7CqlMt1Lxhg65OAldu/FyOViFxXEMItpVgQNeBKhvHO8sS5hrOBR0qqutnrT+EWImQ5V23kQTlqx Fd9ZIWwiyGqDeRU13oRurcJn2BtgIL6CS1uqhvgeodpiWMd+vZDjQTDE0HY5Uw6xPQahmK4du8xy e2W5sXMjaOdRESRqGFxkVnUTqMqHoxIuLpmP/IdEJHApoJ1apwziupdVOEDpGWxWb7DEuLlM22QQ HWza0l7xPf4ZYl72QOl+XZuqKiVvBkUiubNTzGuZihbGiGqmcryB2wyacpyqEoJRh29sQJmtZiZt pFszcI94kc6nnwLmkkNifK9vqQuobBWhKhQLtXdG0hlrVXIqIOQyLL7DDcxheex8xPZKdjEMEytU kzdrE3WxZsyEoyQhsxQbhLXMO90f2G6WyRYpm24mRjLZxKxYWUQXErpKlSbSTY97XjMdYvvZlTZD ORCO615GiQTND6RrmmfrsoU7lnoZ3CefiGW4rk+sSgcjiR1pBIiSQSIl8np6nm2uInuxVqAqHwHE JEX3WHA5m230El7Dobc9lW9l4cvcho8QPqh+IniDxPK2HCHlOtFMzOlPwPMOD0Dwz1a9DjU9BJY5 6Fu/mfa9fCHJF+x+5uqFMjn7XfhnHuG9j3JLFes6IXnEraIXdKYTeJGspva7eg4iYPXVDDsTQIC8 33xlGuvV5sEqFJROfJ8nfWm5hFm3CeftDC7At8jwuQx6fiWIcubjY+8XkVBUCgvxQFK2tK6JPofR GtSFpRcJMQsVOp9gac33JNjR5jHMwBkAF6FH0LjRk7eT2aVLnZXFKQzqcSa6aDGntmRuUjRktEnl aYpEbgXl2ntPa+jrU8dyLMNHsYaBmPkjiePIfAzO4h74eQO7ufN0Q7m15CQ20vAho8n6oQYhY6He PMGoez7BMLgn0dGTqD8w94OT7Xm4P0YATa8hPUJ0DV4iZvRTYT1BBG4G5iL3ofJUtGxmnAcINyKK RiV4/OVmEEKc04jYhEogyEkyCxDg9zkPa2ZhrCrIe9tUHFqzEqYJR0C0ZBY8EN6tQTihBDreFEMA I+L8OoATB73QCwNXyE6u8EPlUh9Xg55E3LzE1vD1MMIRaY3OPGzghoJUiPyQxToJATEmpuCquN72 uweLq6XhgqGgSnuatYGAljGDRArjU6IiSlO1ptukSJDJ56MbIvaNyFhNA5vvYbODvIItsG+ODIqJ Nm/oO5mMna3j7GiYdriN4mpGAiTOSG57XmhYhpBT4CSfgFrwa/WJ6IbkOAPkk2F749yGCFJM2CQR YDBCaBWJ8xMR8RLx3eg6R4+TvDDZwf/F3JFOFCQ9tz30AA== On Sun, May 11, 2014 at 1:45 PM, Alex Kosorukoff wrote: > The issue is that locate-library returns spurious paths like ".*/tramp" or > ".*xxx/tramp.gz" instead of returning a valid path to the library or nil if > no matching path is found. This is both unexpected and incorrect given this > function name and spec. It can cause user inconvenience or pose a > security/privacy issue because a random file named "tramp" or "tramp.gz" > placed in some directory of the load-path can be loaded instead of the > standard library without user knowledge. This is why I would prefer to fix > it. > > On Sun, May 11, 2014 at 12:50 PM, Stefan Monnier > wrote: > >> > it should be just (".elc" ".elc.gz" ".el" ".el.gz") when nosuffix is >> nil. >> >> Why? >> Did you find some documentation indicating that this is how it should >> work? >> Or is it the behavior you'd prefer, and if so, can you explain why you'd >> prefer that behavior? Which concrete cases do you specifically care >> about? >> > > This was the first and simplest way to address the issue above. Eli > Zaretskii made a valid point that it is not consistent with the way this > function worked before and not the most convenient for the user. I agree > with this, so I posted a patch that handles the cases he described, except > that it addresses the issue above. > >> >> The current behavior has been in use for *many* years and I expect that >> a fair bit of code relies on it, so we'd need a really good reason to >> change it. Maybe we can accommodate your specific concrete cases in >> some other way. >> > > I understand that the bug was there for many years and many > people implemented workarounds (I did). I don't think this is a valid > reason to keep it though. We just need to be careful to make sure we don't > introduce a regression while fixing it. Unit tests can help. > > >> >> >> Stefan >> > > --e89a8f502d04429a1204f9262149 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Stefan is right that the bug was there for a long time. I = would like my patch be compatible with older versions of emacs that don'= ;t have string-suffix-p, so here is the revised version

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_i= d: alex@3form.com-20140511205538-1asyz50g7d3y4lgw
# target_branch= : :parent
# testament_sha1: d9ca6f57d0d8486d42ed77a739877a208a34f= 22e
# timestamp: 2014-05-11 13:55:53 -0700
# base_revision_id: m= onnier@iro.umontreal.ca-20140511034953-\
# =C2=A0 1mzcrftziwhrw9h= l
#=C2=A0
# Begin patch
=3D=3D=3D modified fi= le 'lisp/subr.el'
--- lisp/subr.el =C2=A0 =C2=A0 =C2=A0 =C2=A02014-04-09 01:48:07 +0000<= /div>
+++ lisp/subr.el =C2=A0 =C2=A0 =C2=A0 =C2=A02014-05-11 20:55:38 += 0000
@@ -1857,10 +1857,14 @@
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 load-path (get-load-suffixes)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0nil nil
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0t))
- =C2=A0(let ((file (locate-file l= ibrary
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(or path load-path)
- =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(append (unless nosuffix (get-load-suffixes))
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0load-file-rep-suffixes)= )))
+ =C2=A0(let ((file
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 (= locate-file library
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(or path load-path)
+ =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(unles= s (or nosuffix
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(string-match "\\.= elc?\\.gz\\'" library))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if (string-match &q= uot;\\.elc?\\'" library)
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0load-f= ile-rep-suffixes
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(get-load-suffixes))))))
=C2=A0 =C2=A0 = =C2=A0(if interactive-call
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (if file
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (message "Library i= s file %s" (abbreviate-file-name file))

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY= 0CiMKQlpoOTFBWSZTWfbc99AABHZ/gDIwFUFQ4//3
8wgABL////BgBs96932joSo= L3t0q2rG2TpgbVEE2kE9J6jNTyaZNNTagHqAAaaeoOYBNMAmQwABM
EwAAAShU02o= AA0AAANAAAAG0qNQNT1MTCaepgmgwBDAI0000EUgRMgalP2mqaZpPVP0U9T0h6jah
kGJo0EVE0aaRgITaJMJoaRieoNAAZMyxwwqXQuSoc5zx7XqLgxjChKpd+GuM3swscixOW2= FuYpwb
BJ76XVaN7ooEkNIl8j4H03G7ZaZmUngNpcGMaPziEkCQaXe13WIEZAjrzU= VAplMmPv1v9TyDhZk/
TOCTEDcwOWPX5fOPrmzaublzrn8a9huAiuc8PAHYZNSwwj= GhSFdSjC5SpYYbMwwpQrOXBEKJ3iZF
xMl+oRaRFCFZtuLh4YuClOwDzJ2cWwwkZCevW+rQM0X3eaEPAlD5B1eGOUYxZmw4cVlwgM= kDZ3GZ
9AtqjnMIiLHfetqjn0CpARpIshrEt/05xJEWdXxLOe+NJoQjuMKkKlnUWz= mFb+kN1g6CdRNKmoiP
XNismTs0wuRr35bDn4u+xGCEADgWqFbY5VAay3aHG6u7TB= 4iYIfEL7zJwFZoUJUM3c3+8duzI+Gw
TRDux3mtEOw6Q5pQdWZPmJiOJlrCNKcdm2BaHY/HpUhRgK0QoJtiadSVUybnyQxg9d/ZQT= HS+Btw
7CqlMt1Lxhg65OAldu/FyOViFxXEMItpVgQNeBKhvHO8sS5hrOBR0qqutn= rT+EWImQ5V23kQTlqx
Fd9ZIWwiyGqDeRU13oRurcJn2BtgIL6CS1uqhvgeodpiWM= d+vZDjQTDE0HY5Uw6xPQahmK4du8xy
e2W5sXMjaOdRESRqGFxkVnUTqMqHoxIuLpmP/IdEJHApoJ1apwziupdVOEDpGWxWb7DEuL= lM22QQ
HWza0l7xPf4ZYl72QOl+XZuqKiVvBkUiubNTzGuZihbGiGqmcryB2wyacp= yqEoJRh29sQJmtZiZt
pFszcI94kc6nnwLmkkNifK9vqQuobBWhKhQLtXdG0hlrVX= IqIOQyLL7DDcxheex8xPZKdjEMEytU
kzdrE3WxZsyEoyQhsxQbhLXMO90f2G6WyRYpm24mRjLZxKxYWUQXErpKlSbSTY97XjMdYv= vZlTZD
ORCO615GiQTND6RrmmfrsoU7lnoZ3CefiGW4rk+sSgcjiR1pBIiSQSIl8n= p6nm2uInuxVqAqHwHE
JEX3WHA5m230El7Dobc9lW9l4cvcho8QPqh+IniDxPK2HC= HlOtFMzOlPwPMOD0Dwz1a9DjU9BJY5
6Fu/mfa9fCHJF+x+5uqFMjn7XfhnHuG9j3JLFes6IXnEraIXdKYTeJGspva7eg4iYPXVDD= sTQIC8
33xlGuvV5sEqFJROfJ8nfWm5hFm3CeftDC7At8jwuQx6fiWIcubjY+8XkV= BUCgvxQFK2tK6JPofR
GtSFpRcJMQsVOp9gac33JNjR5jHMwBkAF6FH0LjRk7eT2a= VLnZXFKQzqcSa6aDGntmRuUjRktEnl
aYpEbgXl2ntPa+jrU8dyLMNHsYaBmPkjiePIfAzO4h74eQO7ufN0Q7m15CQ20vAho8n6oQ= YhY6He
PMGoez7BMLgn0dGTqD8w94OT7Xm4P0YATa8hPUJ0DV4iZvRTYT1BBG4G5i= L3ofJUtGxmnAcINyKK
RiV4/OVmEEKc04jYhEogyEkyCxDg9zkPa2ZhrCrIe9tUHF= qzEqYJR0C0ZBY8EN6tQTihBDreFEMA
I+L8OoATB73QCwNXyE6u8EPlUh9Xg55E3LzE1vD1MMIRaY3OPGzghoJUiPyQxToJATEmpu= CquN72
uweLq6XhgqGgSnuatYGAljGDRArjU6IiSlO1ptukSJDJ56MbIvaNyFhNA5= vvYbODvIItsG+ODIqJ
Nm/oO5mMna3j7GiYdriN4mpGAiTOSG57XmhYhpBT4= CSfgFrwa/WJ6IbkOAPkk2F749yGCFJM2CQR
YDBCaBWJ8xMR8RLx3eg6R4+TvDDZwf/F3JFOFCQ9tz30AA=3D=3D
<= br>




On Sun, May 11, 2014 at 1:45 PM, Alex= Kosorukoff <alex@3form.com> wrote:
The issue is that loca= te-library returns spurious paths like ".*/tramp" or ".*xxx/= tramp.gz" instead of returning a valid path to the library or nil if n= o matching path is found. This is both unexpected and incorrect given this = function name and spec. It can cause user inconvenience or pose a security/= privacy issue because a random file named "tramp" or "tramp.= gz" placed in some directory of the load-path can be loaded instead of= the standard library without user knowledge. This is why I would prefer to= fix it.

On Sun, May 11, 2014 at 12:50 PM, Stefan Monnier <monnier= @iro.umontreal.ca> wrote:
> it should be just (".elc" ".elc.g= z" ".el" ".el.gz") when nosuffix is nil.

Why?
Did you find some documentation indicating that this is how it should work?=
Or is it the behavior you'd prefer, and if so, can you explain why you&= #39;d
prefer that behavior? =C2=A0Which concrete cases do you specifically care a= bout?

This was the first and simp= lest way to address the issue above.=C2=A0Eli Zaretskii made a valid point = that it is not consistent with the way this function worked before and not = the most convenient for the user. I agree with this, so I posted a patch th= at handles the cases he described, except that it addresses the issue above= .

The current behavior has been in use for *many* years and I expect that
a fair bit of code relies on it, so we'd need a really good reason to change it. =C2=A0Maybe we can accommodate your specific concrete cases in some other way.

I understand that= the bug was there for many years and many people=C2=A0implemented workarou= nds (I did). I don't think this is a valid reason to keep it though. We= just need to be careful to make sure we don't introduce a regression w= hile fixing it. Unit tests can help.
=C2=A0


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan


--e89a8f502d04429a1204f9262149--