From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ryan Thompson Newsgroups: gmane.emacs.bugs Subject: bug#27841: 25.2; Patch for completion-table-with-predicate Date: Fri, 04 Aug 2017 23:00:16 +0000 Message-ID: References: <87mv7f6j06.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a11419c6680caed0555f57605" X-Trace: blaine.gmane.org 1501887675 8113 195.159.176.226 (4 Aug 2017 23:01:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 Aug 2017 23:01:15 +0000 (UTC) Cc: 27841@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 05 01:01:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddlad-0001jc-62 for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Aug 2017 01:01:07 +0200 Original-Received: from localhost ([::1]:54647 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddlaj-0002f7-E8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Aug 2017 19:01:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddlab-0002en-LD for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2017 19:01:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddlaY-00083Y-Gt for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2017 19:01:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39459) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ddlaY-000835-8N for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2017 19:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ddlaX-0001V8-OQ for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2017 19:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ryan Thompson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2017 23:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27841 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27841-submit@debbugs.gnu.org id=B27841.15018876354255 (code B ref 27841); Fri, 04 Aug 2017 23:01:01 +0000 Original-Received: (at 27841) by debbugs.gnu.org; 4 Aug 2017 23:00:35 +0000 Original-Received: from localhost ([127.0.0.1]:42136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddla6-00016D-O7 for submit@debbugs.gnu.org; Fri, 04 Aug 2017 19:00:34 -0400 Original-Received: from mail-it0-f43.google.com ([209.85.214.43]:38425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddla4-0000zF-PV for 27841@debbugs.gnu.org; Fri, 04 Aug 2017 19:00:33 -0400 Original-Received: by mail-it0-f43.google.com with SMTP id h199so14623185ith.1 for <27841@debbugs.gnu.org>; Fri, 04 Aug 2017 16:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thompsonclan-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FD/wyuHLqaXcAt3Sw6O5qV2oQgeW7TTQ5on60u7Pibg=; b=omUzoj5zj0wTqJfP0cMQGXZQ0slwpeudXmX073RjWpERSvMPNi8ZI3wwby28pBAmsY Dk0eCahvFzE5Xdzq/80prmr1YkkJB9MWKGHVrE+x55ndocpqWYf7toSCXGvv1dA2uNgq EGCtS9hp7aFcSv0JCHxv1wuTQylq9kHU2SmirFoRQ7EIOKp8iUCgVK4Dy+6wNRvTf4wx Ahg2WjhuEhyCdv+680DzlVr7+gbsPc1/30q0tg1tCkWSL59Obo858C4RCOoH6HOJFNRn FUGKA6YcNVdLhawMPuIzYCJa3vo9RrsAM55ODkWKatabtdPJqhGPxOeXxX4mky8uKIMi 8O5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FD/wyuHLqaXcAt3Sw6O5qV2oQgeW7TTQ5on60u7Pibg=; b=NnGNw6g20wmECHUklGO43LwSvDSl74p1a6DYniJTzkSTw8e59vu0wZ3OlYA/QnSdQy DqaUJD7eN0OnBF1OdlXo/LrAdqkm6dPUYCjL/TE2u4mY0ErpcJtSXVd+4WZhsSrP7ILJ vGeO5F1iXhGZmoVnJRfJY9Gl+UFwvr/0Mki6rAaAH2SKU5jhydJl5DTbmq74ma5se/Oa GFJlFgQjxjr51yNmACNHXyxc2ARsBs6q8Z2T2WakA/XGXxd+ztvPivWU3Vdofk8LUcUz 5EOxT0ogCkdJF461hAcEa786CSTlUvpcdjeOCDX+S9vmPSCPkIhGXC4AqKG5u1AkIi/p 7PKg== X-Gm-Message-State: AHYfb5i008My2WWRQTqFMuzbZN9dfzUNuH/yw3gJKZ3iwdep+2pLhPGc IqYEsn/Eh5lESgxJZjgI8bpdLH0PpBGW X-Received: by 10.36.86.139 with SMTP id o133mr3918621itb.50.1501887627048; Fri, 04 Aug 2017 16:00:27 -0700 (PDT) In-Reply-To: <87mv7f6j06.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135366 Archived-At: --001a11419c6680caed0555f57605 Content-Type: text/plain; charset="UTF-8" Ok, I will reformat them when I get the chance. Would you also like me to provide an example where the old code does the wrong thing? On Fri, Aug 4, 2017 at 3:53 PM wrote: > tags 27841 + patch > quit > > Ryan writes: > > > When the pred2 arg to completion-table-with-predicate is nil, it acts > > like strict is non-nil, even if it isn't. I'm attaching a patch > > (created with "git format-patch") that > > fixes the bug. > > Looks reasonable, though I'm not very familiar with this code. The > commit messages should be reformatted into ChangeLog format, and the > first one would be better rephrased into present tense. I'm reattaching > the patches inline here for convenience. > > --001a11419c6680caed0555f57605 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, I will reformat them when I get the chance. Would you = also like me to provide an example where the old code does the wrong thing?=

On Fri, Aug 4, 2017 a= t 3:53 PM <npostavs@us= ers.sourceforge.net> wrote:
= tags 27841 + patch
quit

Ryan <rct@thom= psonclan.org> writes:

> When the pred2 arg to completion-table-with-predicate is nil, it acts<= br> > like strict is non-nil, even if it isn't. I'm attaching a patc= h
> (created with "git format-patch") that
> fixes the bug.

Looks reasonable, though I'm not very familiar with this code.=C2=A0 Th= e
commit messages should be reformatted into ChangeLog format, and the
first one would be better rephrased into present tense.=C2=A0 I'm reatt= aching
the patches inline here for convenience.

--001a11419c6680caed0555f57605--