all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dani Moncayo <dmoncayo@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Trunk broken on MS-Windows
Date: Sun, 9 Nov 2014 00:34:56 +0100	[thread overview]
Message-ID: <CAH8Pv0jfFroDcTquu54Z5iHzKOJrn-Mszzz4ZfT0NjH-F5qvNA@mail.gmail.com> (raw)
In-Reply-To: <CAH8Pv0h73mMAKOLbYe0__0BLyVhjdXR6ULrM0uFi_9WeTRVPdQ@mail.gmail.com>

On Sat, Nov 8, 2014 at 11:25 PM, Dani Moncayo <dmoncayo@gmail.com> wrote:
>> Does the problem go away with revision 118323 ?
>
> Perhaps, a better fix would have been this:
>
> === modified file 'Makefile.in'
> --- Makefile.in 2014-11-08 15:18:06 +0000
> +++ Makefile.in 2014-11-08 22:20:19 +0000
> @@ -334,7 +334,7 @@
>  # program that doesn't support MSYS-style paths (e.g. '/c/foo/bar' or
>  # '/foo/bar').
>  epaths-force-w32:
> -       @(w32srcdir=`${srcdir}/build-aux/msys-to-w32 "${srcdir}"`; \
> +       @(w32srcdir=`${srcdir}/build-aux/msys-to-w32 "${abs_srcdir}"`; \
>           w32prefix=`${srcdir}/build-aux/msys-to-w32 "${prefix}"`; \
>           w32locallisppath=`${srcdir}/build-aux/msys-to-w32
> "${locallisppath}"` ; \
>           w32locallisppath=$${w32locallisppath//$${w32prefix}/"%emacs_dir%"} ; \

Indeed, I've tested it and does TRT.

I think this fix is cleaner, because it converts from relative to
absolute paths only when there is a reason to.  So I've reverted
r118323 and committed the above patch.

-- 
Dani Moncayo



  reply	other threads:[~2014-11-08 23:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-08 20:00 Trunk broken on MS-Windows Eli Zaretskii
2014-11-08 20:40 ` Eli Zaretskii
2014-11-08 21:19   ` Dani Moncayo
2014-11-08 22:25     ` Dani Moncayo
2014-11-08 23:34       ` Dani Moncayo [this message]
2014-11-09  3:39     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH8Pv0jfFroDcTquu54Z5iHzKOJrn-Mszzz4ZfT0NjH-F5qvNA@mail.gmail.com \
    --to=dmoncayo@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.