From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dani Moncayo Newsgroups: gmane.emacs.bugs Subject: bug#24759: 25.1.50; electric-quote-mode Date: Fri, 21 Oct 2016 22:26:13 +0200 Message-ID: References: <83wph1qxrw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1477081639 23017 195.159.176.226 (21 Oct 2016 20:27:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 21 Oct 2016 20:27:19 +0000 (UTC) Cc: Paul Eggert , 24759@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 21 22:27:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxgPI-0005DD-EW for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Oct 2016 22:27:12 +0200 Original-Received: from localhost ([::1]:34375 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxgPK-0005EA-7n for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Oct 2016 16:27:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxgPB-0005Cy-1r for bug-gnu-emacs@gnu.org; Fri, 21 Oct 2016 16:27:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxgP7-0000Of-Ut for bug-gnu-emacs@gnu.org; Fri, 21 Oct 2016 16:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58531) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bxgP7-0000Ob-RI for bug-gnu-emacs@gnu.org; Fri, 21 Oct 2016 16:27:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bxgP7-0005SQ-JO for bug-gnu-emacs@gnu.org; Fri, 21 Oct 2016 16:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dani Moncayo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Oct 2016 20:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24759 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24759-submit@debbugs.gnu.org id=B24759.147708158120920 (code B ref 24759); Fri, 21 Oct 2016 20:27:01 +0000 Original-Received: (at 24759) by debbugs.gnu.org; 21 Oct 2016 20:26:21 +0000 Original-Received: from localhost ([127.0.0.1]:45697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxgOT-0005RL-Dk for submit@debbugs.gnu.org; Fri, 21 Oct 2016 16:26:21 -0400 Original-Received: from mail-wm0-f45.google.com ([74.125.82.45]:35291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxgOR-0005Qz-MH for 24759@debbugs.gnu.org; Fri, 21 Oct 2016 16:26:19 -0400 Original-Received: by mail-wm0-f45.google.com with SMTP id c78so4948306wme.0 for <24759@debbugs.gnu.org>; Fri, 21 Oct 2016 13:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mCV03FyFqwojtIh3jjyA5HB9IvJZouuwnSjNwkmWyqg=; b=XsqfQ7pqJULMzRhltcCt6i/MuGDmCQz6G67toA+bzIU8oFrLlJgOf1tuSSIYLOrK39 Eq5OUeEtHPfgzVHcQu+pcEUk1NHIZ/4EQU29C8RaBEJeeS7kheECsd2FqSzY3RmEmPVF 7oWLV9Zn06u3GEQVpOqSIFyI9A7GK3a5xffXf32XyjvbZsUlUlZlooFTr45McaMo9wV0 fqJtNZQ2l/8T4J/it8GRZB/VpPRCXqSveF78LWKPBl5NpaL9dkf+zTVDn/2Gwwsm04Qy q2LoeANvE1KyD1MgndKcmceL827ZoghiOykD60djvDHv5ugo/r/TwivcWXaegFzVW0wQ DR2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mCV03FyFqwojtIh3jjyA5HB9IvJZouuwnSjNwkmWyqg=; b=JBY2sxlB7TSLmi8PaHGXoNOs9t2z5PiC/B1VfEgWvM6h530EbTtPM52C8pfveROcMF zz0vv3eLswz7twbeBrEd5ctDCm4UPtU4N+yOXL7ob5qH7k+5GjsNlqltPrjvu+GpPS6R h3+XSaK6ndB3XsJn1vforAZDdjP6V68i87eMkP94HenRyy4LMNiK0tGB+qxWw+LSpU8g z5smLDCTzdsKHQyuaZVn4G9fJP6VjUJQdPboCt5cLF5POGEvmvXzsnPcKWfZg5EfnD4n /Ci6WQJoalK+8BuBGRgq7g8zTQPl7nSQrRnOlCpLQT0E790KKz5hldm1dYRldtSUy4mn lVIw== X-Gm-Message-State: ABUngvcJDqo6Tmye1rrs4XtSnGp2UnDkDET7pXycZgvCERwQhFoDC6+6TyNwJ31qMaisOxPSfiS92jfydRpsGg== X-Received: by 10.194.235.103 with SMTP id ul7mr2321339wjc.201.1477081574094; Fri, 21 Oct 2016 13:26:14 -0700 (PDT) Original-Received: by 10.28.95.133 with HTTP; Fri, 21 Oct 2016 13:26:13 -0700 (PDT) In-Reply-To: <83wph1qxrw.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124798 Archived-At: > I guess your buffer-file-coding-system is neither 'undecided' nor > anything that can encode the curved quotes. Try > > C-x RET f utf-8 RET > > and then type the above again. Your guess is right. After doing the above, the electric quote conversion works. > Paul, I think this condition: > > (defun electric--insertable-p (string) > (or (not buffer-file-coding-system) > (eq (coding-system-base buffer-file-coding-system) 'undecided) > (not (unencodable-char-position nil nil buffer-file-coding-system > nil string)))) > > should also accept a coding-system that is the default-value of > buffer-file-coding-system, because that's how buffers are created. > When the file is saved, Emacs will ask for a proper encoding, which is > not a catastrophe. I have no opinion on that but I think that, if this minor mode isn't going to work with every possible buffer-file-coding-system, that limitation should be explained somehow in the *Help* text of the minor mode, to avoid confusing some users. Thanks. -- Dani Moncayo