all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dani Moncayo <dmoncayo@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>, 24759@debbugs.gnu.org
Subject: bug#24759: 25.1.50; electric-quote-mode
Date: Fri, 21 Oct 2016 22:26:13 +0200	[thread overview]
Message-ID: <CAH8Pv0jXD-C7YjsBzpB=kXTQy1Tno1d+ipSu5yNNs3Qoa6E5gQ@mail.gmail.com> (raw)
In-Reply-To: <83wph1qxrw.fsf@gnu.org>

> I guess your buffer-file-coding-system is neither 'undecided' nor
> anything that can encode the curved quotes.  Try
>
>   C-x RET f utf-8 RET
>
> and then type the above again.

Your guess is right.  After doing the above, the electric quote
conversion works.

> Paul, I think this condition:
>
>   (defun electric--insertable-p (string)
>     (or (not buffer-file-coding-system)
>         (eq (coding-system-base buffer-file-coding-system) 'undecided)
>         (not (unencodable-char-position nil nil buffer-file-coding-system
>                                         nil string))))
>
> should also accept a coding-system that is the default-value of
> buffer-file-coding-system, because that's how buffers are created.
> When the file is saved, Emacs will ask for a proper encoding, which is
> not a catastrophe.

I have no opinion on that but I think that, if this minor mode isn't
going to work with every possible buffer-file-coding-system, that
limitation should be explained somehow in the *Help* text of the minor
mode, to avoid confusing some users.

Thanks.

-- 
Dani Moncayo





  reply	other threads:[~2016-10-21 20:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21 19:38 bug#24759: 25.1.50; electric-quote-mode Dani Moncayo
2016-10-21 19:58 ` Eli Zaretskii
2016-10-21 20:26   ` Dani Moncayo [this message]
2016-10-21 21:01     ` Paul Eggert
2016-10-21 21:04   ` Paul Eggert
2016-10-22  6:49     ` Eli Zaretskii
2016-10-22  7:47       ` Eli Zaretskii
2016-10-22  8:16         ` Dani Moncayo
2016-10-22  9:10           ` Eli Zaretskii
2016-10-22 10:36             ` Dani Moncayo
2016-10-22 18:47       ` Paul Eggert
2016-10-22 19:04         ` Eli Zaretskii
2016-10-22 19:34           ` Eli Zaretskii
2016-10-23  4:10             ` Paul Eggert
2016-10-23  7:13               ` Eli Zaretskii
2016-10-23  8:24                 ` Paul Eggert
2016-10-23  8:51                   ` Eli Zaretskii
2016-10-22 19:20         ` Andreas Schwab
2016-10-23  3:55           ` Paul Eggert
2016-10-23  7:00             ` Eli Zaretskii
2016-10-23  8:15               ` Paul Eggert
2016-10-23  8:55                 ` Eli Zaretskii
2016-10-23  9:15                   ` Dani Moncayo
2016-10-23  9:28                     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH8Pv0jXD-C7YjsBzpB=kXTQy1Tno1d+ipSu5yNNs3Qoa6E5gQ@mail.gmail.com' \
    --to=dmoncayo@gmail.com \
    --cc=24759@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.