From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dani Moncayo Newsgroups: gmane.emacs.devel Subject: Re: Setting the value of `emacs-bzr-version' also from a git checkout Date: Tue, 1 Oct 2013 23:15:17 +0200 Message-ID: References: <87a9is6g2a.fsf@igel.home> <87pprokewg.fsf@wanadoo.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1380662143 13279 80.91.229.3 (1 Oct 2013 21:15:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Oct 2013 21:15:43 +0000 (UTC) Cc: Emacs development discussions To: =?ISO-8859-1?Q?=D3scar_Fuentes?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 01 23:15:41 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VR7ID-0007ws-7c for ged-emacs-devel@m.gmane.org; Tue, 01 Oct 2013 23:15:41 +0200 Original-Received: from localhost ([::1]:32824 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR7IC-0001hD-Gz for ged-emacs-devel@m.gmane.org; Tue, 01 Oct 2013 17:15:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR7Ht-0001UI-HF for emacs-devel@gnu.org; Tue, 01 Oct 2013 17:15:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR7Hs-0001Q9-Fc for emacs-devel@gnu.org; Tue, 01 Oct 2013 17:15:21 -0400 Original-Received: from mail-la0-x232.google.com ([2a00:1450:4010:c03::232]:60449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR7Hs-0001Pf-1G for emacs-devel@gnu.org; Tue, 01 Oct 2013 17:15:20 -0400 Original-Received: by mail-la0-f50.google.com with SMTP id gx14so6412815lab.37 for ; Tue, 01 Oct 2013 14:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=NH/nThyqflNH1W7A0xvnY4BvysgMLCCurWzWs4P5dOY=; b=FTJ/oXmQRts+GGvB9spdQsPmf4BgLf0sb5eh9sMksKkYnOJEoEv0GgtLz/CqGqPJnj CUSHnk1IKYvVRE6ocCCesbpLhMlb5a/RcvC8NRqeNAlfq9cvoMNRSEETNzQmqytgt0+o WCcAtl9FDSdYEVpRmn989Qw0vtzJEsw6OGm6gqm8S0ApWVrrAA/9EVIwA5E40QJo7f+u OFmfci3wlCeYdvx437+mN84WS+JinbqtqrL254znPifAdU02gMhqbS/jARWQEwVQQECI Ackz7gDfT4P2yNI5SO7dOKCMPfMz+HdBJRapp+s7pmseJQUN07N89AZCacxlAt8puONw jjEg== X-Received: by 10.152.2.74 with SMTP id 10mr3363469las.36.1380662117972; Tue, 01 Oct 2013 14:15:17 -0700 (PDT) Original-Received: by 10.114.176.231 with HTTP; Tue, 1 Oct 2013 14:15:17 -0700 (PDT) In-Reply-To: <87pprokewg.fsf@wanadoo.es> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163783 Archived-At: On Tue, Oct 1, 2013 at 8:46 PM, =D3scar Fuentes wrote: > Dani Moncayo writes: > >> But the final goal would be to make `emacs-bzr-version' get the >> correct value also when building emacs from the official git repo. >> And since its value includes both the bzr revno and the bzr revision >> ID (e.g. "114456 rgm@gnu.org-20130925101746-8kz06nvtpjms0hy3"), the >> notes stored in the git repo are insufficient (they lack the bzr >> revno). > > Just teach the build scripts to not require the revision number. Not sure what you mean. AFAIK, the build scripts don't require it. > From the revision id whoever reads the bug report can get the revision > number (for a given branch.) Actually, if you look only to the revision > number you can end wasting your time, because you don't know which > branch was used to build that Emacs. Yes I know, the bzr revision number is always relative to some bzr branch, while the bzr revid is universally unique. But my point is that `emacs-bzr-version' gives both of them (on an Emacs built from a bzr branch), and everyone in these lists prefer the bzr revno, because is shorter/simpler. Therefore, what I'd like is that "emacs-bzr-version" gave the exact same string from an Emacs built from either bzr-trunk or git-master. --=20 Dani Moncayo