From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dani Moncayo Newsgroups: gmane.emacs.bugs Subject: bug#13032: 24.3.50; Request: Provide a `delete-duplicate-lines' command Date: Sun, 2 Dec 2012 10:13:55 +0100 Message-ID: References: <87obig2ap2.fsf@mail.jurta.org> <874nk728ci.fsf@mail.jurta.org> <874nk63aps.fsf@mail.jurta.org> <87mwxxfhd3.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1354439690 13145 80.91.229.3 (2 Dec 2012 09:14:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Dec 2012 09:14:50 +0000 (UTC) Cc: Juanma Barranquero , 13032@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 02 10:15:02 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tf5dd-0001f6-I0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Dec 2012 10:15:01 +0100 Original-Received: from localhost ([::1]:55223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tf5dR-00010X-UE for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Dec 2012 04:14:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tf5dP-000103-GW for bug-gnu-emacs@gnu.org; Sun, 02 Dec 2012 04:14:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tf5dO-0000KC-K8 for bug-gnu-emacs@gnu.org; Sun, 02 Dec 2012 04:14:47 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tf5dO-0000K4-Fw for bug-gnu-emacs@gnu.org; Sun, 02 Dec 2012 04:14:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tf5fZ-0000wr-W5 for bug-gnu-emacs@gnu.org; Sun, 02 Dec 2012 04:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dani Moncayo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Dec 2012 09:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13032-submit@debbugs.gnu.org id=B13032.13544397773590 (code B ref 13032); Sun, 02 Dec 2012 09:17:01 +0000 Original-Received: (at 13032) by debbugs.gnu.org; 2 Dec 2012 09:16:17 +0000 Original-Received: from localhost ([127.0.0.1]:49297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tf5eq-0000vq-DV for submit@debbugs.gnu.org; Sun, 02 Dec 2012 04:16:17 -0500 Original-Received: from mail-oa0-f44.google.com ([209.85.219.44]:62960) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tf5en-0000vi-Ku for 13032@debbugs.gnu.org; Sun, 02 Dec 2012 04:16:14 -0500 Original-Received: by mail-oa0-f44.google.com with SMTP id n5so1755441oag.3 for <13032@debbugs.gnu.org>; Sun, 02 Dec 2012 01:13:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=hPGG47J6RjmVUnn7BaB1vjFXCmh4ipjgfVsAT08QX3M=; b=yWA0+Lbd+vCRi6KHxBGjynh2LY5wn6gWYQh7x7O9ZByrEy5YYRBQ59EONiEUZ4C1sx IsSvMvUyyf8oTlN/0OnQyFDEPYmdFoV9W1FKhWFcT3ZnlNzCGJaJYlKkEh+kSdwUheQ2 fsfgjrVGhY5FrKJHQVZlBzQB1nyHB90iKpPbw+YASjRrD2+O0qS3BhsEWQi7KXHss8RK 18lkgQI/ugB+uTGR1Vg4Tksy0/An9Ss+GnR5u8S3AV0c5oqFMEw5UmFs9g79OO9Fx9CA hHzoUTFZQ52Vy86NZ7Wh/CpLbyGsid/rSlLiRfcfVuMshY2fZUwXUW+hoWxncPZ14Uj8 n5Cg== Original-Received: by 10.182.78.137 with SMTP id b9mr1739217obx.94.1354439636065; Sun, 02 Dec 2012 01:13:56 -0800 (PST) Original-Received: by 10.60.64.170 with HTTP; Sun, 2 Dec 2012 01:13:55 -0800 (PST) In-Reply-To: <87mwxxfhd3.fsf@mail.jurta.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67774 Archived-At: >> * I'm thinking that the ADJACENT argument is kinda unnecessary. I >> can't think of a use-case where someone wants to remove only the >> _adjacent_ duplicate lines but not the ones which aren't adjacent. >> So, I think that both the interface and the implementation could be >> simplified by removing that argument. > > The ADJACENT argument is an optimization that doesn't require > additional memory (to store previous lines in the cache). > This is necessary when the user needs to delete duplicate lines > in a large sorted file. Ah, good point. I guess that the optimization is twofold: in memory and also in performance. Then, IMO this should be explained in the docstring, so that users know that they should use this feature when running this command over a large chunk of lines. Thank you. -- Dani Moncayo