From: Dani Moncayo <dmoncayo@gmail.com>
To: Juri Linkov <juri@jurta.org>
Cc: Juanma Barranquero <lekktu@gmail.com>, 13032@debbugs.gnu.org
Subject: bug#13032: 24.3.50; Request: Provide a `delete-duplicate-lines' command
Date: Sun, 2 Dec 2012 10:13:55 +0100 [thread overview]
Message-ID: <CAH8Pv0ijmN071KYNdWrwH0kYPUvV0pTZC2WsUGMaJRLWGB9V3A@mail.gmail.com> (raw)
In-Reply-To: <87mwxxfhd3.fsf@mail.jurta.org>
>> * I'm thinking that the ADJACENT argument is kinda unnecessary. I
>> can't think of a use-case where someone wants to remove only the
>> _adjacent_ duplicate lines but not the ones which aren't adjacent.
>> So, I think that both the interface and the implementation could be
>> simplified by removing that argument.
>
> The ADJACENT argument is an optimization that doesn't require
> additional memory (to store previous lines in the cache).
> This is necessary when the user needs to delete duplicate lines
> in a large sorted file.
Ah, good point. I guess that the optimization is twofold: in memory
and also in performance. Then, IMO this should be explained in the
docstring, so that users know that they should use this feature when
running this command over a large chunk of lines.
Thank you.
--
Dani Moncayo
next prev parent reply other threads:[~2012-12-02 9:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 19:23 bug#13032: 24.3.50; Request: Provide a `delete-duplicate-lines' command Dani Moncayo
2012-11-29 20:49 ` Juanma Barranquero
2012-11-29 21:43 ` Dani Moncayo
2012-11-29 22:45 ` Juanma Barranquero
2012-11-30 0:31 ` Juri Linkov
2012-11-30 0:46 ` Juanma Barranquero
2012-11-30 0:50 ` Juanma Barranquero
2012-11-30 0:57 ` Juri Linkov
2012-11-30 1:02 ` Juanma Barranquero
2012-11-30 1:12 ` Juri Linkov
2012-11-30 7:51 ` Dani Moncayo
2012-12-01 0:34 ` Juri Linkov
2012-12-01 9:08 ` Dani Moncayo
2012-12-01 9:22 ` Dani Moncayo
2012-12-02 0:45 ` Juri Linkov
2012-12-02 9:13 ` Dani Moncayo [this message]
2012-12-03 23:49 ` Juri Linkov
2012-12-04 0:05 ` Juri Linkov
2012-12-04 9:13 ` Dani Moncayo
2012-12-04 23:51 ` Juri Linkov
2012-12-05 8:08 ` Dani Moncayo
2012-11-30 7:51 ` Dani Moncayo
2012-12-04 7:04 ` Thierry Volpiatto
2012-12-04 14:46 ` Stefan Monnier
2012-12-04 15:02 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH8Pv0ijmN071KYNdWrwH0kYPUvV0pTZC2WsUGMaJRLWGB9V3A@mail.gmail.com \
--to=dmoncayo@gmail.com \
--cc=13032@debbugs.gnu.org \
--cc=juri@jurta.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.