From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dani Moncayo Newsgroups: gmane.emacs.devel Subject: Re: msys-to-w32 (was: Building Emacs from a new MinGW environment) Date: Mon, 18 Nov 2013 08:38:20 +0100 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1384760302 14177 80.91.229.3 (18 Nov 2013 07:38:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Nov 2013 07:38:22 +0000 (UTC) To: Emacs development discussions Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 18 08:38:28 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ViJPf-0003rX-HF for ged-emacs-devel@m.gmane.org; Mon, 18 Nov 2013 08:38:27 +0100 Original-Received: from localhost ([::1]:41699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViJPf-0003PY-21 for ged-emacs-devel@m.gmane.org; Mon, 18 Nov 2013 02:38:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViJPb-0003PR-Q8 for emacs-devel@gnu.org; Mon, 18 Nov 2013 02:38:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViJPa-000443-So for emacs-devel@gnu.org; Mon, 18 Nov 2013 02:38:23 -0500 Original-Received: from mail-la0-x232.google.com ([2a00:1450:4010:c03::232]:44206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViJPa-000429-L1 for emacs-devel@gnu.org; Mon, 18 Nov 2013 02:38:22 -0500 Original-Received: by mail-la0-f50.google.com with SMTP id el20so4511562lab.37 for ; Sun, 17 Nov 2013 23:38:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=5uOpQjZSZpXZpvWOZnawj4a7F6/cjsxm3OlUCWCt3k4=; b=pFS4n6fOQrLqBeJ2ek5ZSDcQH4r6rNlVHi7Bne0F/sprgreEe85/zDzOalbeArsG5K WzeVl9awF73CgBCxKSZbWTOOYPi8GaSPg3UfkdZLzUtMw7ZqhkgM3gLMr9FC5vxLCrA7 cJyxYz2o7jYBAl0+HJ32rZcnmIzqadH6QIz+dOuw4N1OIL3OXDaZEfM+8LUbnMG2piNC 6v6V+3r3U4czF9ijKOjHbPsEEALZ2f0q+cwwjACuToqYDrmNzYOrL9k3gPr14qJ0GK5A k3MYXf/dt3ow+QDVD4VeO+67iWfnZlvAxvnDcf+Osa9WNcvl9J9CSMWyYPL/tpVIv+0i +45A== X-Received: by 10.152.121.3 with SMTP id lg3mr13302402lab.0.1384760300865; Sun, 17 Nov 2013 23:38:20 -0800 (PST) Original-Received: by 10.114.176.231 with HTTP; Sun, 17 Nov 2013 23:38:20 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165317 Archived-At: On Tue, Nov 12, 2013 at 9:08 AM, Dani Moncayo wrote: > Thanks for the code review, Glenn. > > I agree with your comments. See below the changes I've made. > > This is the new version of the whole patch, against trunk revno 115072: > > https://www.dropbox.com/s/lqgogbn6mrb2qs0/msys-to-w32.v4.diff There were no more comments about the above patch. How about committing it, please? -- Dani Moncayo