From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dani Moncayo Newsgroups: gmane.emacs.devel Subject: Re: Setting the value of `emacs-bzr-version' also from a git checkout Date: Tue, 1 Oct 2013 22:23:58 +0200 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1380659044 11858 80.91.229.3 (1 Oct 2013 20:24:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Oct 2013 20:24:04 +0000 (UTC) Cc: Sebastien Vauban , Emacs development discussions To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 01 22:24:08 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VR6UH-00018U-Uh for ged-emacs-devel@m.gmane.org; Tue, 01 Oct 2013 22:24:06 +0200 Original-Received: from localhost ([::1]:60875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR6UH-0004rN-FN for ged-emacs-devel@m.gmane.org; Tue, 01 Oct 2013 16:24:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR6UE-0004rI-85 for emacs-devel@gnu.org; Tue, 01 Oct 2013 16:24:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR6UD-0001kJ-1l for emacs-devel@gnu.org; Tue, 01 Oct 2013 16:24:02 -0400 Original-Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:34394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR6UB-0001jn-IL; Tue, 01 Oct 2013 16:23:59 -0400 Original-Received: by mail-la0-f43.google.com with SMTP id ep20so6288771lab.2 for ; Tue, 01 Oct 2013 13:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=M/7T53WM4oROhjfA3ufr9vhTHS06NgMi/I7Za7Qm13I=; b=aoOGukZ1KcVR8MCPK3ZOKu1OuTh6LKFR4XZ3RHCrA12UznHWCcqgMfCTizrNFlfr0N /Ef+fyeErjMFUe1lfg7Jp+49WV3sZ/cAyNhXFx9vpKQqIY4PNkYfSbNLNx70EgrGMDLV p09Y0pKAQF+BZv5m4fikGRO4amfIOvlUZVmckMuY+0A2CHOO7XJXonzKpgZJiZkWwMgF 0BSN3nSZhkCyUzjNrYuyan4KFNu8zleuETFIA1pu/fKxs1xoYcJ1xYJdRAx1n5JDVFi8 Cr5agd81CABkXfLNaCp+W4UQYCKh/8ah+isauz1DzLe/ArU8bBunk6hD3qlwOIw6w+Q4 IOXQ== X-Received: by 10.152.3.42 with SMTP id 10mr26860523laz.22.1380659038381; Tue, 01 Oct 2013 13:23:58 -0700 (PDT) Original-Received: by 10.114.176.231 with HTTP; Tue, 1 Oct 2013 13:23:58 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163782 Archived-At: >> It would be nice if I could specify the bzr revno manually, for >> example as a parameter to "configure" or "make", because having to >> keep using bzr just for this little thing would also be too bad. > > You need to set the value of emacs-bzr-version (a string) during > dumping. I see. As a temporary solution, I guess I could set that value hard-coded, like this: -------------------------------- diff --git a/lisp/loadup.el b/lisp/loadup.el index c32bd00..5c1daab 100644 --- a/lisp/loadup.el +++ b/lisp/loadup.el @@ -299,8 +299,7 @@ (string-to-number (substring name (length base) exelen)))) files))) - (setq emacs-bzr-version (condition-case nil (emacs-bzr-get-version) - (error nil))) + (setq emacs-bzr-version "rgm@gnu.org-20130925101746-8kz06nvtpjms0hy3") ;; `emacs-version' is a constant, so we shouldn't change it with `setq'. (defconst emacs-version (format "%s.%d" -------------------------------- But I hope that `emacs-bzr-get-version' could be adapted to try a second method when the primary one (the current one) fails. That second method would assume a git repo instead of a bzr one (Andreas showed how to get the bzr revid from a git repo). -- Dani Moncayo