From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dani Moncayo Newsgroups: gmane.emacs.bugs Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark Date: Tue, 28 Feb 2012 12:12:32 +0100 Message-ID: References: <83haycdnqt.fsf@gnu.org> <87399v2qsp.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1330427695 29060 80.91.229.3 (28 Feb 2012 11:14:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 28 Feb 2012 11:14:55 +0000 (UTC) Cc: 10899@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 28 12:14:54 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S2L1C-0000G1-9W for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Feb 2012 12:14:54 +0100 Original-Received: from localhost ([::1]:41315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2L1B-0006Gl-Io for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Feb 2012 06:14:53 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2L0r-0005YW-UK for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 06:14:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2L0l-00053W-I3 for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 06:14:33 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2L0f-00052F-8f; Tue, 28 Feb 2012 06:14:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S2L3G-000496-2l; Tue, 28 Feb 2012 06:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dani Moncayo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Tue, 28 Feb 2012 11:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10899 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: Original-Received: via spool by 10899-submit@debbugs.gnu.org id=B10899.133042777515874 (code B ref 10899); Tue, 28 Feb 2012 11:17:02 +0000 Original-Received: (at 10899) by debbugs.gnu.org; 28 Feb 2012 11:16:15 +0000 Original-Received: from localhost ([127.0.0.1]:60828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2L2G-00047H-QI for submit@debbugs.gnu.org; Tue, 28 Feb 2012 06:16:15 -0500 Original-Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:33435) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2L20-00046p-1O for 10899@debbugs.gnu.org; Tue, 28 Feb 2012 06:15:49 -0500 Original-Received: by obbeh20 with SMTP id eh20so2310368obb.3 for <10899@debbugs.gnu.org>; Tue, 28 Feb 2012 03:12:32 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@gmail.com designates 10.182.192.36 as permitted sender) client-ip=10.182.192.36; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@gmail.com designates 10.182.192.36 as permitted sender) smtp.mail=dmoncayo@gmail.com; dkim=pass header.i=dmoncayo@gmail.com Original-Received: from mr.google.com ([10.182.192.36]) by 10.182.192.36 with SMTP id hd4mr6521766obc.60.1330427552303 (num_hops = 1); Tue, 28 Feb 2012 03:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=wk0dwFvSQQvwCkMFQq1iMulIsqDbUZiLmtB1UI+Lr60=; b=w9FL0w/McKRic7NpIiXEfes9ezxutO5aRgZBMIUET+smFfNmjCrJlhQRGkS3YQ87CO I3OfBW/YXWa+eBhPWN5oPuWHhS0Q4H8Ye9hWS5n/t4+6ZtmsbwNjWBsGi+C599OWhy9r ZS5yk+x5I7svyy06fOjwJFlvxh6dZW5gIyqiI= Original-Received: by 10.182.192.36 with SMTP id hd4mr5801294obc.60.1330427552181; Tue, 28 Feb 2012 03:12:32 -0800 (PST) Original-Received: by 10.60.42.193 with HTTP; Tue, 28 Feb 2012 03:12:32 -0800 (PST) In-Reply-To: <87399v2qsp.fsf@mail.jurta.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57354 Archived-At: >> Summarizing: >> a. `c-forward-conditional' and `c-backward-conditional' should not set >> the mark, because each one has an inverse movement command. >> b. Even if you disagree, those commands should not set the mark when >> it is active. > > All similar movement commands like `c-beginning-of-defun' and `c-end-of-d= efun' > take precautions against the behavior you found. =A0They do this by using > the following condition before leaving mark behind: > > =A0(and transient-mark-mode mark-active) > > The patch below fixes the remaining movement commands to do the same, > except `c-mark-function' that needs to be rewritten to follow the logic > of `mark-defun' for setting the mark. Thanks Juri, for working on this and many other fixes/improvements to Emacs= . Regarding your patch, I think it clearly improve the current behavior, but I want to emphasize again that, IMO, setting the mark in too many commands is bad, because it overfills the mark ring, thus making harder to return to earlier positions. --=20 Dani Moncayo