From: Dani Moncayo <dmoncayo@gmail.com>
To: Juri Linkov <juri@jurta.org>
Cc: 10899@debbugs.gnu.org
Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark
Date: Tue, 28 Feb 2012 12:12:32 +0100 [thread overview]
Message-ID: <CAH8Pv0hu==OkPZJ0=03+yLLTzjxr49wFUJEYa0rQj=2uxjhSfQ@mail.gmail.com> (raw)
In-Reply-To: <87399v2qsp.fsf@mail.jurta.org>
>> Summarizing:
>> a. `c-forward-conditional' and `c-backward-conditional' should not set
>> the mark, because each one has an inverse movement command.
>> b. Even if you disagree, those commands should not set the mark when
>> it is active.
>
> All similar movement commands like `c-beginning-of-defun' and `c-end-of-defun'
> take precautions against the behavior you found. They do this by using
> the following condition before leaving mark behind:
>
> (and transient-mark-mode mark-active)
>
> The patch below fixes the remaining movement commands to do the same,
> except `c-mark-function' that needs to be rewritten to follow the logic
> of `mark-defun' for setting the mark.
Thanks Juri, for working on this and many other fixes/improvements to Emacs.
Regarding your patch, I think it clearly improve the current behavior,
but I want to emphasize again that, IMO, setting the mark in too many
commands is bad, because it overfills the mark ring, thus making
harder to return to earlier positions.
--
Dani Moncayo
next prev parent reply other threads:[~2012-02-28 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 19:06 bug#10899: 24.0.93; c-forward-conditional should not move the mark Dani Moncayo
2012-02-27 19:29 ` Dani Moncayo
2012-02-27 20:28 ` Eli Zaretskii
2012-02-27 20:59 ` Dani Moncayo
2012-02-28 7:42 ` Dani Moncayo
2012-02-28 10:30 ` Juri Linkov
2012-02-28 11:12 ` Dani Moncayo [this message]
2012-02-29 0:14 ` Juri Linkov
2012-02-28 21:59 ` Stefan Monnier
2020-08-25 12:34 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH8Pv0hu==OkPZJ0=03+yLLTzjxr49wFUJEYa0rQj=2uxjhSfQ@mail.gmail.com' \
--to=dmoncayo@gmail.com \
--cc=10899@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.