Failure in "make install" on MS-Windows

Failure in "make install" on MS-Windows

[Dani Moncayo]

Hi,

I've just tried to make a full bootstrap + "make install", on
MS-Windows and from the current trunk (last time I tried was 13 days
ago), and "make install" fails like this:

Installing utilities for users to run.
umask 022; /bin/mkdir -p
"/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/bin"
for file in runemacs.exe addpm.exe ; do \
  /bin/install -c  ${file}
"/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/bin"/`echo
${file} | sed -e 's/.exe$//' -e 's,x,x,'`.exe ; \
done
/bin/install -c -m 644 README.W32
"/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/share/emacs/24.3.50"
/bin/install: cannot stat `README.W32': No such file or directory
Makefile:168: recipe for target `install' failed
make[1]: *** [install] Error 1
make[1]: Leaving directory `/usr/home/dani/emacs/build/nt'
Makefile:509: recipe for target `install-nt' failed
make: *** [install-nt] Error 2


Commit 116425 is related to "README.W32", so the problem might come from there.

-- 
Dani Moncayo

bug#16772: Failure in "make install" on MS-Windows

[Juanma Barranquero]

Package: emacs
Version: 24.3.50

On Sun, Feb 16, 2014 at 10:23 PM, Dani Moncayo <dmoncayo@gmail.com> wrote:
> Hi,
>
> I've just tried to make a full bootstrap + "make install", on
> MS-Windows and from the current trunk (last time I tried was 13 days
> ago), and "make install" fails like this:

Why didn't you file a bug report for it?

> Installing utilities for users to run.
> umask 022; /bin/mkdir -p
> "/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/bin"
> for file in runemacs.exe addpm.exe ; do \
>   /bin/install -c  ${file}
> "/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/bin"/`echo
> ${file} | sed -e 's/.exe$//' -e 's,x,x,'`.exe ; \
> done
> /bin/install -c -m 644 README.W32
> "/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/share/emacs/24.3.50"
> /bin/install: cannot stat `README.W32': No such file or directory
> Makefile:168: recipe for target `install' failed
> make[1]: *** [install] Error 1
> make[1]: Leaving directory `/usr/home/dani/emacs/build/nt'
> Makefile:509: recipe for target `install-nt' failed
> make: *** [install-nt] Error 2
>
>
> Commit 116425 is related to "README.W32", so the problem might come from there.

I'm pretty sure that's the problem, yes.

Which directory is current when the "/bin/install ... README.32"
command is executed?

bug#16772: Failure in "make install" on MS-Windows

[Glenn Morris]

Juanma Barranquero wrote:

> Which directory is current when the "/bin/install ... README.32"
> command is executed?

I guess he's doing an out-of-tree build.
Prob you want

$(INSTALL_DATA) $(srcdir)/README.W32 ...


But why is this file being installed anyway?
Eg a POSIX build does not install the top-level README anywhere.

bug#16772: Failure in "make install" on MS-Windows

[Juanma Barranquero]

On Mon, Feb 17, 2014 at 3:20 AM, Glenn Morris <rgm@gnu.org> wrote:

> I guess he's doing an out-of-tree build.
> Prob you want
>
> $(INSTALL_DATA) $(srcdir)/README.W32 ...

Aha, I think you're right. Thanks!

Dani, could you please try this patch?

=== modified file 'nt/Makefile.in'
--- nt/Makefile.in 2014-02-13 03:19:57 +0000
+++ nt/Makefile.in 2014-02-17 02:37:26 +0000
@@ -172,5 +172,5 @@
   $(INSTALL_PROGRAM) $(INSTALL_STRIP) $${file}
"$(DESTDIR)${bindir}"/`echo $${file} | sed -e 's/${EXEEXT}$$//' -e
'$(TRANSFORM)'`${EXEEXT} ; \
  done
- $(INSTALL_DATA) README.W32 "$(DESTDIR)${datadir}/emacs/$(version)"
+ $(INSTALL_DATA) $(srcdir)/README.W32 "$(DESTDIR)${datadir}/emacs/$(version)"

 uninstall:


> But why is this file being installed anyway?
> Eg a POSIX build does not install the top-level README anywhere.

Drew asked for it, and Eli suggested the share/emacs/VERSION location.

IMO including it is a good idea, because nt/README.W32 is not related
to building Emacs on Windows, but installing it (where to find image,
GnuTLS and libxml2 libraries, running Emacs on Windows 9X, describing
the different programs) and uninstalling it.

Re: Failure in "make install" on MS-Windows

[Eli Zaretskii]

> Date: Sun, 16 Feb 2014 22:23:06 +0100
> From: Dani Moncayo <dmoncayo@gmail.com>
> 
> /bin/install -c -m 644 README.W32
> "/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/share/emacs/24.3.50"
> /bin/install: cannot stat `README.W32': No such file or directory

Does the target directory
"/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/share/emacs/24.3.50"
exist at that point?

bug#16772: Failure in "make install" on MS-Windows

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Sun, 16 Feb 2014 21:20:16 -0500
> Cc: 16772@debbugs.gnu.org
> 
> But why is this file being installed anyway?

Because Windows users need instructions on how to set up their Emacs,
when they have just unpacked precompiled binaries.

This file was always in the Windows binary distro, but it was always
copied by hand.  Since the binary zip is made from the installation
tree, the file needs to be there, or else it will be forgotten (as it
have been already).

bug#16772: Failure in "make install" on MS-Windows

[Dani Moncayo]

>> I've just tried to make a full bootstrap + "make install", on
>> MS-Windows and from the current trunk (last time I tried was 13 days
>> ago), and "make install" fails like this:
>
> Why didn't you file a bug report for it?

ISTR some maintainer (Glenn?) saying that people should not file bug
reports about obvious build failures, because they are likely to be
noticed and fixed soon.

>> Commit 116425 is related to "README.W32", so the problem might come from there.
>
> I'm pretty sure that's the problem, yes.
>
> Which directory is current when the "/bin/install ... README.32"
> command is executed?

At that moment, the current directory is that of the current makefile.
 In this case is "/usr/home/dani/emacs/build/nt".

-- 
Dani Moncayo

Re: Failure in "make install" on MS-Windows

[Dani Moncayo]

On Mon, Feb 17, 2014 at 5:45 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Sun, 16 Feb 2014 22:23:06 +0100
>> From: Dani Moncayo <dmoncayo@gmail.com>
>>
>> /bin/install -c -m 644 README.W32
>> "/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/share/emacs/24.3.50"
>> /bin/install: cannot stat `README.W32': No such file or directory
>
> Does the target directory
> "/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/share/emacs/24.3.50"
> exist at that point?

Yes, it does.

-- 
Dani Moncayo

bug#16772: Failure in "make install" on MS-Windows

[Dani Moncayo]

> Dani, could you please try this patch?
>
> === modified file 'nt/Makefile.in'
> --- nt/Makefile.in 2014-02-13 03:19:57 +0000
> +++ nt/Makefile.in 2014-02-17 02:37:26 +0000
> @@ -172,5 +172,5 @@
>    $(INSTALL_PROGRAM) $(INSTALL_STRIP) $${file}
> "$(DESTDIR)${bindir}"/`echo $${file} | sed -e 's/${EXEEXT}$$//' -e
> '$(TRANSFORM)'`${EXEEXT} ; \
>   done
> - $(INSTALL_DATA) README.W32 "$(DESTDIR)${datadir}/emacs/$(version)"
> + $(INSTALL_DATA) $(srcdir)/README.W32 "$(DESTDIR)${datadir}/emacs/$(version)"
>
>  uninstall:

I've tried the patch:  I've gone to the build directory and done "make
install prefix='../myinstalldir' GZIP_INFO= GZIP_PROG=".  The process
has ended up this way:

Installing utilities for users to run.
umask 022; /bin/mkdir -p "../myinstalldir/bin"
for file in runemacs.exe addpm.exe ; do \
  /bin/install -c  ${file} "../myinstalldir/bin"/`echo ${file} | sed
-e 's/.exe$//' -e 's,x,x,'`.exe ; \
done
/bin/install -c -m 644 /C/msys/home/dani/emacs/repo/nt/README.W32
"../myinstalldir/share/emacs/24.3.50"
/bin/install: cannot create regular file
`../myinstalldir/share/emacs/24.3.50': No such file or directory
Makefile:168: recipe for target `install' failed
make[1]: *** [install] Error 1
make[1]: Leaving directory `/usr/home/dani/emacs/build/nt'
Makefile:509: recipe for target `install-nt' failed
make: *** [install-nt] Error 2

The problem, I think, is that $(DESTDIR) contains literally the prefix
I gave ("../myinstalldir"), which is a relative path (to the "current"
directory - at the moment of the "make install"), but since we are now
in "nt/Makefile", the current working directory is "<build-dir>/nt",
and therefore, relative references like this one don't refer to the
intended location.

If I specify an absolute path as prefix in "make install", the the
process seems to complete successfully.

-- 
Dani Moncayo

bug#16772: Failure in "make install" on MS-Windows

[Juanma Barranquero]

On Mon, Feb 17, 2014 at 12:42 PM, Dani Moncayo <dmoncayo@gmail.com> wrote:

> ISTR some maintainer (Glenn?) saying that people should not file bug
> reports about obvious build failures, because they are likely to be
> noticed and fixed soon.

That would be an argument for not reporting them anywhere, not the bug
tracker, not emacs-devel.

But anyway, not many people builds on Windows, so build failures can
go unnoticed. I certainly built & installed (and bootstrapped &
installed) before commiting the change, but my builds are all in-place
and I missed this bug. So, yes, for Windows building failures I'd
recommend filing bug reports.

   J

bug#16772: Failure in "make install" on MS-Windows

[Juanma Barranquero]

On Mon, Feb 17, 2014 at 12:42 PM, Dani Moncayo <dmoncayo@gmail.com> wrote:

> The problem, I think, is that $(DESTDIR) contains literally the prefix
> I gave ("../myinstalldir"), which is a relative path (to the "current"
> directory - at the moment of the "make install"), but since we are now
> in "nt/Makefile", the current working directory is "<build-dir>/nt",
> and therefore, relative references like this one don't refer to the
> intended location.

Why would then work the other commands in the install target?

        umask 022; ${MKDIR_P} "$(DESTDIR)${bindir}"
        for file in ${INSTALLABLES} ; do \
          $(INSTALL_PROGRAM) $(INSTALL_STRIP) $${file}
"$(DESTDIR)${bindir}"/`echo $${file} | sed -e 's/${EXEEXT}$$//' -e
'$(TRANSFORM)'`${EXEEXT} ; \
        done

bug#16772: Failure in "make install" on MS-Windows

[Eli Zaretskii]

> Date: Mon, 17 Feb 2014 12:42:52 +0100
> From: Dani Moncayo <dmoncayo@gmail.com>
> Cc: 16772@debbugs.gnu.org
> 
> /bin/install -c -m 644 /C/msys/home/dani/emacs/repo/nt/README.W32
> "../myinstalldir/share/emacs/24.3.50"
> /bin/install: cannot create regular file
> `../myinstalldir/share/emacs/24.3.50': No such file or directory
> Makefile:168: recipe for target `install' failed
> make[1]: *** [install] Error 1
> make[1]: Leaving directory `/usr/home/dani/emacs/build/nt'
> Makefile:509: recipe for target `install-nt' failed
> make: *** [install-nt] Error 2
> 
> The problem, I think, is that $(DESTDIR) contains literally the prefix
> I gave ("../myinstalldir"), which is a relative path (to the "current"
> directory - at the moment of the "make install"), but since we are now
> in "nt/Makefile", the current working directory is "<build-dir>/nt",
> and therefore, relative references like this one don't refer to the
> intended location.
> 
> If I specify an absolute path as prefix in "make install", the the
> process seems to complete successfully.

Don't specify relative file names in DESTDIR, that's not supported.
From the GNU Coding Standards:

  7.2.4 `DESTDIR': Support for Staged Installs
  --------------------------------------------

  `DESTDIR' is a variable prepended to each installed target file, like
  this:

       $(INSTALL_PROGRAM) foo $(DESTDIR)$(bindir)/foo
       $(INSTALL_DATA) libfoo.a $(DESTDIR)$(libdir)/libfoo.a

     The `DESTDIR' variable is specified by the user on the `make'
  command line as an absolute file name.  For example:
               ^^^^^^^^^^^^^^^^^^^^^^^^
       make DESTDIR=/tmp/stage install

bug#16772: Failure in "make install" on MS-Windows

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Mon, 17 Feb 2014 13:38:40 +0100
> Cc: 16772@debbugs.gnu.org
> 
> On Mon, Feb 17, 2014 at 12:42 PM, Dani Moncayo <dmoncayo@gmail.com> wrote:
> 
> > The problem, I think, is that $(DESTDIR) contains literally the prefix
> > I gave ("../myinstalldir"), which is a relative path (to the "current"
> > directory - at the moment of the "make install"), but since we are now
> > in "nt/Makefile", the current working directory is "<build-dir>/nt",
> > and therefore, relative references like this one don't refer to the
> > intended location.
> 
> Why would then work the other commands in the install target?

Presumably because those directories somehow did exist beforehand.

Anyway, DESTDIR must be an absolute file name, see my other mail.

bug#16772: Failure in "make install" on MS-Windows

[Juanma Barranquero]

On Mon, Feb 17, 2014 at 3:49 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> Anyway, DESTDIR must be an absolute file name, see my other mail.

Closing this bug, then. Thanks.

bug#16772: Failure in "make install" on MS-Windows

[Dani Moncayo]

>> Anyway, DESTDIR must be an absolute file name, see my other mail.

Silly limitation, I think.  But fair enough.

> Closing this bug, then. Thanks.

Ok, but at least your patch for "nt/Makefile.in" is required for
out-of-tree, MS-Windows builds to work.

-- 
Dani Moncayo

bug#16772: Failure in "make install" on MS-Windows

[Dani Moncayo]

> I've tried the patch:  I've gone to the build directory and done "make
> install prefix='../myinstalldir' GZIP_INFO= GZIP_PROG=".  The process
> has ended up this way:
>
> Installing utilities for users to run.
> umask 022; /bin/mkdir -p "../myinstalldir/bin"
> for file in runemacs.exe addpm.exe ; do \
>   /bin/install -c  ${file} "../myinstalldir/bin"/`echo ${file} | sed
> -e 's/.exe$//' -e 's,x,x,'`.exe ; \
> done
> /bin/install -c -m 644 /C/msys/home/dani/emacs/repo/nt/README.W32
> "../myinstalldir/share/emacs/24.3.50"
> /bin/install: cannot create regular file
> `../myinstalldir/share/emacs/24.3.50': No such file or directory
> Makefile:168: recipe for target `install' failed
> make[1]: *** [install] Error 1
> make[1]: Leaving directory `/usr/home/dani/emacs/build/nt'
> Makefile:509: recipe for target `install-nt' failed
> make: *** [install-nt] Error 2
>
> The problem, I think, is that $(DESTDIR) contains literally the prefix
> I gave ("../myinstalldir"),

After some more tests, what seems to happen is that the "DESTDIR" make
variable is empty during the evaluation of the "install" target in
"nt/Makefile" ("${datadir}" is what produces "../myinstalldir/share").


-- 
Dani Moncayo

bug#16772: Failure in "make install" on MS-Windows

[Juanma Barranquero]

reopen 16772
quit

On Mon, Feb 17, 2014 at 4:06 PM, Dani Moncayo <dmoncayo@gmail.com> wrote:

> After some more tests, what seems to happen is that the "DESTDIR" make
> variable is empty during the evaluation of the "install" target in
> "nt/Makefile" ("${datadir}" is what produces "../myinstalldir/share").

What are the values of $(bindir), $(datarootdir) and $(libexecdir)?

bug#16772: Failure in "make install" on MS-Windows

[Dani Moncayo]

> What are the values of $(bindir), $(datarootdir) and $(libexecdir)?

bindir=../myinstalldir/bin
datarootdir=../myinstalldir/share
libexecdir=../myinstalldir/libexec


-- 
Dani Moncayo

bug#16772: Failure in "make install" on MS-Windows

[Eli Zaretskii]

> Date: Mon, 17 Feb 2014 16:06:52 +0100
> From: Dani Moncayo <dmoncayo@gmail.com>
> Cc: 16772@debbugs.gnu.org
> 
> > I've tried the patch:  I've gone to the build directory and done "make
> > install prefix='../myinstalldir' GZIP_INFO= GZIP_PROG=".  The process
> > has ended up this way:
> >
> > Installing utilities for users to run.
> > umask 022; /bin/mkdir -p "../myinstalldir/bin"
> > for file in runemacs.exe addpm.exe ; do \
> >   /bin/install -c  ${file} "../myinstalldir/bin"/`echo ${file} | sed
> > -e 's/.exe$//' -e 's,x,x,'`.exe ; \
> > done
> > /bin/install -c -m 644 /C/msys/home/dani/emacs/repo/nt/README.W32
> > "../myinstalldir/share/emacs/24.3.50"
> > /bin/install: cannot create regular file
> > `../myinstalldir/share/emacs/24.3.50': No such file or directory
> > Makefile:168: recipe for target `install' failed
> > make[1]: *** [install] Error 1
> > make[1]: Leaving directory `/usr/home/dani/emacs/build/nt'
> > Makefile:509: recipe for target `install-nt' failed
> > make: *** [install-nt] Error 2
> >
> > The problem, I think, is that $(DESTDIR) contains literally the prefix
> > I gave ("../myinstalldir"),
> 
> After some more tests, what seems to happen is that the "DESTDIR" make
> variable is empty during the evaluation of the "install" target in
> "nt/Makefile" ("${datadir}" is what produces "../myinstalldir/share").

Sorry, I don't understand: did you specify DESTDIR, or didn't you?  If
you did, please show the full "make install" command line you used.

bug#16772: Failure in "make install" on MS-Windows

[Dani Moncayo]

> Sorry, I don't understand: did you specify DESTDIR, or didn't you?  If
> you did, please show the full "make install" command line you used.

As I said:

>> > I've tried the patch:  I've gone to the build directory and done "make
>> > install prefix='../myinstalldir' GZIP_INFO= GZIP_PROG=".  The process
>> > has ended up this way:

AFAIK, this is the way to specify the destination directory in "make
install" (using the "prefix" parameter).

-- 
Dani Moncayo

bug#16772: Failure in "make install" on MS-Windows

[Juanma Barranquero]

On Mon, Feb 17, 2014 at 4:29 PM, Dani Moncayo <dmoncayo@gmail.com> wrote:

> bindir=../myinstalldir/bin
> datarootdir=../myinstalldir/share
> libexecdir=../myinstalldir/libexec

The value of $(datadir) you reported, "../myinstalldir/share" is
consistent with these values.

Perhaps it's simply that the directory hasn't been created yet. Try

=== modified file 'nt/Makefile.in'
--- nt/Makefile.in 2014-02-13 03:19:57 +0000
+++ nt/Makefile.in 2014-02-17 15:38:27 +0000
@@ -172,4 +172,5 @@
   $(INSTALL_PROGRAM) $(INSTALL_STRIP) $${file}
"$(DESTDIR)${bindir}"/`echo $${file} | sed -e 's/${EXEEXT}$$//' -e
'$(TRANSFORM)'`${EXEEXT} ; \
  done
+ ${MKDIR_P} "$(DESTDIR)${datadir}/emacs/$(version)"
  $(INSTALL_DATA) README.W32 "$(DESTDIR)${datadir}/emacs/$(version)"

bug#16772: Failure in "make install" on MS-Windows

[Eli Zaretskii]

> Date: Mon, 17 Feb 2014 16:33:53 +0100
> From: Dani Moncayo <dmoncayo@gmail.com>
> Cc: Juanma Barranquero <lekktu@gmail.com>, 16772@debbugs.gnu.org
> 
> > Sorry, I don't understand: did you specify DESTDIR, or didn't you?  If
> > you did, please show the full "make install" command line you used.
> 
> As I said:
> 
> >> > I've tried the patch:  I've gone to the build directory and done "make
> >> > install prefix='../myinstalldir' GZIP_INFO= GZIP_PROG=".  The process
> >> > has ended up this way:

There's no DESTDIR anywhere in sight here.

> AFAIK, this is the way to specify the destination directory in "make
> install" (using the "prefix" parameter).

You explicitly mentioned DESTDIR, not "destination directory":

> The problem, I think, is that $(DESTDIR) contains literally the prefix
> I gave ("../myinstalldir"), which is a relative path (to the "current"
> directory - at the moment of the "make install"), but since we are now
> in "nt/Makefile", the current working directory is "<build-dir>/nt",
> and therefore, relative references like this one don't refer to the
> intended location.

So I thought you were using DESTDIR on the Make command line.  It now
turns out you didn't use DESTDIR at all.

You also said that the target directory existed when the error was
reported:

> On Mon, Feb 17, 2014 at 5:45 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >> Date: Sun, 16 Feb 2014 22:23:06 +0100
> >> From: Dani Moncayo <dmoncayo@gmail.com>
> >>
> >> /bin/install -c -m 644 README.W32
> >> "/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/share/emacs/24.3.50"
> >> /bin/install: cannot stat `README.W32': No such file or directory
> >
> > Does the target directory
> > "/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/share/emacs/24.3.50"
> > exist at that point?
> 
> Yes, it does.

So how come now it does NOT exist?

bug#16772: Failure in "make install" on MS-Windows

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Mon, 17 Feb 2014 16:39:07 +0100
> Cc: 16772@debbugs.gnu.org
> 
> On Mon, Feb 17, 2014 at 4:29 PM, Dani Moncayo <dmoncayo@gmail.com> wrote:
> 
> > bindir=../myinstalldir/bin
> > datarootdir=../myinstalldir/share
> > libexecdir=../myinstalldir/libexec
> 
> The value of $(datadir) you reported, "../myinstalldir/share" is
> consistent with these values.
> 
> Perhaps it's simply that the directory hasn't been created yet. Try
> 
> === modified file 'nt/Makefile.in'
> --- nt/Makefile.in 2014-02-13 03:19:57 +0000
> +++ nt/Makefile.in 2014-02-17 15:38:27 +0000
> @@ -172,4 +172,5 @@
>    $(INSTALL_PROGRAM) $(INSTALL_STRIP) $${file}
> "$(DESTDIR)${bindir}"/`echo $${file} | sed -e 's/${EXEEXT}$$//' -e
> '$(TRANSFORM)'`${EXEEXT} ; \
>   done
> + ${MKDIR_P} "$(DESTDIR)${datadir}/emacs/$(version)"
>   $(INSTALL_DATA) README.W32 "$(DESTDIR)${datadir}/emacs/$(version)"

Previously, Dani said this directory already existed when the error
was reported.

bug#16772: Failure in "make install" on MS-Windows

[Juanma Barranquero]

On Mon, Feb 17, 2014 at 4:58 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> Previously, Dani said this directory already existed when the error
> was reported.

Well, yes, but this

> /bin/install: cannot create regular file
> `../myinstalldir/share/emacs/24.3.50': No such file or directory

seems pretty clear.

bug#16772: Failure in "make install" on MS-Windows

[Dani Moncayo]

>> > Sorry, I don't understand: did you specify DESTDIR, or didn't you?  If
>> > you did, please show the full "make install" command line you used.
>>
>> As I said:
>>
>> >> > I've tried the patch:  I've gone to the build directory and done "make
>> >> > install prefix='../myinstalldir' GZIP_INFO= GZIP_PROG=".  The process
>> >> > has ended up this way:
>
> There's no DESTDIR anywhere in sight here.

There isn't, no.  (and?)

>> AFAIK, this is the way to specify the destination directory in "make
>> install" (using the "prefix" parameter).
>
> You explicitly mentioned DESTDIR, not "destination directory":

Because DESTDIR is the name of a make variable, which is employed in
the sentence which failed in my original bug report (file
"nt/Makefile.in", target "install"):
  $(INSTALL_DATA) README.W32 "$(DESTDIR)${datadir}/emacs/$(version)"

When I try to show the value of that variable, at that point, it seems
to be empty (which seems like a bug).

>> The problem, I think, is that $(DESTDIR) contains literally the prefix
>> I gave ("../myinstalldir"), which is a relative path (to the "current"
>> directory - at the moment of the "make install"), but since we are now
>> in "nt/Makefile", the current working directory is "<build-dir>/nt",
>> and therefore, relative references like this one don't refer to the
>> intended location.
>
> So I thought you were using DESTDIR on the Make command line.  It now
> turns out you didn't use DESTDIR at all.

No, I didn't.  Sorry if I said something that confused you, but AFAIK,
I don't have to set that variable anywere.

> You also said that the target directory existed when the error was
> reported:
>
>> On Mon, Feb 17, 2014 at 5:45 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> >> Date: Sun, 16 Feb 2014 22:23:06 +0100
>> >> From: Dani Moncayo <dmoncayo@gmail.com>
>> >>
>> >> /bin/install -c -m 644 README.W32
>> >> "/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/share/emacs/24.3.50"
>> >> /bin/install: cannot stat `README.W32': No such file or directory
>> >
>> > Does the target directory
>> > "/usr/home/dani/emacs/install/emacs-r116453-20140216-w32-bin/share/emacs/24.3.50"
>> > exist at that point?
>>
>> Yes, it does.
>
> So how come now it does NOT exist?

When I checked, I think it existed, but I'm going crazy with so many tests...

I'd suggest you to try to reproduce this yourself.  But failing that,
I'll do it later today...

-- 
Dani Moncayo

bug#16772: Failure in "make install" on MS-Windows

[Eli Zaretskii]

> Date: Mon, 17 Feb 2014 17:16:06 +0100
> From: Dani Moncayo <dmoncayo@gmail.com>
> Cc: Juanma Barranquero <lekktu@gmail.com>, 16772@debbugs.gnu.org
> 
> >> > Sorry, I don't understand: did you specify DESTDIR, or didn't you?  If
> >> > you did, please show the full "make install" command line you used.
> >>
> >> As I said:
> >>
> >> >> > I've tried the patch:  I've gone to the build directory and done "make
> >> >> > install prefix='../myinstalldir' GZIP_INFO= GZIP_PROG=".  The process
> >> >> > has ended up this way:
> >
> > There's no DESTDIR anywhere in sight here.
> 
> There isn't, no.  (and?)

And you said its value was ../myinstalldir, which cannot possibly
happen unless you set this variable directly from the command line.

> >> AFAIK, this is the way to specify the destination directory in "make
> >> install" (using the "prefix" parameter).
> >
> > You explicitly mentioned DESTDIR, not "destination directory":
> 
> Because DESTDIR is the name of a make variable, which is employed in
> the sentence which failed in my original bug report (file
> "nt/Makefile.in", target "install"):
>   $(INSTALL_DATA) README.W32 "$(DESTDIR)${datadir}/emacs/$(version)"
> 
> When I try to show the value of that variable, at that point, it seems
> to be empty (which seems like a bug).

It's not a bug: when this variable is not set explicitly on the Make
command line, it should indeed be empty.

> >> The problem, I think, is that $(DESTDIR) contains literally the prefix
> >> I gave ("../myinstalldir"), which is a relative path (to the "current"
> >> directory - at the moment of the "make install"), but since we are now
> >> in "nt/Makefile", the current working directory is "<build-dir>/nt",
> >> and therefore, relative references like this one don't refer to the
> >> intended location.
> >
> > So I thought you were using DESTDIR on the Make command line.  It now
> > turns out you didn't use DESTDIR at all.
> 
> No, I didn't.  Sorry if I said something that confused you, but AFAIK,
> I don't have to set that variable anywere.

If DESTDIR is not empty, it means you have set it.

> I'd suggest you to try to reproduce this yourself.  But failing that,
> I'll do it later today...

Better try the patch suggested by Juanma.

bug#16772: Failure in "make install" on MS-Windows

[Glenn Morris]

Dani Moncayo wrote:

> I've tried the patch:  I've gone to the build directory and done "make
> install prefix='../myinstalldir' GZIP_INFO= GZIP_PROG=".  The process
> has ended up this way:

Don't change `prefix' at install time.
You should only set prefix with configure.
And if you try, it will say:

  configure: error: expected an absolute directory name for --prefix:
    ../myinstalldir

It's DESTDIR that you may change at install time:

https://www.gnu.org/prep/standards/html_node/DESTDIR.html

And as has been said, that should be absolute too.

bug#16772: Failure in "make install" on MS-Windows

[Dani Moncayo]

>> I've tried the patch:  I've gone to the build directory and done "make
>> install prefix='../myinstalldir' GZIP_INFO= GZIP_PROG=".  The process
>> has ended up this way:
>
> Don't change `prefix' at install time.
> You should only set prefix with configure.

I'm following the procedure documented in "nt/INSTALL", which says this:

  4. Install the produced binaries:

       make install

     If you want the installation tree to go to a place that is
     different from the one specified by --prefix, say

       make install prefix=/where/ever/you/want

If that procedure is wrong, please fix it.  But FWIW, I've
successfully made many binary distributions in the last months
following that same procedure.

> And if you try, it will say:
>
>   configure: error: expected an absolute directory name for --prefix:
>     ../myinstalldir

No, it says something different: I've just tried this, from a build
directory holding a bootstrap of the trunk (r116453):

  make install prefix=/c/tmp/dir2 GZIP_INFO= GZIP_PROG=

The make process, after writing many messages to the terminal, has
failed with this snippet:

  Installing utilities for users to run.
  umask 022; /bin/mkdir -p "/c/tmp/dir2/bin"
  for file in runemacs.exe addpm.exe ; do \
    /bin/install -c  ${file} "/c/tmp/dir2/bin"/`echo ${file} | sed -e
's/.exe$//' -e 's,x,x,'`.exe ; \
  done
  /bin/install -c -m 644 README.W32 "/c/tmp/dir2/share/emacs/24.3.50"
  /bin/install: cannot stat `README.W32': No such file or directory
  Makefile:168: recipe for target `install' failed
  make[1]: *** [install] Error 1
  make[1]: Leaving directory `/usr/home/dani/emacs/build/nt'
  Makefile:509: recipe for target `install-nt' failed
  make: *** [install-nt] Error 2

And then I've applied the patch sent by Juanma, and tried again.  This
time the installation seems to be successful, and I see the file
"<my-install-dir>/share/emacs/24.3.50/README.W32", as expected.

So please, Juanma, could you commit your patch?  TIA


-- 
Dani Moncayo

bug#16772: Failure in "make install" on MS-Windows

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Mon, 17 Feb 2014 13:00:43 -0500
> Cc: 16772@debbugs.gnu.org, Juanma Barranquero <lekktu@gmail.com>
> 
> Don't change `prefix' at install time.
> You should only set prefix with configure.

IMNSHO, there's nothing wrong with

   make install prefix=/foo/bar

I have yet to see a package that doesn't support that.

bug#16772: Failure in "make install" on MS-Windows

[Glenn Morris]

Eli Zaretskii wrote:

>    make install prefix=/foo/bar
>
> I have yet to see a package that doesn't support that.

Oh, OK. Seems weird to me though.
Why did GNU invent DESTDIR then?

bug#16772: Failure in "make install" on MS-Windows

[Dani Moncayo]

> And then I've applied the patch sent by Juanma, and tried again.  This
> time the installation seems to be successful, and I see the file
> "<my-install-dir>/share/emacs/24.3.50/README.W32", as expected.
>
> So please, Juanma, could you commit your patch?  TIA

I mean this patch (I've just realized that you sent two):

=== modified file 'nt/Makefile.in'
--- nt/Makefile.in      2014-02-13 03:19:57 +0000
+++ nt/Makefile.in      2014-02-17 18:50:35 +0000
@@ -171,7 +171,7 @@
        for file in ${INSTALLABLES} ; do \
          $(INSTALL_PROGRAM) $(INSTALL_STRIP) $${file}
"$(DESTDIR)${bindir}"/`echo $${file} | sed -e 's/${EXEEXT}$$//' -
e '$(TRANSFORM)'`${EXEEXT} ; \
        done
-       $(INSTALL_DATA) README.W32 "$(DESTDIR)${datadir}/emacs/$(version)"
+       $(INSTALL_DATA) ${srcdir}/README.W32
"$(DESTDIR)${datadir}/emacs/$(version)"

 uninstall:
        rm -f "$(DESTDIR)${datadir}/emacs/$(version)/README.W32"



-- 
Dani Moncayo

bug#16772: Failure in "make install" on MS-Windows

[Juanma Barranquero]

On Mon, Feb 17, 2014 at 8:01 PM, Dani Moncayo <dmoncayo@gmail.com> wrote:

> I mean this patch (I've just realized that you sent two):

Ha, too late. I've commited both. I think both make sense.

Closing (again),

    J

bug#16772: Failure in "make install" on MS-Windows

[Glenn Morris]

Dani Moncayo wrote:

>      If you want the installation tree to go to a place that is
>      different from the one specified by --prefix, say
>
>        make install prefix=/where/ever/you/want

Seems weird to me for Emacs to be recommending that.
Why would one not specify the right prefix at configure time...?

>> And if you try, it will say:
>>
>>   configure: error: expected an absolute directory name for --prefix:
>>     ../myinstalldir
>
> No, it says something different: I've just tried this
[...]
>   make install prefix=/c/tmp/dir2 GZIP_INFO= GZIP_PROG=

We seem to be having a failure to communicate.

"I ran make install with an absolute prefix" has no relevance to
"Here's what happens if you run configure with a relative prefix"

> And then I've applied the patch sent by Juanma, and tried again.  This
> time the installation seems to be successful, and I see the file
> "<my-install-dir>/share/emacs/24.3.50/README.W32", as expected.

Hooray.

bug#16772: Failure in "make install" on MS-Windows

[Dani Moncayo]

>> I mean this patch (I've just realized that you sent two):
>
> Ha, too late. I've commited both. I think both make sense.
>
> Closing (again),

Thank you Juanma, but I must say that the version that I've
successfully tested doesn't includes this line:

  ${MKDIR_P} "$(DESTDIR)${datadir}/emacs/$(version)"

which you've added to "nt/Makefile.in".

-- 
Dani Moncayo

bug#16772: Failure in "make install" on MS-Windows

[Glenn Morris]

Glenn Morris wrote:

>>    make install prefix=/foo/bar
[...]
> Oh, OK. Seems weird to me though.
> Why did GNU invent DESTDIR then?

For the record, I see my questions are answered in

http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Installation-Names.html

bug#16772: Failure in "make install" on MS-Windows

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Mon, 17 Feb 2014 14:06:53 -0500
> Cc: 16772@debbugs.gnu.org, Juanma Barranquero <lekktu@gmail.com>
> 
> Dani Moncayo wrote:
> 
> >      If you want the installation tree to go to a place that is
> >      different from the one specified by --prefix, say
> >
> >        make install prefix=/where/ever/you/want
> 
> Seems weird to me for Emacs to be recommending that.
> Why would one not specify the right prefix at configure time...?

The above doesn't change the configure-time prefix, as far as
directories recorded in the binaries are concerned.  It just installs
under a different tree root.

It is convenient to do that when you are preparing a binary
distribution, because you then create a tree that includes a single
package.

The reason nt/INSTALL recommends this technique, as opposed to
DESTDIR, is because that is what I use.  And the reason I prefer not
to use DESTDIR is that it fails on Windows if --prefix specified a
Windows style absolute file name, as in --prefix=d:/usr, because you
cannot prepend any non-empty string to that without producing an
invalid file name.

bug#16772: Failure in "make install" on MS-Windows

[Juanma Barranquero]

On Mon, Feb 17, 2014 at 8:09 PM, Dani Moncayo <dmoncayo@gmail.com> wrote:

> Thank you Juanma, but I must say that the version that I've
> successfully tested doesn't includes this line:
>
>   ${MKDIR_P} "$(DESTDIR)${datadir}/emacs/$(version)"
>
> which you've added to "nt/Makefile.in".

No problem. Making sure that the target directory exists seems sensible anyway.