bug#58979: treesitter-regression with json-mode

bug#58979: treesitter-regression with json-mode

[Johann Höchtl]

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

When I open a large json file (about 3_000_000 lines, about 72Mb,
pretty-printed) Emacs 29.0.50 opens the file just fine in `js-json-mode`
and when using regexp-based font locking, it works well.

When I force this buffer into javascript-mode, Emacs hangs. Memory
consumption as reported by Windows task manager "dances" around 2Gb, yet
even after waiting for three minutes, Emacs doesn't get responsive any more.

I consider this an unfortunately regression as recent commits to Emacs 29
(long lines patches) actually makes working with such large files with long
lines absolutely pleasant, yet as it seems the interaction with tree-sitter
destroys this gains.

[-- Attachment #2: Type: text/html, Size: 750 bytes --]

bug#58981: treesitter-regression with json-mode

[Johann Höchtl]

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]

Sorry, disregard, behavior is caused by plugin highlight-indent-guides

Am Mi., 2. Nov. 2022 um 17:16 Uhr schrieb Johann Höchtl <
johann.hoechtl@gmail.com>:

> When I open a large json file (about 3_000_000 lines, about 72Mb,
> pretty-printed) Emacs 29.0.50 opens the file just fine in `js-json-mode`
> and when using regexp-based font locking, it works well.
>
> When I force this buffer into javascript-mode, Emacs hangs. Memory
> consumption as reported by Windows task manager "dances" around 2Gb, yet
> even after waiting for three minutes, Emacs doesn't get responsive any more.
>
> I consider this an unfortunately regression as recent commits to Emacs 29
> (long lines patches) actually makes working with such large files with long
> lines absolutely pleasant, yet as it seems the interaction with tree-sitter
> destroys this gains.
>

[-- Attachment #2: Type: text/html, Size: 1194 bytes --]

bug#58981: treesitter-regression with json-mode

[Robert Pluim]

tags 58981 notabug
close 58981 29.1
quit

>>>>> On Wed, 2 Nov 2022 17:48:24 +0100, Johann Höchtl <johann.hoechtl@gmail.com> said:

    Johann> Sorry, disregard, behavior is caused by plugin highlight-indent-guides

Closing, thanks.

Robert

bug#58979: treesitter-regression with json-mode

[Stefan Kangas]

Johann Höchtl <johann.hoechtl@gmail.com> writes:

> When I open a large json file (about 3_000_000 lines, about 72Mb,
> pretty-printed) Emacs 29.0.50 opens the file just fine in
> `js-json-mode` and when using regexp-based font locking, it works
> well.
>
> When I force this buffer into javascript-mode, Emacs hangs. Memory
> consumption as reported by Windows task manager "dances" around 2Gb,
> yet even after waiting for three minutes, Emacs doesn't get responsive
> any more.
>
> I consider this an unfortunately regression as recent commits to Emacs
> 29 (long lines patches) actually makes working with such large files
> with long lines absolutely pleasant, yet as it seems the interaction
> with tree-sitter destroys this gains.

Copying in Yuan Fu.

bug#58979: treesitter-regression with json-mode

[Yuan Fu]

Stefan Kangas <stefankangas@gmail.com> writes:

> Johann Höchtl <johann.hoechtl@gmail.com> writes:
>
>> When I open a large json file (about 3_000_000 lines, about 72Mb,
>> pretty-printed) Emacs 29.0.50 opens the file just fine in
>> `js-json-mode` and when using regexp-based font locking, it works
>> well.
>>
>> When I force this buffer into javascript-mode, Emacs hangs. Memory
>> consumption as reported by Windows task manager "dances" around 2Gb,
>> yet even after waiting for three minutes, Emacs doesn't get responsive
>> any more.
>>
>> I consider this an unfortunately regression as recent commits to Emacs
>> 29 (long lines patches) actually makes working with such large files
>> with long lines absolutely pleasant, yet as it seems the interaction
>> with tree-sitter destroys this gains.
>
> Copying in Yuan Fu.

Again, sorry for the delay, I just saw this report :-)

Since your previous report is actually about emacs-tree-sitter, I think
this one is too?

Anyway, since tree-sitter is merged into master now, if you rebuild
master and turn on json-ts-mode, you should be in tree-sitter backed
JSON mode. I’d give that a try and see if works fine.

Thanks,
Yuan

bug#58979: treesitter-regression with json-mode

[Yuan Fu]

Yuan Fu <casouri@gmail.com> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Johann Höchtl <johann.hoechtl@gmail.com> writes:
>>
>>> When I open a large json file (about 3_000_000 lines, about 72Mb,
>>> pretty-printed) Emacs 29.0.50 opens the file just fine in
>>> `js-json-mode` and when using regexp-based font locking, it works
>>> well.
>>>
>>> When I force this buffer into javascript-mode, Emacs hangs. Memory
>>> consumption as reported by Windows task manager "dances" around 2Gb,
>>> yet even after waiting for three minutes, Emacs doesn't get responsive
>>> any more.
>>>
>>> I consider this an unfortunately regression as recent commits to Emacs
>>> 29 (long lines patches) actually makes working with such large files
>>> with long lines absolutely pleasant, yet as it seems the interaction
>>> with tree-sitter destroys this gains.
>>
>> Copying in Yuan Fu.
>
> Again, sorry for the delay, I just saw this report :-)
>
> Since your previous report is actually about emacs-tree-sitter, I think
> this one is too?
>
> Anyway, since tree-sitter is merged into master now, if you rebuild
> master and turn on json-ts-mode, you should be in tree-sitter backed
> JSON mode. I’d give that a try and see if works fine.
>
> Thanks,
> Yuan

Closing this report since I think there’s nothing to do. Feel free to
reopen.

Yuan