From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Harsanyi Newsgroups: gmane.emacs.bugs Subject: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 Date: Sat, 9 Jun 2018 08:01:31 +0800 Message-ID: References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1528525449 764 195.159.176.226 (9 Jun 2018 06:24:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Jun 2018 06:24:09 +0000 (UTC) Cc: Noam Postavsky , 31742@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 09 08:24:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRXIC-00006d-KL for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jun 2018 08:24:04 +0200 Original-Received: from localhost ([::1]:39192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRXKJ-0000zt-Ho for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jun 2018 02:26:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRXKA-0000zm-0d for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 02:26:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRXK6-0005my-S5 for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 02:26:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRXK6-0005mk-NH for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 02:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fRXK6-0007e2-GH for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 02:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Harsanyi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jun 2018 06:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31742 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31742-submit@debbugs.gnu.org id=B31742.152852553529344 (code B ref 31742); Sat, 09 Jun 2018 06:26:02 +0000 Original-Received: (at 31742) by debbugs.gnu.org; 9 Jun 2018 06:25:35 +0000 Original-Received: from localhost ([127.0.0.1]:40242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRXJf-0007dE-3e for submit@debbugs.gnu.org; Sat, 09 Jun 2018 02:25:35 -0400 Original-Received: from mail-io0-f194.google.com ([209.85.223.194]:44670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRRK6-0006x0-4Z for 31742@debbugs.gnu.org; Fri, 08 Jun 2018 20:01:38 -0400 Original-Received: by mail-io0-f194.google.com with SMTP id g7-v6so17739212ioh.11 for <31742@debbugs.gnu.org>; Fri, 08 Jun 2018 17:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cAqpVI5ZHB+NpccNHqlWjHJHYKFI7/hVlU04WjOqROQ=; b=IaHxaXXtOsmCpt+p1o4NVr0wWDzxegmmE4XLqkqTbAobLo+WV2Mm51tONfB8Oaewli yU7D8DTnpsLIbQuZDdwTJlbw98zsplbqJEO4Wrpz5ubRcy1w2H/lhdHhVlbB10on2IDT gwpsdDvsME4NZrkgwosgdKEV+phw/x5cZawx1XH892ZUhEiIjc7BNTrk68gG//qbH4MD T9HK48pxt/TXfSu/Unvy77B/ywytSt2iqS5q/PZ93DwucQzBiCD2bjlkJ5d7hgOnNmEF wywQS1NzTMF9Wj7shKGTh80MuEEdZOijx+TY5tGa776+hT3GhBeROZpwobfZyfHpkPpo QTyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cAqpVI5ZHB+NpccNHqlWjHJHYKFI7/hVlU04WjOqROQ=; b=N0PoC0rwPrZHfUzBGf0F2E6oVpZaBZo1Skz/vwLxhBAuu3W9jVVavWlUpVV9ZIUfsU ACLEqY70pl32XSkcjhFy9JVbr6w5+7DFd9E8chUJBbkZCJmW3U0gz4ah3v2ETbDW4KYS RidQ1v/RPorhRolB0NXnHw/L1rEHEecoY8JEaezREmVAAlmWx/xYmjrnrbAZnRAEsK/9 lFjdTW6xhznU/QmQrBvh5Qshp+fpLl3KN2agf0h6Yb5xderV6XSswK1TuTK1OYBnN/4v /jYnWQ884ucn0Bxyf9VA3Xbq/cBVRkDy+4lzjckC2QV6AGNuHlVMy7V9a6N6Xzg4NTYk XE3A== X-Gm-Message-State: APt69E3P2R+1/PzELCJsjArSFJpkAs+YyI940GFKh2dw+h2Q2A1pDLVN b46/BrXEYeqoEcJ8jEy+Mp2kw/Bso7obSQwciA4= X-Google-Smtp-Source: ADUXVKLnq8zKZAd7nW0XVJkqfWE42XPb7yFsIMFsdI3IO7QRTtUt3OS5uHr3nRG9UQMGY7ArVUYos5foFzEsZem2e4w= X-Received: by 2002:a6b:87d8:: with SMTP id r85-v6mr7587737ioi.243.1528502492399; Fri, 08 Jun 2018 17:01:32 -0700 (PDT) Original-Received: by 2002:a5e:c116:0:0:0:0:0 with HTTP; Fri, 8 Jun 2018 17:01:31 -0700 (PDT) In-Reply-To: X-Mailman-Approved-At: Sat, 09 Jun 2018 02:25:33 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147222 Archived-At: On Fri, Jun 8, 2018 at 10:18 PM, Thomas Fitzsimmons wrote: > (CCing Alex Harsanyi.) > > Noam Postavsky writes: > >> Thomas Fitzsimmons writes: >> >>> Noam Postavsky writes: >>> >>>> Thomas Fitzsimmons writes: >>>> >>>>> (defun soap-resolve-references (element wsdl) >>>> >>>>> (let ((resolver (get (aref element 0) 'soap-resolve-references))) >>>> >>>> Ah, then it should work to replace the (aref element 0) with (type-of >>>> element) as long as cl-old-struct-compat-mode is enabled. >>> >>> Yes, I retested with that change and it does work. I guess I should >>> submit a patch to change all those occurrences in soap-client. >> >> I just noticed soap-client is also an ELPA package; then there is the >> additional complication that type-of will give the wrong answer in Emacs >> versions 25 and older. So you would need something like >> >> (let ((type (type-of element))) >> (if (eq type 'vector) >> (aref element 0) ; For Emacs 25 and earlier. >> type)) > > OK, I had that on my list to investigate before patching soap-client, > the compatibility range of type-of, but you've done it for me, thanks. > A soap-type-of compatibility function probably makes sense to replace > the (aref ... 0) occurrences in soap-client and soap-inspect. > >>> I'm hoping cl-old-struct-compat-mode will continue to be enabled by >>> default for a long time. >> The `(aref element 0)` trick is the only one that `soap-client` uses. All other struct usage is via accessor functions, the rest of the code does not assume they are vectors. It seems to me that `cl-old-struct-compat-mode` is not needed. Thomas, will you prepare the patch for soap-client? Thanks, Alex.