From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dave Barker Newsgroups: gmane.emacs.devel Subject: Re: PATCH: Add the ability to give rcirc servers an alias name Date: Fri, 18 Dec 2015 10:46:13 +0000 Message-ID: References: <877flsgut2.fsf@gmail.com> <1447008724.187480.432504041.0E012C01@webmail.messagingengine.com> <1450246571.999218.468767129.1BD269CA@webmail.messagingengine.com> <1450377627.2542222.470336049.757BB9A6@webmail.messagingengine.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113ed67828878d052729d9a2 X-Trace: ger.gmane.org 1450435586 31058 80.91.229.3 (18 Dec 2015 10:46:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Dec 2015 10:46:26 +0000 (UTC) Cc: Leo Liu , Artur Malabarba , emacs-devel@gnu.org To: Ryan Yeske Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 18 11:46:25 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a9sYH-0000VJ-RF for ged-emacs-devel@m.gmane.org; Fri, 18 Dec 2015 11:46:22 +0100 Original-Received: from localhost ([::1]:59512 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9sYH-0006pt-82 for ged-emacs-devel@m.gmane.org; Fri, 18 Dec 2015 05:46:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9sYC-0006n1-DQ for emacs-devel@gnu.org; Fri, 18 Dec 2015 05:46:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9sYB-0008J0-0m for emacs-devel@gnu.org; Fri, 18 Dec 2015 05:46:16 -0500 Original-Received: from mail-io0-x229.google.com ([2607:f8b0:4001:c06::229]:34487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9sYA-0008Iw-NQ for emacs-devel@gnu.org; Fri, 18 Dec 2015 05:46:14 -0500 Original-Received: by mail-io0-x229.google.com with SMTP id e126so85486573ioa.1 for ; Fri, 18 Dec 2015 02:46:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kzar-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=UsD0LcK4M+x5h4s7XEL6unzHsTUzhoxrtJM3yCWX2ic=; b=bcrUVXe3eQmh+T8w4GjbvP5MMmg39QpK5y7rl/EYCB7Z6KCWu69yvRC0gGJlDMijTT l7MzIBr/tJl3FnvRrBPVz6Fe2Eds7N3cNOqr3FpY/eeeveoESAkq+tqMFpjc7LWQ2OsJ JPytEH/pVeiVr0o8cPKSC+/o17hRehSf30dv2ZT8oR4FI0OQqXlh8AIYMLqDwFYoSLzb 13yxwXicXHG6alFhnKdol3cYg6oBsKf/XGfk2Wzgbu/uAigpKvOpnLFSRXJP3zj2b535 bZNJ3nm+S/G/HEBMyNQo/xK5fHQYDo9qx7mJUedGu9SrJQD++0pPVJCCkoDfocjmypLK pQ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=UsD0LcK4M+x5h4s7XEL6unzHsTUzhoxrtJM3yCWX2ic=; b=NHPBp+sCWDKt+1Voi97GtbCCRNyaOIisPFHad0Nus4l4NUWqFeKI8+bMBoUCTBvUJy RMe4Hae+hc4KGLx3nSu3H6kb6KOBBZfmSOOyMVerl8PZVLqrk4koFMA2ZhxXpRV/imeN MiH29buiVqcleVosBx03RSYmYOGD0bf7iaB6CVUH+Py2W2r+xsRwH+Q48BYVm4/10qgA YEMG4ey4ZLxTdu4e5+Ue6BWPsgm5m1rsYos41JLkIukSL5mQKo2yGNQvYpLTdy7zIX8y wsqkQZ7hrGSAMdKYhnZQ3ePvHEJVphwjETP9rMk5GXPjmdIwapJ6AaL+l5Bk1L6VR7Hn 7/cg== X-Gm-Message-State: ALoCoQmLJX3Hi3SKy3m6aKhy6wpi5Ve6GcjG3xDbYDTGiiMsjZQIIkmJQ6XiDIMfO9e4CYrq0l572tCByuG56EpUbaXhGQastg== X-Received: by 10.107.17.160 with SMTP id 32mr4152280ior.28.1450435573985; Fri, 18 Dec 2015 02:46:13 -0800 (PST) Original-Received: by 10.107.38.130 with HTTP; Fri, 18 Dec 2015 02:46:13 -0800 (PST) In-Reply-To: <1450377627.2542222.470336049.757BB9A6@webmail.messagingengine.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c06::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196464 Archived-At: --001a113ed67828878d052729d9a2 Content-Type: multipart/alternative; boundary=001a113ed678288787052729d9a0 --001a113ed678288787052729d9a0 Content-Type: text/plain; charset=UTF-8 I'm not sure, this is the first time I've contributed to the project. Hopefully someone else knows how we can get this pushed? (I've attached it again in case it helps.) Cheers, Dave. On Thu, Dec 17, 2015 at 6:40 PM, Ryan Yeske wrote: > Thanks for all your patience with this Dave. > > I think you are right on both counts. Creating a helper function doesn't > really work. And creating multiple connections to one server is almost > never what we would want. > > I approve this patch. What is the next step to getting this merged into > emacs? > > Ryan > --001a113ed678288787052729d9a0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I'm not sure, this is the first time I've contribu= ted to the project. Hopefully someone else knows how we can get this pushed= ?

(I've attached it again in case it helps.)

Cheers, Dave.


On Thu, Dec 17, 2015 at 6:40 PM, Ryan Ye= ske <ryan@ryanyeske.com> wrote:
Thanks for all your patience with this Dave.
=C2=A0
I think you are right on both counts.=C2=A0 Creating a helper function= doesn't really work.=C2=A0 And creating multiple connections to one se= rver is almost never what we would want.
=C2=A0
I approve this patch.=C2=A0 What is the next step to getting this merg= ed into emacs?
<= font color=3D"#888888">
=C2=A0
Ryan
--001a113ed678288787052729d9a0-- --001a113ed67828878d052729d9a2 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Add-ability-to-give-rcirc-servers-an-alias-name.patch" Content-Disposition: attachment; filename="0001-Add-ability-to-give-rcirc-servers-an-alias-name.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iibjvqgt0 RnJvbSA4ZTc2ZjhkZDQzZDEzN2IyM2UzZjQzZjYxNjQxZmYyNmI0NWJiNjQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZlIEJhcmtlciA8a3phckBremFyLmNvLnVrPgpEYXRlOiBT YXQsIDcgTm92IDIwMTUgMjI6MzI6NTEgKzAwMDAKU3ViamVjdDogW1BBVENIXSBBZGQgYWJpbGl0 eSB0byBnaXZlIHJjaXJjIHNlcnZlcnMgYW4gYWxpYXMgbmFtZQoKLS0tCiBsaXNwL25ldC9yY2ly Yy5lbCB8IDM2ICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQogMSBmaWxlIGNo YW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xp c3AvbmV0L3JjaXJjLmVsIGIvbGlzcC9uZXQvcmNpcmMuZWwKaW5kZXggZDU4ZjNlYi4uODlhNDQ2 ZiAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvcmNpcmMuZWwKKysrIGIvbGlzcC9uZXQvcmNpcmMuZWwK QEAgLTEwMyw3ICsxMDMsMTIgQEAgY29ubmVjdGVkIHRvIGF1dG9tYXRpY2FsbHkuCiBgOmVuY3J5 cHRpb24nCiAKIFZBTFVFIG11c3QgYmUgYHBsYWluJyAodGhlIGRlZmF1bHQpIGZvciB1bmVuY3J5 cHRlZCBjb25uZWN0aW9ucywgb3IgYHRscycKLWZvciBjb25uZWN0aW9ucyB1c2luZyBTU0wvVExT LiIKK2ZvciBjb25uZWN0aW9ucyB1c2luZyBTU0wvVExTLgorCitgOnNlcnZlci1hbGlhcycKKwor VkFMVUUgbXVzdCBiZSBhIHN0cmluZyB0aGF0IHdpbGwgYmUgdXNlZCBpbnN0ZWFkIG9mIHRoZSBz ZXJ2ZXIgbmFtZSBmb3IKK2Rpc3BsYXkgcHVycG9zZXMuIElmIGFic2VudCwgdGhlIHJlYWwgc2Vy dmVyIG5hbWUgd2lsbCBiZSBkaXNwbGF5ZWQgaW5zdGVhZC4iCiAgIDp0eXBlICcoYWxpc3QgOmtl eS10eXBlIHN0cmluZwogCQk6dmFsdWUtdHlwZSAocGxpc3QgOm9wdGlvbnMKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKCg6bmljayBzdHJpbmcpCkBAIC0xMTMsNyArMTE4LDgg QEAgZm9yIGNvbm5lY3Rpb25zIHVzaW5nIFNTTC9UTFMuIgogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKDpmdWxsLW5hbWUgc3RyaW5nKQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKDpjaGFubmVscyAocmVwZWF0IHN0cmluZykpCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoOmVuY3J5cHRpb24gKGNob2ljZSAoY29uc3QgdGxzKQot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGNvbnN0IHBsYWluKSkpKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAoY29uc3QgcGxhaW4pKSkKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICg6c2VydmVyLWFsaWFzIHN0cmluZykpKSkKICAgOmdyb3VwICdyY2ly YykKIAogKGRlZmN1c3RvbSByY2lyYy1kZWZhdWx0LXBvcnQgNjY2NwpAQCAtNDg0LDIyICs0OTAs MjYgQEAgSWYgQVJHIGlzIG5vbi1uaWwsIGluc3RlYWQgcHJvbXB0IGZvciBjb25uZWN0aW9uIHBh cmFtZXRlcnMuIgogCSAgICAgIChjaGFubmVscyAocGxpc3QtZ2V0IChjZHIgYykgOmNoYW5uZWxz KSkKICAgICAgICAgICAgICAgKHBhc3N3b3JkIChwbGlzdC1nZXQgKGNkciBjKSA6cGFzc3dvcmQp KQogICAgICAgICAgICAgICAoZW5jcnlwdGlvbiAocGxpc3QtZ2V0IChjZHIgYykgOmVuY3J5cHRp b24pKQorICAgICAgICAgICAgICAoc2VydmVyLWFsaWFzIChwbGlzdC1nZXQgKGNkciBjKSA6c2Vy dmVyLWFsaWFzKSkKICAgICAgICAgICAgICAgY29udGFjdCkKIAkgICh3aGVuIHNlcnZlcgogCSAg ICAobGV0IChjb25uZWN0ZWQpCiAJICAgICAgKGRvbGlzdCAocCAocmNpcmMtcHJvY2Vzcy1saXN0 KSkKLQkJKHdoZW4gKHN0cmluZz0gc2VydmVyIChwcm9jZXNzLW5hbWUgcCkpCisJCSh3aGVuIChz dHJpbmc9IChvciBzZXJ2ZXItYWxpYXMgc2VydmVyKSAocHJvY2Vzcy1uYW1lIHApKQogCQkgIChz ZXRxIGNvbm5lY3RlZCBwKSkpCiAJICAgICAgKGlmIChub3QgY29ubmVjdGVkKQogCQkgIChjb25k aXRpb24tY2FzZSBuaWwKIAkJICAgICAgKHJjaXJjLWNvbm5lY3Qgc2VydmVyIHBvcnQgbmljayB1 c2VyLW5hbWUKLQkJCQkgICAgIGZ1bGwtbmFtZSBjaGFubmVscyBwYXNzd29yZCBlbmNyeXB0aW9u KQotCQkgICAgKHF1aXQgKG1lc3NhZ2UgIlF1aXQgY29ubmVjdGluZyB0byAlcyIgc2VydmVyKSkp CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZnVsbC1uYW1lIGNoYW5uZWxz IHBhc3N3b3JkIGVuY3J5cHRpb24KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzZXJ2ZXItYWxpYXMpCisJCSAgICAocXVpdCAobWVzc2FnZSAiUXVpdCBjb25uZWN0aW5nIHRv ICVzIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAob3Igc2VydmVyLWFsaWFz IHNlcnZlcikpKSkKIAkJKHdpdGgtY3VycmVudC1idWZmZXIgKHByb2Nlc3MtYnVmZmVyIGNvbm5l Y3RlZCkKICAgICAgICAgICAgICAgICAgIChzZXRxIGNvbnRhY3QgKHByb2Nlc3MtY29udGFjdAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGdldC1idWZmZXItcHJvY2VzcyAoY3Vy cmVudC1idWZmZXIpKSA6aG9zdCkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo Z2V0LWJ1ZmZlci1wcm9jZXNzIChjdXJyZW50LWJ1ZmZlcikpIDpuYW1lKSkKICAgICAgICAgICAg ICAgICAgIChzZXRxIGNvbm5lY3RlZC1zZXJ2ZXJzCi0gICAgICAgICAgICAgICAgICAgICAgICAo Y29ucyAoaWYgKHN0cmluZ3AgY29udGFjdCkgY29udGFjdCBzZXJ2ZXIpCisgICAgICAgICAgICAg ICAgICAgICAgICAoY29ucyAoaWYgKHN0cmluZ3AgY29udGFjdCkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb250YWN0IChvciBzZXJ2ZXItYWxpYXMgc2VydmVyKSkKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbm5lY3RlZC1zZXJ2ZXJzKSkpKSkpKSkKICAgICAg ICh3aGVuIGNvbm5lY3RlZC1zZXJ2ZXJzCiAJKG1lc3NhZ2UgIkFscmVhZHkgY29ubmVjdGVkIHRv ICVzIgpAQCAtNTI4LDkgKzUzOCwxMCBAQCBJZiBBUkcgaXMgbm9uLW5pbCwgaW5zdGVhZCBwcm9t cHQgZm9yIGNvbm5lY3Rpb24gcGFyYW1ldGVycy4iCiAKIDs7OyMjI2F1dG9sb2FkCiAoZGVmdW4g cmNpcmMtY29ubmVjdCAoc2VydmVyICZvcHRpb25hbCBwb3J0IG5pY2sgdXNlci1uYW1lCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGZ1bGwtbmFtZSBzdGFydHVwLWNoYW5uZWxzIHBhc3N3 b3JkIGVuY3J5cHRpb24pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZ1bGwtbmFtZSBz dGFydHVwLWNoYW5uZWxzIHBhc3N3b3JkIGVuY3J5cHRpb24KKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgc2VydmVyLWFsaWFzKQogICAoc2F2ZS1leGN1cnNpb24KLSAgICAobWVzc2FnZSAi Q29ubmVjdGluZyB0byAlcy4uLiIgc2VydmVyKQorICAgIChtZXNzYWdlICJDb25uZWN0aW5nIHRv ICVzLi4uIiAob3Igc2VydmVyLWFsaWFzIHNlcnZlcikpCiAgICAgKGxldCogKChpbmhpYml0LWVv bC1jb252ZXJzaW9uKQogICAgICAgICAgICAocG9ydC1udW1iZXIgKGlmIHBvcnQKIAkJCSAgICAo aWYgKHN0cmluZ3AgcG9ydCkKQEAgLTU0Miw3ICs1NTMsNyBAQCBJZiBBUkcgaXMgbm9uLW5pbCwg aW5zdGVhZCBwcm9tcHQgZm9yIGNvbm5lY3Rpb24gcGFyYW1ldGVycy4iCiAJICAgKGZ1bGwtbmFt ZSAob3IgZnVsbC1uYW1lIHJjaXJjLWRlZmF1bHQtZnVsbC1uYW1lKSkKIAkgICAoc3RhcnR1cC1j aGFubmVscyBzdGFydHVwLWNoYW5uZWxzKQogICAgICAgICAgICAocHJvY2VzcyAob3Blbi1uZXR3 b3JrLXN0cmVhbQotICAgICAgICAgICAgICAgICAgICAgc2VydmVyIG5pbCBzZXJ2ZXIgcG9ydC1u dW1iZXIKKyAgICAgICAgICAgICAgICAgICAgIChvciBzZXJ2ZXItYWxpYXMgc2VydmVyKSBuaWwg c2VydmVyIHBvcnQtbnVtYmVyCiAgICAgICAgICAgICAgICAgICAgICA6dHlwZSAob3IgZW5jcnlw dGlvbiAncGxhaW4pKSkpCiAgICAgICA7OyBzZXQgdXAgcHJvY2VzcwogICAgICAgKHNldC1wcm9j ZXNzLWNvZGluZy1zeXN0ZW0gcHJvY2VzcyAncmF3LXRleHQgJ3Jhdy10ZXh0KQpAQCAtNTU3LDcg KzU2OCw4IEBAIElmIEFSRyBpcyBub24tbmlsLCBpbnN0ZWFkIHByb21wdCBmb3IgY29ubmVjdGlv biBwYXJhbWV0ZXJzLiIKIAkJCXBhc3N3b3JkIGVuY3J5cHRpb24pKQogICAgICAgKHNldHEtbG9j YWwgcmNpcmMtcHJvY2VzcyBwcm9jZXNzKQogICAgICAgKHNldHEtbG9jYWwgcmNpcmMtc2VydmVy IHNlcnZlcikKLSAgICAgIChzZXRxLWxvY2FsIHJjaXJjLXNlcnZlci1uYW1lIHNlcnZlcikgOyBV cGRhdGUgd2hlbiB3ZSBnZXQgMDAxIHJlc3BvbnNlLgorICAgICAgKHNldHEtbG9jYWwgcmNpcmMt c2VydmVyLW5hbWUKKyAgICAgICAgICAgICAgICAgIChvciBzZXJ2ZXItYWxpYXMgc2VydmVyKSkg OyBVcGRhdGUgd2hlbiB3ZSBnZXQgMDAxIHJlc3BvbnNlLgogICAgICAgKHNldHEtbG9jYWwgcmNp cmMtYnVmZmVyLWFsaXN0IG5pbCkKICAgICAgIChzZXRxLWxvY2FsIHJjaXJjLW5pY2stdGFibGUg KG1ha2UtaGFzaC10YWJsZSA6dGVzdCAnZXF1YWwpKQogICAgICAgKHNldHEtbG9jYWwgcmNpcmMt bmljayBuaWNrKQpAQCAtNTg0LDcgKzU5Niw3IEBAIElmIEFSRyBpcyBub24tbmlsLCBpbnN0ZWFk IHByb21wdCBmb3IgY29ubmVjdGlvbiBwYXJhbWV0ZXJzLiIKIAkoc2V0cSByY2lyYy1rZWVwYWxp dmUtdGltZXIKIAkgICAgICAocnVuLWF0LXRpbWUgMCAoLyByY2lyYy10aW1lb3V0LXNlY29uZHMg MikgJ3JjaXJjLWtlZXBhbGl2ZSkpKQogCi0gICAgICAobWVzc2FnZSAiQ29ubmVjdGluZyB0byAl cy4uLmRvbmUiIHNlcnZlcikKKyAgICAgIChtZXNzYWdlICJDb25uZWN0aW5nIHRvICVzLi4uZG9u ZSIgKG9yIHNlcnZlci1hbGlhcyBzZXJ2ZXIpKQogCiAgICAgICA7OyByZXR1cm4gcHJvY2VzcyBv YmplY3QKICAgICAgIHByb2Nlc3MpKSkKLS0gCjIuMS40Cgo= --001a113ed67828878d052729d9a2--