From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Chris Hunt Newsgroups: gmane.emacs.bugs Subject: bug#44642: 27.1; read-string does not signal on EOF after calling server-eval-at Date: Sat, 14 Nov 2020 15:50:38 -0500 Message-ID: References: <83v9e7u65p.fsf@gnu.org> <83r1ovu2vm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12032"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44642@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 14 21:52:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ke2X1-00031f-6k for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Nov 2020 21:52:23 +0100 Original-Received: from localhost ([::1]:38596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ke2Wz-0000NU-Nw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Nov 2020 15:52:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke2Wg-0000NL-Cy for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 15:52:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40614) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ke2Wg-00038P-3b for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 15:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ke2Wg-0005RQ-0E for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 15:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chris Hunt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Nov 2020 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44642 X-GNU-PR-Package: emacs Original-Received: via spool by 44642-submit@debbugs.gnu.org id=B44642.160538708120862 (code B ref 44642); Sat, 14 Nov 2020 20:52:01 +0000 Original-Received: (at 44642) by debbugs.gnu.org; 14 Nov 2020 20:51:21 +0000 Original-Received: from localhost ([127.0.0.1]:52160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke2W1-0005QQ-EA for submit@debbugs.gnu.org; Sat, 14 Nov 2020 15:51:21 -0500 Original-Received: from mail-oo1-f46.google.com ([209.85.161.46]:47058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke2Vz-0005QD-Va for 44642@debbugs.gnu.org; Sat, 14 Nov 2020 15:51:20 -0500 Original-Received: by mail-oo1-f46.google.com with SMTP id c25so2974092ooe.13 for <44642@debbugs.gnu.org>; Sat, 14 Nov 2020 12:51:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pyvHokZYqKPg55w0z02dmV/pLViR4O9NyKZ2V4P4/tI=; b=V5NhfB91F+hH7SOVVkP1Qpo96HLoeq2Oi8z1n+P8DbJZpr+ygGUxgF51RqrCXuXeXu l3FFL+RRVGRVHXY8zTxKrjSTa8Y8Ee0MaTGslt+bn1dQvky7O1P7/HoeTXusbSRt1xoo c+xfyO2Vl8cNeR2J/MqIFyYchC4Mzb1FJx9loYU2d8qPtTYRZ/W8pd1ht3/3Pl8cYfQ9 mSHmNesXpqFXTOhbJUTlgOFPQjgIxZkau1um+PdJ5UXxihk1okvGiD+aavkJTyd8cBz1 h5fjmhJ/cqLRwAsNDCLZVSuPEktLE9azjn8/zXM2n/+28wgyQtKm+jEicJwv4keVjzOh 8CBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pyvHokZYqKPg55w0z02dmV/pLViR4O9NyKZ2V4P4/tI=; b=kPN0Jj0buENuBq6XBlI0bgl4TXIWUoiXAT/3id2iuHAk/bajmE6fiG8jtkxJJwKirc xgwk1LwOYGSrHa82+xF0SfrF9Lpllhy7BvwdKpn7BSHl9DpmwOwYUgl6GxL3YAOAnsKE yGFijMRv2YUkfMrXh8PVaAPetvvwQmpeHdreRm230ghIUHCIZtcvOQ7oZ4+WdgBR6TZ+ XDaV1s023ScqNtuv495PtB7OymtnNLbLy33ZCAlTP5klVBrDmvpd1ED3IkplNP0YQePE ScWN0o9WFRAIRjTCLghn/n25GKsIXnvAXDbHudiwSnQIPRgZ4uc/xi+cuWVsuCQ8izDC Up0g== X-Gm-Message-State: AOAM531ZQpcsQAHLQEqBPMCu0EgJRM/WFoiz1VNxu2SKAjaxTTHcohAr fRpQQPT7Q2WUCGYXV+jnDjFMm5rbLGmaBXH25KS3p58LBBZXfQ== X-Google-Smtp-Source: ABdhPJyhIg19toRFU52avsP3lyxtsywUMag5BiFn6RAUZpLGdycgNWH9uo2ISruAHAYz/mk4b35yGJccWjxEqS+3zkA= X-Received: by 2002:a4a:338d:: with SMTP id q135mr2049877ooq.21.1605387074335; Sat, 14 Nov 2020 12:51:14 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193334 Archived-At: > "if using `server-eval-at' in `--batch' mode, take care not > to possibly read to the end of input" Small clarification, in case it makes a difference for anyone searching later. I had inlined `server-eval-at' to try and root cause, and it looked to me like the call to `accept-process-output' here: https://github.com/emacs-mirror/emacs/blob/e3661f8c35b3057c58e8c0b474f597697ce413ba/lisp/server.el#L1737 was necessary to trigger the unexpected behavior. Without that call, subsequent calls to `read-string' did not hang.