[BUG] Org babel does not evaluate last line in Windows shell (cmdproxy.exe) code blocks [9.5.2 (release_9.5.2-25-gaf6f12 @ c:/tools/emacs-28.1/share/emacs/28.1/lisp/org/)]

[BUG] Org babel does not evaluate last line in Windows shell (cmdproxy.exe) code blocks [9.5.2 (release_9.5.2-25-gaf6f12 @ c:/tools/emacs-28.1/share/emacs/28.1/lisp/org/)]

[Osher Jacob]

[-- Attachment #1: Type: text/plain, Size: 6408 bytes --]

*Expected behaviour*:
All lines of the shell block should be evaluated, with full output printed.

*Actual behaviour*:
All lines but the last are evaluated, the output ends with 'More?'
instead of the last command's output.

*Steps to reproduce*:
In Windows, start a clean Emacs instance (I used "runemacs.exe -Q"), and
evaluate the following blocks:

1) Enable shell language support
#+begin_src elisp
(org-babel-do-load-languages
   'org-babel-load-languages
   '(
     (shell . t)
     )
   )
#+end_src

#+RESULTS:


2) Evaluate this shell code block
#+begin_src shell
  echo 1
  echo 2


#+end_src

#+RESULTS:
| Microsoft             | Windows   | [Version     | 10.0.19044.2364] |
   |           |
| (c)                   | Microsoft | Corporation. | All              |
rights | reserved. |
|                       |           |              |                  |
   |           |
| c:\Users\osherj>echo  | 1         |              |                  |
   |           |
| 1                     |           |              |                  |
   |           |
|                       |           |              |                  |
   |           |
| c:\Users\osherj>More? |           |              |                  |
   |           |


*Additional info:*
After some debugging, it seems to be caused by a missing newline character
at the
end of the code block content.
I believe this is caused by the org-trim function which is called upon the
body of the block.
At the function:
org/ob-shell.el -> (defun org-babel-sh-evaluate ...)
The line:
(org-babel-eval shell-file-name (org-trim body))

What led me to this conclusion, is because I've found that the function
"shell-command-on-region" (and I'm guessing its babel counterpart -
"org-babel--shell-command-on-region"), produces the same behaviour if the
region does not include a newline at its end.

Note: The bug seems to be reproducible in Emacs 28.2 as well

*Suggested fix*:
The hacky way I solved it was to change this line:
(t (org-babel-eval shell-file-name (org-trim body))))))
to this:
(t (org-babel-eval shell-file-name (concat (org-trim body) "\n"))))))

Let me know if there's any other information you need, or if I can help in
any other way.

Thanks!
Osher


Emacs  : GNU Emacs 28.1 (build 52, x86_64-w64-mingw32)
 of 2022-04-04
Package: Org mode version 9.5.2 (release_9.5.2-25-gaf6f12 @
c:/tools/emacs-28.1/share/emacs/28.1/lisp/org/)

current state:
==============
(setq
 org-link-elisp-confirm-function 'yes-or-no-p
 org-bibtex-headline-format-function #[257 "\300 \236A\207" [:title] 3
"\n\n(fn ENTRY)"]
 org-export-before-parsing-hook '(org-attach-expand-links)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-odt-format-inlinetask-function
'org-odt-format-inlinetask-default-function
 org-ascii-format-drawer-function #[771 " \207" [] 4 "\n\n(fn NAME CONTENTS
WIDTH)"]
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
org-cycle-show-empty-lines org-optimize-window-after-visibility-change)
 org-mode-hook '(#[0 "\300\301\302\303\304$\207" [add-hook
change-major-mode-hook org-show-all append local] 5] #[0
"\300\301\302\303\304$\207" [add-hook change-major-mode-hook
org-babel-show-result-all append local] 5] org-babel-result-hide-spec
org-babel-hide-all-hashes)
 org-babel-load-languages '((shell . t))
 org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
 org-latex-format-headline-function
'org-latex-format-headline-default-function
 org-confirm-shell-link-function 'yes-or-no-p
 org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 outline-isearch-open-invisible-function 'outline-isearch-open-invisible
 org-odt-format-headline-function 'org-odt-format-headline-default-function
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
org-src-mode-configure-edit-buffer)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-speed-command-hook '(org-speed-command-activate
org-babel-speed-command-activate)
 org-html-format-inlinetask-function
'org-html-format-inlinetask-default-function
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
 org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-latex-format-inlinetask-function
'org-latex-format-inlinetask-default-function
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
 org-link-shell-confirm-function 'yes-or-no-p
 org-babel-pre-tangle-hook '(save-buffer)
 org-agenda-loop-over-headlines-in-active-region nil
 org-occur-hook '(org-first-headline-recenter)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-link-parameters '(("attachment" :follow org-attach-follow :complete
org-attach-complete-link) ("id" :follow org-id-open) ("eww" :follow
org-eww-open :store org-eww-store-link) ("rmail" :follow org-rmail-open
:store org-rmail-store-link) ("mhe" :follow org-mhe-open :store
org-mhe-store-link)
      ("irc" :follow org-irc-visit :store org-irc-store-link :export
org-irc-export) ("info" :follow org-info-open :export org-info-export
:store org-info-store-link) ("gnus" :follow org-gnus-open :store
org-gnus-store-link)
      ("docview" :follow org-docview-open :export org-docview-export :store
org-docview-store-link) ("bibtex" :follow org-bibtex-open :store
org-bibtex-store-link) ("bbdb" :follow org-bbdb-open :export
org-bbdb-export :complete org-bbdb-complete-link :store org-bbdb-store-link)
      ("w3m" :store org-w3m-store-link) ("doi" :follow org-link-doi-open
:export org-link-doi-export) ("file+sys") ("file+emacs") ("shell" :follow
org-link--open-shell) ("news" :follow #[514 "\301\300\302 Q \"\207" ["news"
browse-url ":"] 6 "\n\n(fn URL ARG)"])
      ("mailto" :follow #[514 "\301\300\302 Q \"\207" ["mailto" browse-url
":"] 6 "\n\n(fn URL ARG)"]) ("https" :follow #[514 "\301\300\302 Q \"\207"
["https" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("http" :follow #[514
"\301\300\302 Q \"\207" ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"])
      ("ftp" :follow #[514 "\301\300\302 Q \"\207" ["ftp" browse-url ":"] 6
"\n\n(fn URL ARG)"]) ("help" :follow org-link--open-help :store
org-link--store-help) ("file" :complete org-link-complete-file) ("elisp"
:follow org-link--open-elisp))
 org-html-format-headline-function
'org-html-format-headline-default-function
 org-metaup-hook '(org-babel-load-in-session-maybe)
 )

[-- Attachment #2: Type: text/html, Size: 8090 bytes --]